Re: [PATCH v4 05/12] drm/xe/memirq: Report errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/xe: unused memirq_err() macro definition
--

commit 8ccc9e0c71be92f53616abc0b65b5b3ec006d967
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/memirq: Report errors using structured xe_log API

Replace memirq_err() calls with xe_log_err() using the MEMIRQ
component tag for memory-based IRQ failures.

> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 9dfe965cb46ec..32b9f87a10ecf 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c

[ ... ]

> @@ -370,8 +371,8 @@ int xe_memirq_init_guc(struct xe_memirq *memirq, struct xe_guc *guc)
>  	return 0;
>  
>  failed:
> -	memirq_err(memirq, "Failed to setup report pages in %s (%pe)\n",
> -		   guc_name(guc), ERR_PTR(err));
> +	xe_log_err(memirq_to_tile(memirq), MEMIRQ, err,
> +		   "Failed to setup report pages in %s\n", guc_name(guc));
>  	return err;
>  }

[Severity: Low]
Does this leave the memirq_err macro definition as unused dead code?

The macro definition in drivers/gpu/drm/xe/xe_memirq.c:

#define memirq_err(m, _fmt, ...)	memirq_printk(m, err, _fmt, ##__VA_ARGS__)

was not removed in this patch despite all of its call sites being replaced.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928092114.1610203-1-dnyaneshwar.bhadane@intel.com?part=5