Re: [PATCH v4 05/12] drm/xe/memirq: Report errors using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 28-09-2026 02:51 pm, Dnyaneshwar Bhadane wrote:
> Replace memirq_err() calls with xe_log_err() using the MEMIRQ
> component tag for memory-based IRQ failures
>
> v2:
> - No need to log ERR_PTR(err) explicitly (Mallesh)
> - Using tile instead of xe for more local log location(sashiko bot)
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
LGTM,
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_memirq.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 9dfe965cb46e..32b9f87a10ec 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c
> @@ -15,6 +15,7 @@
>   #include "xe_gt.h"
>   #include "xe_guc.h"
>   #include "xe_hw_engine.h"
> +#include "xe_log.h"
>   #include "xe_memirq.h"
>   #include "xe_tile_printk.h"
>   
> @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq)
>   	return 0;
>   
>   out:
> -	memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err));
> +	xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n");
>   	return err;
>   }
>   
> @@ -370,8 +371,8 @@ int xe_memirq_init_guc(struct xe_memirq *memirq, struct xe_guc *guc)
>   	return 0;
>   
>   failed:
> -	memirq_err(memirq, "Failed to setup report pages in %s (%pe)\n",
> -		   guc_name(guc), ERR_PTR(err));
> +	xe_log_err(memirq_to_tile(memirq), MEMIRQ, err,
> +		   "Failed to setup report pages in %s\n", guc_name(guc));
>   	return err;
>   }
>