Re: [PATCH v4 06/12] drm/xe/reg_sr: Report save-restore errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] xe_reg_sr: incomplete log API transition vs commit message
--

commit 4c8922a6ada2b08bcb96cfb27ef3430f71c97d7c
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/reg_sr: Report save-restore errors using structured xe_log API

This commit replaces older xe_gt_notice() and xe_gt_err() logging calls with
the newer structured xe_log_info() and xe_log_err() API for register
save and restore operations.

> Replace xe_gt_notice() and xe_gt_err() calls with xe_log_info() and
> xe_log_err() using the REGS and RTP component tag for register save-restore
> operations:
> 
>   - Failed to add register to save-restore list

[Severity: Medium]
The commit message states that the error log for failing to add a register
to the save-restore list is replaced. However, this update appears to be
missing from the patch. Was this change unintentionally dropped during a
rebase?

For reference, xe_reg_sr_add() still contains the old call:

fail:
	xe_gt_err(gt,
		  "discarding save-restore reg %04lx (clear: %08x, set: %08x, masked: %s, mcr: %s): ret=%d\n",
		  idx, e->clr_bits, e->set_bits,
		  str_yes_no(e->reg.masked),
		  str_yes_no(e->reg.mcr),
		  ret);

[ ... ]

> v3:
>  - Drop config mismatch log (Michal)

[ ... ]

> diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c
> index e328f50725572..eab84a528d122 100644
> --- a/drivers/gpu/drm/xe/xe_reg_sr.c
> +++ b/drivers/gpu/drm/xe/xe_reg_sr.c

[ ... ]

> @@ -87,15 +88,15 @@ static struct xe_reg sanitize_mcr(struct xe_reg_sr *sr,
>  
>  	if (is_mcr && !reg.mcr) {
>  		reg.mcr = 1;
> -		xe_gt_notice(gt, "xe_reg_sr_entry using non-MCR register for address 0x%x, forcing MCR\n",
> -			     reg.addr);
> +		xe_log_info(gt, RTP, "xe_reg_sr_entry using non-MCR register for address 0x%x, forcing MCR\n",
> +			    reg.addr);
>  		reg_sr_inc_error(sr);
>  	}
>  
>  	if (!is_mcr && reg.mcr) {
>  		reg.mcr = 0;
> -		xe_gt_notice(gt, "xe_reg_sr_entry using MCR register for address 0x%x, forcing non-MCR\n",
> -			     reg.addr);
> +		xe_log_info(gt, RTP, "xe_reg_sr_entry using MCR register for address 0x%x, forcing non-MCR\n",
> +			    reg.addr);
>  		reg_sr_inc_error(sr);
>  	}

[Severity: Medium]
The v3 changelog explicitly mentions dropping the config mismatch log, but
this patch updates the mismatch logs in sanitize_mcr() instead. Should these
hunks have been omitted to align with the v3 changelog?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928092114.1610203-1-dnyaneshwar.bhadane@intel.com?part=6