Re: [PATCH v4 04/12] drm/xe/mmio: Report BAR mapping errors using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]


On 28-09-2026 02:51 pm, Dnyaneshwar Bhadane wrote:
> Replace xe_err() calls with xe_log_err() and xe_log_err_fatal() using
nit: hmm, Remove xe_log_err macro, we used only xe_log_err_fatal right?
> the REGS component tag for MMIO BAR probe failures
>
> Signed-off-by: Dnyaneshwar Bhadane<dnyaneshwar.bhadane@intel.com>
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_mmio.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index 7fa18dfcb5a2..890146b8836b 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -15,6 +15,7 @@
>   #include "regs/xe_bars.h"
>   #include "xe_device.h"
>   #include "xe_gt_sriov_vf.h"
> +#include "xe_log.h"
>   #include "xe_printk.h"
>   #include "xe_sriov.h"
>   #include "xe_tile_printk.h"
> @@ -71,8 +72,8 @@ int xe_mmio_probe_tiles(struct xe_device *xe)
>   		return 0;
>   
>   	if (xe->mmio.size < xe->info.tile_count * tile_mmio_size) {
> -		xe_err(xe, "GTTMMADR_BAR is too small for %d tiles: %zu\n",
> -		       xe->info.tile_count, xe->mmio.size);
> +		xe_log_err_fatal(xe, REGS, -EIO, "GTTMMADR_BAR is too small for %d tiles: %zu\n",
> +				 xe->info.tile_count, xe->mmio.size);
>   		return -EIO;
>   	}
>   
> @@ -105,13 +106,16 @@ int xe_mmio_probe_early(struct xe_device *xe)
>   
>   	xe->mmio.regs = pcim_iomap(pdev, GTTMMADR_BAR, 0);
>   	if (!xe->mmio.regs) {
> -		xe_err(xe, "Failed to map GTTMMADR_BAR\n");
> +		xe_log_err_fatal(xe, REGS, -EIO,
> +				 "Failed to map GTTMMADR_BAR\n");
>   		return -EIO;
>   	}
>   
>   	xe->mmio.size = pci_resource_len(pdev, GTTMMADR_BAR);
>   	if (xe->mmio.size < SZ_16M) {
> -		xe_err(xe, "GTTMMADR_BAR is too small: %zu\n", xe->mmio.size);
> +		xe_log_err_fatal(xe, REGS, -EIO,
> +				 "GTTMMADR_BAR is too small: %zu\n",
> +				 xe->mmio.size);
>   		return -EIO;
>   	}
>   

[-- Attachment #2: Type: text/html, Size: 2960 bytes --]