All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: dts: imx6: phytec-mira: phyBOARD-Mira fixes
@ 2026-09-30 10:34 Primoz Fiser
  2026-09-30 10:34 ` [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals Primoz Fiser
  2026-09-30 10:34 ` [PATCH 2/2] ARM: dts: imx6qdl-phytec-mira: Add touchscreen-inverted properties Primoz Fiser
  0 siblings, 2 replies; 5+ messages in thread
From: Primoz Fiser @ 2026-09-30 10:34 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, upstream

Two small fixes for the PHYTEC phyBOARD-Mira-i.MX6 boards:

- The i.MX6DL NAND variant was still described as the LC (Low Cost)
  board, missing CAN/PCIe and capped at 100Mbps Ethernet, while every
  other in-tree phyBOARD-Mira .dts is the FF (Full Featured) variant.
  Sync it to match its siblings (1/2).
- Since commit 888e5fad9b78 ("Input: stmpe - add axis inversion and
  swapping capability") landed, the touchscreen axis inversion these
  boards need can be described in devicetree instead of userspace (2/2).


Primoz Fiser (2):
  ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
  ARM: dts: imx6qdl-phytec-mira: Add touchscreen-inverted properties

 arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts | 8 ++++++--
 arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi        | 2 ++
 2 files changed, 8 insertions(+), 2 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
  2026-09-30 10:34 [PATCH 0/2] ARM: dts: imx6: phytec-mira: phyBOARD-Mira fixes Primoz Fiser
@ 2026-09-30 10:34 ` Primoz Fiser
  2026-09-30 10:40   ` sashiko-bot
  2026-09-30 10:34 ` [PATCH 2/2] ARM: dts: imx6qdl-phytec-mira: Add touchscreen-inverted properties Primoz Fiser
  1 sibling, 1 reply; 5+ messages in thread
From: Primoz Fiser @ 2026-09-30 10:34 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, upstream

The current imx6dl-phytec-mira-rdk-nand.dts describes the LC (Low Cost)
variant of the board. However all phyBOARD-Mira boards in-tree are
actually the FF (Full Featured) variants. Now, sync the i.MX6 DL NAND
variant device-tree and enable all peripherals (CAN, PCIe and no speed
limit on Ethernet PHY) to enable all RDK board features.

Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
 arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
index 8ec27080ca1e..c2780ecb5936 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
@@ -22,8 +22,8 @@ chosen {
 	};
 };
 
-&ethphy {
-	max-speed = <100>;
+&can1 {
+	status = "okay";
 };
 
 &fec {
@@ -50,6 +50,10 @@ &i2c_rtc {
 	status = "okay";
 };
 
+&pcie {
+	status = "okay";
+};
+
 &uart3 {
 	status = "okay";
 };
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: imx6qdl-phytec-mira: Add touchscreen-inverted properties
  2026-09-30 10:34 [PATCH 0/2] ARM: dts: imx6: phytec-mira: phyBOARD-Mira fixes Primoz Fiser
  2026-09-30 10:34 ` [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals Primoz Fiser
@ 2026-09-30 10:34 ` Primoz Fiser
  1 sibling, 0 replies; 5+ messages in thread
From: Primoz Fiser @ 2026-09-30 10:34 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, upstream

Since commit 888e5fad9b78 ("Input: stmpe - add axis inversion and
swapping capability") we can handle touchscreen x- and y-axis inversion
directly in the kernel instead of user-space on phyBOARD-Mira-i.MX6.

Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
index a3c2811e9c6f..a7d6af162731 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
@@ -164,6 +164,8 @@ stmpe: touchctrl@44 {
 
 		touchscreen {
 			compatible = "st,stmpe-ts";
+			touchscreen-inverted-x;
+			touchscreen-inverted-y;
 			st,sample-time = <4>;
 			st,mod-12b = <1>;
 			st,ref-sel = <0>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
  2026-09-30 10:34 ` [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals Primoz Fiser
@ 2026-09-30 10:40   ` sashiko-bot
  2026-09-30 13:51     ` Primoz Fiser
  0 siblings, 1 reply; 5+ messages in thread
From: sashiko-bot @ 2026-09-30 10:40 UTC (permalink / raw)
  To: Primoz Fiser; +Cc: robh, Frank.Li, imx, conor+dt, devicetree

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: imx6dl-phytec-mira: missing m25p80 SPI NOR flash enablement
--

commit 1324c8cd36593c2b5134e1d0d30d31d809ac1bc1
Author: Primoz Fiser <primoz.fiser@norik.com>

ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals

This commit syncs the i.MX6 DL NAND variant device tree to match the Full
Featured (FF) variants. It enables peripherals including CAN and PCIe, and
removes the speed limit on the Ethernet PHY.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
> index d906a7f05aaad..1f827ad2ff5ee 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts

[ ... ]

> @@ -50,6 +50,10 @@ &i2c_rtc {
>  	status = "okay";
>  };
>  
> +&pcie {
> +	status = "okay";
> +};
> +

[Severity: Medium]
Did this omit the SPI NOR flash enablement?

The commit message states the intent to sync the i.MX6 DL NAND variant to
match the Full Featured (FF) boards by enabling all peripherals.

The FF Quad variant (imx6q-phytec-mira-rdk-nand.dts) enables the SPI NOR flash
by including &m25p80 { status = "okay"; };. While &can1, &pcie, and the
unrestricted &ethphy are enabled, the &m25p80 node is missing here.

Does this leave the board missing its SPI flash feature and partially
unsynchronized compared to the other FF variants?

>  &uart3 {
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260930103425.2315286-1-primoz.fiser@norik.com?part=1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
  2026-09-30 10:40   ` sashiko-bot
@ 2026-09-30 13:51     ` Primoz Fiser
  0 siblings, 0 replies; 5+ messages in thread
From: Primoz Fiser @ 2026-09-30 13:51 UTC (permalink / raw)
  To: sashiko-reviews; +Cc: robh, Frank.Li, imx, conor+dt, devicetree

Hi,

On 9/30/26 12:40, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] dts: imx6dl-phytec-mira: missing m25p80 SPI NOR flash enablement
> --
> 
> commit 1324c8cd36593c2b5134e1d0d30d31d809ac1bc1
> Author: Primoz Fiser <primoz.fiser@norik.com>
> 
> ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals
> 
> This commit syncs the i.MX6 DL NAND variant device tree to match the Full
> Featured (FF) variants. It enables peripherals including CAN and PCIe, and
> removes the speed limit on the Ethernet PHY.
> 
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
>> index d906a7f05aaad..1f827ad2ff5ee 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6dl-phytec-mira-rdk-nand.dts
> 
> [ ... ]
> 
>> @@ -50,6 +50,10 @@ &i2c_rtc {
>>  	status = "okay";
>>  };
>>  
>> +&pcie {
>> +	status = "okay";
>> +};
>> +
> 
> [Severity: Medium]
> Did this omit the SPI NOR flash enablement?
> 
> The commit message states the intent to sync the i.MX6 DL NAND variant to
> match the Full Featured (FF) boards by enabling all peripherals.
> 
> The FF Quad variant (imx6q-phytec-mira-rdk-nand.dts) enables the SPI NOR flash
> by including &m25p80 { status = "okay"; };. While &can1, &pcie, and the
> unrestricted &ethphy are enabled, the &m25p80 node is missing here.
> 
> Does this leave the board missing its SPI flash feature and partially
> unsynchronized compared to the other FF variants?

I re-checked and this patch is actually wrong.

There was never i.MX6DL som with NAND + FF set board.

I will drop this patch in v2.

BR,
Primoz

> 
>>  &uart3 {
>>  	status = "okay";
>>  };
> 

-- 
Primoz Fiser
phone: +386-41-390-545
email: primoz.fiser@norik.com
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: info@norik.com


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-30 13:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-30 10:34 [PATCH 0/2] ARM: dts: imx6: phytec-mira: phyBOARD-Mira fixes Primoz Fiser
2026-09-30 10:34 ` [PATCH 1/2] ARM: dts: imx6dl-phytec-mira-nand: Enable all peripherals Primoz Fiser
2026-09-30 10:40   ` sashiko-bot
2026-09-30 13:51     ` Primoz Fiser
2026-09-30 10:34 ` [PATCH 2/2] ARM: dts: imx6qdl-phytec-mira: Add touchscreen-inverted properties Primoz Fiser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.