Re: [PATCH v5 3/9] block: introduce storage element management

[Christoph Hellwig <hch@lst.de>]

On Mon, Oct 12, 2026 at 10:01:15PM +0900, Damien Le Moal wrote:
> +static int disk_check_remove_error(struct gendisk *disk,
> +				   struct blk_se *elements,
> +				   unsigned int element_id)
> +{
> +	unsigned int i;
> +
> +	for (i = 0; i < disk->nr_storage_elements; i++) {
> +		if (elements[i].id == element_id
> +		    && elements[i].status == BLK_SE_STS_REMOVE_ERROR)

kernel style places the && on the previous line.

> +	noio_flag = memalloc_noio_save();
> +	elements = kzalloc_objs(struct blk_se, disk->nr_storage_elements);
> +	memalloc_noio_restore(noio_flag);

This is a bit odd, we can still use GFP_NOIO for now, but if we
want to use the scope API, I'd expect it to be used higher level and
not over a single call.  Of course not a bug, but somewhat strange
looking code.

The rest looks good.  I think the Sashiko comment is a bit confused,
as the code explicitly just flushes with a freeze/unfreeze, so
extending the scope is a strange suggestion.