From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v5 4/9] block: add storage element management ioctls
Date: Mon, 12 Oct 2026 16:57:40 +0200 [thread overview]
Message-ID: <20261012145740.GB11255@lst.de> (raw)
In-Reply-To: <46272028-d50a-40fa-806b-186f1f9575c2@kernel.org>
On Mon, Oct 12, 2026 at 04:56:18PM +0200, Damien Le Moal wrote:
> >
> > Sashiko is obviously confused here about partitions that aren't supported
> > on zoned devices. The conventional zones argument isn't entirely
> > stupid, but also not a great one. Maybe we should add a check to just
> > reject the ioctls if conventional zones are present, as that would make
> > a mess of the depop anyway?
>
> Not sure sure it makes sense. 3 things can happen:
> 1) The conv zone goes offline on remove
> 2) The conv zone goes read-only on remove
> 3) The conv zone content is totally unknown on restore since that is a
> destructive op.
>
> So the "data loss" comment makes sense only in the case (2). All other cases
> lose the data anyway. As we make it clear that the user is responsible for sync
> & no io before issuing a remove ioctl, I am not sure if we really need to do
> anything special here. And we cannot really do anything special since we do not
> know which zones are going to be affected. So either we do nothing and let the
> user deal with potentially cached data not physically accessible anymore (not
> great), or like here invalidate everything.
Maybe add a comment?
next prev parent reply other threads:[~2026-10-12 14:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 13:01 [PATCH v5 0/9] Add support for storage element depopulation Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 1/9] block: introduce disk_zone_is_offline() Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 2/9] block: refactor blk_revalidate_disk_zones() Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 3/9] block: introduce storage element management Damien Le Moal
2026-10-12 13:23 ` sashiko-bot
2026-10-12 13:27 ` Damien Le Moal
2026-10-12 14:23 ` Christoph Hellwig
2026-10-12 13:01 ` [PATCH v5 4/9] block: add storage element management ioctls Damien Le Moal
2026-10-12 13:40 ` sashiko-bot
2026-10-12 13:49 ` Damien Le Moal
2026-10-12 14:31 ` Christoph Hellwig
2026-10-12 14:56 ` Damien Le Moal
2026-10-12 14:57 ` Christoph Hellwig [this message]
2026-10-12 14:59 ` Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 5/9] zloop: add storage element emulation Damien Le Moal
2026-10-12 13:52 ` sashiko-bot
2026-10-12 13:01 ` [PATCH v5 6/9] zloop: add degrade_element control command Damien Le Moal
2026-10-12 14:02 ` sashiko-bot
2026-10-12 14:43 ` Christoph Hellwig
2026-10-12 13:01 ` [PATCH v5 7/9] scsi: sd: fail read commands to offline zones early Damien Le Moal
2026-10-12 14:36 ` Christoph Hellwig
2026-10-12 13:01 ` [PATCH v5 8/9] scsi: sd_zbc: always revalidate zones for disks supporting head depopulation Damien Le Moal
2026-10-12 14:19 ` sashiko-bot
2026-10-12 14:37 ` Christoph Hellwig
2026-10-12 14:57 ` Damien Le Moal
2026-10-12 13:01 ` [PATCH v5 9/9] scsi: sd_zbc: define storage element management operations Damien Le Moal
2026-10-12 14:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261012145740.GB11255@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.