Re: [PATCH v5 6/9] zloop: add degrade_element control command

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] block: documentation format string mismatch for element_id in zloop_ctl_show()
--

commit 09c168795398e63847062539d79768bb5214f9cb
Author: Damien Le Moal <dlemoal@kernel.org>

zloop: add degrade_element control command

This commit introduces a new degrade_element control command to allow users
to mark storage elements of a zloop device as degraded. The user specifies the
element ID to be degraded via the element_id option. Operations to zones
served by degraded elements will then be failed.

> diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c
> index 11481577b9cb2..26d8335508a16 100644
> --- a/drivers/block/zloop.c
> +++ b/drivers/block/zloop.c

[ ... ]

> @@ -2303,6 +2384,10 @@ static int zloop_ctl_show(struct seq_file *seq_file, void *private)
>  	seq_puts(seq_file, zloop_ctl_ops[1].name);
>  	seq_puts(seq_file, " id=%d\n");
>  
> +	/* Degrade element operation */
> +	seq_puts(seq_file, zloop_ctl_ops[2].name);
> +	seq_puts(seq_file, " id=%d,element_id=%d\n");

[Severity: Low]
Does this documentation output accurately reflect the expected format?

The option parser for zloop uses match_uint() for ZLOOP_OPT_ELEMENT_ID:

drivers/block/zloop.c:zloop_parse_options() {
    ...
		case ZLOOP_OPT_ELEMENT_ID:
			if (match_uint(args, &token)) {
				ret = -EINVAL;
				goto out;
			}
			opts->element_id = token;
			break;
    ...
}

If a user follows the %d documentation from zloop_ctl_show() and provides a
signed negative integer, the parser will reject it. Should the output string
in zloop_ctl_show() use %u instead to match the parser's requirement and avoid
misleading users?

> +
>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012130121.1902634-1-dlemoal@kernel.org?part=6