From: Tom Rini <trini@konsulko.com>
To: Ana Bobillo <anabobillo3@gmail.com>
Cc: u-boot@lists.u-boot-project.org,
"Anatolij Gustschin" <ag.dev.uboot@gmail.com>,
"Simon Glass" <sjg@chromium.org>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Quentin Schulz" <u-boot@0leil.net>,
"Andre Przywara" <andre.przywara@arm.com>,
"Thierry Reding" <treding@nvidia.com>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Tom Warren" <twarren@nvidia.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
uboot-stm32@st-md-mailman.stormreply.com,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Jonas Schwöbel" <jonasschwoebel@yahoo.de>
Subject: Re: [PATCH 06/11] video: sunxi: de2: Tell the display the frame buffer size
Date: Mon, 9 Nov 2026 12:21:08 -0600 [thread overview]
Message-ID: <20261109182108.GS3741582@bill-the-cat> (raw)
In-Reply-To: <5e2ceb08-8dbd-48e7-acf6-ec30f5ccef0c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On Mon, Nov 09, 2026 at 05:29:35PM +0000, Ana Bobillo wrote:
> From: Ana Bobillo <anabobillo3@gmail.com>
>
> The DE2 driver reserves a frame buffer for LCD_MAX_WIDTH x
> LCD_MAX_HEIGHT at 32bpp, but takes whatever mode the HDMI encoder reads
> from the display's EDID, while sunxi_dw_hdmi_mode_valid() only checks
> the pixel clock. A display announcing a larger mode makes the frame
> buffer run past the reserved memory.
>
> Pass the reserved size and depth to the display before reading the
> timing, so that only modes which fit are used.
>
> Fixes: 56009451d843 ("sunxi: video: Add A64/H3/H5 HDMI driver")
> Signed-off-by: Ana Bobillo <anabobillo3@gmail.com>
Here and elsewhere, fixes isn't appropriate for populating newly added
fields.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-11-09 18:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 17:28 [PATCH 00/11] video: Keep EDID modes and DP lane counts within what is reserved Ana Bobillo
2026-11-09 17:28 ` [PATCH 01/11] configs: stm32mp23/stm32mp25: Size the frame buffer for the LVDS panel Ana Bobillo
2026-11-12 8:46 ` Patrice CHOTARD
2026-11-09 17:29 ` [PATCH 02/11] video: Check that the mode fits in the reserved frame buffer Ana Bobillo
2026-11-09 17:29 ` [PATCH 03/11] edid: Leave the timing alone when no mode is valid Ana Bobillo
2026-11-09 18:16 ` Tom Rini
2026-11-09 19:28 ` Ana Bobillo
2026-11-09 17:29 ` [PATCH 04/11] video: display: Skip modes which do not fit in the source frame buffer Ana Bobillo
2026-11-10 8:41 ` Svyatoslav Ryhel
2026-11-09 17:29 ` [PATCH 05/11] video: rockchip: vop: Tell the display the frame buffer size Ana Bobillo
2026-11-09 18:30 ` Tom Rini
2026-11-09 19:28 ` Ana Bobillo
2026-11-09 17:29 ` [PATCH 06/11] video: sunxi: de2: " Ana Bobillo
2026-11-09 18:21 ` Tom Rini [this message]
2026-11-09 19:28 ` Ana Bobillo
2026-11-09 19:44 ` Tom Rini
2026-11-09 17:29 ` [PATCH 07/11] video: tegra124: " Ana Bobillo
2026-11-09 17:29 ` [PATCH 08/11] sunxi: display: Skip EDID modes larger than the frame buffer Ana Bobillo
2026-11-09 17:29 ` [PATCH 09/11] video: tegra: hdmi: Skip modes larger than the DC " Ana Bobillo
2026-11-10 8:46 ` Svyatoslav Ryhel
2026-11-09 17:30 ` [PATCH 10/11] video: rockchip: edp: Limit the lane count to four Ana Bobillo
2026-11-09 17:30 ` [PATCH 11/11] video: tegra124: dp: " Ana Bobillo
2026-11-10 8:51 ` Svyatoslav Ryhel
2026-11-10 18:01 ` [PATCH 00/11] video: Keep EDID modes and DP lane counts within what is reserved Tom Rini
2026-11-10 18:16 ` Ana Bobillo
2026-11-10 18:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109182108.GS3741582@bill-the-cat \
--to=trini@konsulko.com \
--cc=ag.dev.uboot@gmail.com \
--cc=anabobillo3@gmail.com \
--cc=andre.przywara@arm.com \
--cc=clamor95@gmail.com \
--cc=jonasschwoebel@yahoo.de \
--cc=kever.yang@rock-chips.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=sjg@chromium.org \
--cc=treding@nvidia.com \
--cc=twarren@nvidia.com \
--cc=u-boot@0leil.net \
--cc=u-boot@lists.u-boot-project.org \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.