From: Ana Bobillo <anabobillo3@gmail.com>
To: u-boot@lists.u-boot-project.org
Cc: "Tom Rini" <trini@konsulko.com>,
"Anatolij Gustschin" <ag.dev.uboot@gmail.com>,
"Simon Glass" <sjg@chromium.org>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Quentin Schulz" <u-boot@0leil.net>,
"Andre Przywara" <andre.przywara@arm.com>,
"Thierry Reding" <treding@nvidia.com>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Tom Warren" <twarren@nvidia.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
"Patrice Chotard" <patrice.chotard@foss.st.com>,
uboot-stm32@st-md-mailman.stormreply.com,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Jonas Schwöbel" <jonasschwoebel@yahoo.de>
Subject: [PATCH 05/11] video: rockchip: vop: Tell the display the frame buffer size
Date: Mon, 09 Nov 2026 17:29:27 +0000 [thread overview]
Message-ID: <fd719611-e1cd-40dc-b99a-213e066f3c7f@gmail.com> (raw)
In-Reply-To: <2399d63c-ddd0-44b0-bb81-d5d9d2a8a8b4@gmail.com>
From: Ana Bobillo <anabobillo3@gmail.com>
The VOP reserves a frame buffer for CONFIG_VIDEO_ROCKCHIP_MAX_XRES x
CONFIG_VIDEO_ROCKCHIP_MAX_YRES at 32bpp, but takes whatever mode the
eDP, HDMI or MIPI encoder reads from the display. A display announcing
a larger mode makes the frame buffer run past the reserved memory.
Work out the depth before reading the timing and pass it, with the
reserved size, to the display, so that only modes which fit are used.
Fixes: 7b7ad5c31c91 ("rockchip: video: Add a video-output driver")
Signed-off-by: Ana Bobillo <anabobillo3@gmail.com>
---
drivers/video/rockchip/rk_vop.c | 35 ++++++++++++++++++---------------
1 file changed, 19 insertions(+), 16 deletions(-)
diff --git a/drivers/video/rockchip/rk_vop.c b/drivers/video/rockchip/rk_vop.c
index 17dfe62c9da..ff7f7a7fa79 100644
--- a/drivers/video/rockchip/rk_vop.c
+++ b/drivers/video/rockchip/rk_vop.c
@@ -245,6 +245,7 @@ static void rkvop_mode_set(struct udevice *dev,
*/
static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
{
+ struct video_uc_plat *plat = dev_get_uclass_plat(dev);
struct video_priv *uc_priv = dev_get_uclass_priv(dev);
int vop_id, remote_vop_id;
struct display_timing timing;
@@ -326,6 +327,22 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
}
debug("vop_id=%d\n", vop_id);
+ /* Set bitwidth for vop display according to vop mode */
+ switch (vop_id) {
+ case VOP_MODE_EDP:
+#if defined(CONFIG_ROCKCHIP_RK3288)
+ case VOP_MODE_LVDS:
+#endif
+ l2bpp = VIDEO_BPP16;
+ break;
+ case VOP_MODE_HDMI:
+ case VOP_MODE_MIPI:
+ l2bpp = VIDEO_BPP32;
+ break;
+ default:
+ l2bpp = VIDEO_BPP16;
+ }
+
disp_uc_plat = dev_get_uclass_plat(disp);
debug("Found device '%s', disp_uc_priv=%p\n", disp->name, disp_uc_plat);
if (display_in_use(disp)) {
@@ -335,6 +352,8 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
disp_uc_plat->source_id = remote_vop_id;
disp_uc_plat->src_dev = dev;
+ disp_uc_plat->fb_size = plat->size;
+ disp_uc_plat->fb_bpp = 1 << l2bpp;
ret = device_probe(disp);
if (ret) {
@@ -357,22 +376,6 @@ static int rk_display_init(struct udevice *dev, ulong fbbase, ofnode ep_node)
return ret;
}
- /* Set bitwidth for vop display according to vop mode */
- switch (vop_id) {
- case VOP_MODE_EDP:
-#if defined(CONFIG_ROCKCHIP_RK3288)
- case VOP_MODE_LVDS:
-#endif
- l2bpp = VIDEO_BPP16;
- break;
- case VOP_MODE_HDMI:
- case VOP_MODE_MIPI:
- l2bpp = VIDEO_BPP32;
- break;
- default:
- l2bpp = VIDEO_BPP16;
- }
-
rkvop_mode_set(dev, &timing, vop_id);
ret = reset_get_by_name(dev, "dclk", &dclk_rst);
next prev parent reply other threads:[~2026-11-09 17:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 17:28 [PATCH 00/11] video: Keep EDID modes and DP lane counts within what is reserved Ana Bobillo
2026-11-09 17:28 ` [PATCH 01/11] configs: stm32mp23/stm32mp25: Size the frame buffer for the LVDS panel Ana Bobillo
2026-11-12 8:46 ` Patrice CHOTARD
2026-11-09 17:29 ` [PATCH 02/11] video: Check that the mode fits in the reserved frame buffer Ana Bobillo
2026-11-09 17:29 ` [PATCH 03/11] edid: Leave the timing alone when no mode is valid Ana Bobillo
2026-11-09 18:16 ` Tom Rini
2026-11-09 19:28 ` Ana Bobillo
2026-11-09 17:29 ` [PATCH 04/11] video: display: Skip modes which do not fit in the source frame buffer Ana Bobillo
2026-11-10 8:41 ` Svyatoslav Ryhel
2026-11-09 17:29 ` Ana Bobillo [this message]
2026-11-09 18:30 ` [PATCH 05/11] video: rockchip: vop: Tell the display the frame buffer size Tom Rini
2026-11-09 19:28 ` Ana Bobillo
2026-11-09 17:29 ` [PATCH 06/11] video: sunxi: de2: " Ana Bobillo
2026-11-09 18:21 ` Tom Rini
2026-11-09 19:28 ` Ana Bobillo
2026-11-09 19:44 ` Tom Rini
2026-11-09 17:29 ` [PATCH 07/11] video: tegra124: " Ana Bobillo
2026-11-09 17:29 ` [PATCH 08/11] sunxi: display: Skip EDID modes larger than the frame buffer Ana Bobillo
2026-11-09 17:29 ` [PATCH 09/11] video: tegra: hdmi: Skip modes larger than the DC " Ana Bobillo
2026-11-10 8:46 ` Svyatoslav Ryhel
2026-11-09 17:30 ` [PATCH 10/11] video: rockchip: edp: Limit the lane count to four Ana Bobillo
2026-11-09 17:30 ` [PATCH 11/11] video: tegra124: dp: " Ana Bobillo
2026-11-10 8:51 ` Svyatoslav Ryhel
2026-11-10 18:01 ` [PATCH 00/11] video: Keep EDID modes and DP lane counts within what is reserved Tom Rini
2026-11-10 18:16 ` Ana Bobillo
2026-11-10 18:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd719611-e1cd-40dc-b99a-213e066f3c7f@gmail.com \
--to=anabobillo3@gmail.com \
--cc=ag.dev.uboot@gmail.com \
--cc=andre.przywara@arm.com \
--cc=clamor95@gmail.com \
--cc=jonasschwoebel@yahoo.de \
--cc=kever.yang@rock-chips.com \
--cc=neil.armstrong@linaro.org \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=sjg@chromium.org \
--cc=treding@nvidia.com \
--cc=trini@konsulko.com \
--cc=twarren@nvidia.com \
--cc=u-boot@0leil.net \
--cc=u-boot@lists.u-boot-project.org \
--cc=uboot-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.