From: "Günther Noack" <gnoack3000@gmail.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Alejandro Colomar <alx+linux-man@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
linux-man@vger.kernel.org,
Alexander Mikhalitsyn <alexander@mihalicyn.com>,
Eric Dumazet <edumazet@kernel.org>
Subject: Re: [PATCH v2 6/8] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD
Date: Fri, 20 Nov 2026 16:59:26 +0100 [thread overview]
Message-ID: <20261120.a284167287ae@gnoack.org> (raw)
In-Reply-To: <20261118-schnorren-apotheke-markant-b8178cac4a9b@brauner>
On Wed, Nov 18, 2026 at 05:24:53PM +0100, Christian Brauner wrote:
> On Tue, Nov 03, 2026 at 09:22:08PM +0100, Günther Noack wrote:
> > These were added in linux.git 5e2ff6704a27 (2023-06-12; "scm: add
> > SO_PASSPIDFD and SCM_PIDFD") and 7b26952a91cf (2023-06-12; "net: core:
> > add getsockopt SO_PEERPIDFD"), both in Linux 6.5.
>
> Looks good.
>
> Since 7.4 there's also SO_PASSPIDFD_THREAD, SO_PEERPIDFD_THREAD and
> SCM_PIDFD_THREAD which hand out a thread pidfd (PIDFD_THREAD) instead
> of one for the thread-group leader. Would be nice to document those as
> well. Either here or in a follow-up.
>
> Nit: if there's no sender pid no SCM_PIDFD message is generated at all.
>
> Acked-by: Christian Brauner (Amutable) <brauner@kernel.org>
Thanks for the review!
Regarding the *_THREAD variants, they are intentionally left out here,
because 7.4 is not final yet and so that change can only go later. I
would also like more complete documentation, but ultimately,
documentation needs to be written by the feature authors so that it
can stay up to date.
Regarding the potentially missing SCM_PIDFD message, in my
understanding, the scenarios where this can happen are:
* When the message was sent before SO_PASSPIDFD was enabled.
* When recvmsg() on a stream socket returns 0 (EOF).
Is that correct? I am not sure whether these corner cases are in
scope for this documentation fix, and I am not sure I have the
complete picture here. (Are there missing other cases? Does it also
affect other process-identifying SCM_* rights?)
For now, I'd lean to soften the wording about "in each subsequently
received message" to "in subsequently received messages".
Thanks,
–Günther
next prev parent reply other threads:[~2026-11-20 15:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 20:22 [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes Günther Noack
2026-11-03 20:22 ` [PATCH v2 1/8] man/man7/unix.7: ERRORS: ETOOMANYREFS: Fix the conditions Günther Noack
2026-11-06 13:00 ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 2/8] man/man7/unix.7: Multiple same-typed SCM_* messages may be sent in one message Günther Noack
2026-11-16 0:52 ` Kuniyuki Iwashima
2026-11-18 0:59 ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 3/8] man/man7/unix.7: Autobind: Clarify when it happens, and mention SO_PASSPIDFD Günther Noack
2026-11-16 0:53 ` Kuniyuki Iwashima
2026-11-18 1:06 ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 4/8] man/man7/unix.7: SCM_SECURITY: Generalize to other LSMs, not just SELinux Günther Noack
2026-11-16 0:55 ` Kuniyuki Iwashima
2026-11-16 7:35 ` Günther Noack
2026-11-18 1:15 ` Alejandro Colomar
2026-11-18 1:13 ` Alejandro Colomar
2026-11-20 14:17 ` Günther Noack
2026-11-20 14:41 ` Alejandro Colomar
2026-11-20 14:42 ` Alejandro Colomar
2026-11-03 20:22 ` [PATCH v2 5/8] man/man7/unix.7: SO_PASSSEC: wfix Günther Noack
2026-11-03 20:22 ` [PATCH v2 6/8] man/man7/unix.7: Document SO_PASSPIDFD, SO_PEERPIDFD, and SCM_PIDFD Günther Noack
2026-11-16 1:03 ` Kuniyuki Iwashima
2026-11-18 16:24 ` Christian Brauner
2026-11-20 15:59 ` Günther Noack [this message]
2026-11-03 20:22 ` [PATCH v2 7/8] man/man7/unix.7: Document SO_PASSRIGHTS Günther Noack
2026-11-16 1:02 ` Kuniyuki Iwashima
2026-11-03 20:22 ` [PATCH v2 8/8] man/man7/unix.7: Remove mentions of "namespace" in the general sense Günther Noack
2026-11-16 0:59 ` Kuniyuki Iwashima
2026-11-19 23:37 ` [PATCH v2 0/8] unix.7: Socket Options and SCM_* fixes Alejandro Colomar
2026-11-20 16:02 ` Günther Noack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120.a284167287ae@gnoack.org \
--to=gnoack3000@gmail.com \
--cc=alexander@mihalicyn.com \
--cc=alx+linux-man@kernel.org \
--cc=brauner@kernel.org \
--cc=edumazet@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.