All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-18 16:22 [PATCH] driver core: Disable driver overriding by default Danilo Krummrich
@ 2026-11-19  5:15 ` Alex Williamson
  2026-11-19  5:22   ` sashiko-bot
                     ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Alex Williamson @ 2026-11-19  5:15 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Alex Williamson, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
	Randy Dunlap, Rafael J . Wysocki, Danilo Krummrich, Johan Hovold,
	Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	David Lechner, Armin Wolf, Thierry Reding, Mike Rapoport,
	Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton, Petr Mladek,
	Pnina Feder, Mete Durlu, Aaron Tomlin, Rio, Feng Tang, linux-doc,
	linux-kernel, driver-core, linux-trace-kernel, Mark Brown,
	Bjorn Helgaas, Tony Krowiak, Jason Herne, Eric Farman,
	Matthew Rosato, Halil Pasic, linux-s390

The vfio_ap and vfio_ccw drivers bind devices through driver_override.
With the introduction of the support_driver_override flag in the core
driver struct, it's now required for drivers to declare themselves as
driver_override compatible, otherwise driver_override bindings will be
denied or generate a kernel taint.

Set the support_driver_override flag on the vfio_ap and vfio_ccw driver
structs.

Cc: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Jason Herne <jjherne@linux.ibm.com>
Cc: Eric Farman <farman@linux.ibm.com>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Alex Williamson <alex@shazbot.org>
---

Uwe, this should complete the vfio drivers needing driver override,
covering the s390 specific drivers.  Thanks,

Alex

 drivers/s390/cio/vfio_ccw_drv.c   | 1 +
 drivers/s390/crypto/vfio_ap_drv.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
index 7546bd137e4e..77765cde87f7 100644
--- a/drivers/s390/cio/vfio_ccw_drv.c
+++ b/drivers/s390/cio/vfio_ccw_drv.c
@@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
 	.drv = {
 		.name = "vfio_ccw",
 		.owner = THIS_MODULE,
+		.support_driver_override = true,
 	},
 	.subchannel_type = vfio_ccw_sch_ids,
 	.irq = vfio_ccw_sch_irq,
diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 8e69ed286bb9..2d47dc643269 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
 	.on_config_changed = vfio_ap_on_cfg_changed,
 	.on_scan_complete = vfio_ap_on_scan_complete,
 	.ids = ap_queue_ids,
+	.driver.support_driver_override = true,
 };
 
 static void vfio_ap_matrix_dev_release(struct device *dev)
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
@ 2026-11-19  5:22   ` sashiko-bot
  2026-11-19 12:14   ` Anthony Krowiak
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: sashiko-bot @ 2026-11-19  5:22 UTC (permalink / raw)
  To: Alex Williamson
  Cc: linux-trace-kernel, linux-s390, Heiko Carstens, Vasily Gorbik,
	Alexander Gordeev, Christian Borntraeger

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] s390/vfio: unknown field support_driver_override in struct
  device_driver
--

commit a91edca560e83afe4c0101413f2c0a4218259662
Author: Alex Williamson <alex@shazbot.org>

s390/vfio: Allow untainted use of driver_override

This commit sets the support_driver_override flag on the vfio_ccw_sch_driver
and vfio_ap_drv driver structs.

> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 7546bd137e4e1..77765cde87f78 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
>  	.drv = {
>  		.name = "vfio_ccw",
>  		.owner = THIS_MODULE,
> +		.support_driver_override = true,
>  	},
>  	.subchannel_type = vfio_ccw_sch_ids,
>  	.irq = vfio_ccw_sch_irq,
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 8e69ed286bb9c..2d47dc6432698 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
>  	.on_config_changed = vfio_ap_on_cfg_changed,
>  	.on_scan_complete = vfio_ap_on_scan_complete,
>  	.ids = ap_queue_ids,
> +	.driver.support_driver_override = true,
>  };

[Severity: High]
Does struct device_driver have a support_driver_override member in this
tree?  Without the driver-core prerequisite adding that field to struct
device_driver in include/linux/device/driver.h, building vfio_ccw_drv.c or
vfio_ap_drv.c fails with an unknown field error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119051507.3306075-1-alex@shazbot.org?part=1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
  2026-11-19  5:22   ` sashiko-bot
@ 2026-11-19 12:14   ` Anthony Krowiak
  2026-11-19 18:03     ` Uwe Kleine-König
  2026-11-19 22:55   ` kernel test robot
                     ` (2 subsequent siblings)
  4 siblings, 1 reply; 8+ messages in thread
From: Anthony Krowiak @ 2026-11-19 12:14 UTC (permalink / raw)
  To: Alex Williamson, Uwe Kleine-König
  Cc: Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan, Randy Dunlap,
	Rafael J . Wysocki, Danilo Krummrich, Johan Hovold,
	Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	David Lechner, Armin Wolf, Thierry Reding, Mike Rapoport,
	Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton, Petr Mladek,
	Pnina Feder, Mete Durlu, Aaron Tomlin, Rio, Feng Tang, linux-doc,
	linux-kernel, driver-core, linux-trace-kernel, Mark Brown,
	Bjorn Helgaas, Jason Herne, Eric Farman, Matthew Rosato,
	Halil Pasic, linux-s390



On 11/19/26 12:15 AM, Alex Williamson wrote:
> The vfio_ap and vfio_ccw drivers bind devices through driver_override.
> With the introduction of the support_driver_override flag in the core
> driver struct, it's now required for drivers to declare themselves as
> driver_override compatible, otherwise driver_override bindings will be
> denied or generate a kernel taint.
> 
> Set the support_driver_override flag on the vfio_ap and vfio_ccw driver
> structs.
> 
> Cc: Tony Krowiak <akrowiak@linux.ibm.com>
> Cc: Jason Herne <jjherne@linux.ibm.com>
> Cc: Eric Farman <farman@linux.ibm.com>
> Cc: Matthew Rosato <mjrosato@linux.ibm.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Alex Williamson <alex@shazbot.org>
> ---
> 
> Uwe, this should complete the vfio drivers needing driver override,
> covering the s390 specific drivers.  Thanks,
> 
> Alex
> 
>   drivers/s390/cio/vfio_ccw_drv.c   | 1 +
>   drivers/s390/crypto/vfio_ap_drv.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/s390/cio/vfio_ccw_drv.c b/drivers/s390/cio/vfio_ccw_drv.c
> index 7546bd137e4e..77765cde87f7 100644
> --- a/drivers/s390/cio/vfio_ccw_drv.c
> +++ b/drivers/s390/cio/vfio_ccw_drv.c
> @@ -375,6 +375,7 @@ static struct css_driver vfio_ccw_sch_driver = {
>   	.drv = {
>   		.name = "vfio_ccw",
>   		.owner = THIS_MODULE,
> +		.support_driver_override = true,
>   	},
>   	.subchannel_type = vfio_ccw_sch_ids,
>   	.irq = vfio_ccw_sch_irq,
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 8e69ed286bb9..2d47dc643269 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
>   	.on_config_changed = vfio_ap_on_cfg_changed,
>   	.on_scan_complete = vfio_ap_on_scan_complete,
>   	.ids = ap_queue_ids,
> +	.driver.support_driver_override = true,

Does this really belong here? Shouldn't it be in struct ap_driver
since driver_override is supported in the AP bus?

>   };
>   
>   static void vfio_ap_matrix_dev_release(struct device *dev)


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19 12:14   ` Anthony Krowiak
@ 2026-11-19 18:03     ` Uwe Kleine-König
  0 siblings, 0 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2026-11-19 18:03 UTC (permalink / raw)
  To: Anthony Krowiak
  Cc: Alex Williamson, Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan,
	Randy Dunlap, Rafael J . Wysocki, Danilo Krummrich, Johan Hovold,
	Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers,
	David Lechner, Armin Wolf, Thierry Reding, Mike Rapoport,
	Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton, Petr Mladek,
	Pnina Feder, Mete Durlu, Aaron Tomlin, Rio, Feng Tang, linux-doc,
	linux-kernel, driver-core, linux-trace-kernel, Mark Brown,
	Bjorn Helgaas, Jason Herne, Eric Farman, Matthew Rosato,
	Halil Pasic, linux-s390

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

Hello,

On Thu, Nov 19, 2026 at 07:14:47AM -0500, Anthony Krowiak wrote:
> On 11/19/26 12:15 AM, Alex Williamson wrote:
> > diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> > index 8e69ed286bb9..2d47dc643269 100644
> > --- a/drivers/s390/crypto/vfio_ap_drv.c
> > +++ b/drivers/s390/crypto/vfio_ap_drv.c
> > @@ -62,6 +62,7 @@ static struct ap_driver vfio_ap_drv = {
> >   	.on_config_changed = vfio_ap_on_cfg_changed,
> >   	.on_scan_complete = vfio_ap_on_scan_complete,
> >   	.ids = ap_queue_ids,
> > +	.driver.support_driver_override = true,
> 
> Does this really belong here? Shouldn't it be in struct ap_driver
> since driver_override is supported in the AP bus?

ap_device_probe() calls device_match_driver_override with
drv=&ap_drv->driver. So I think the assignment is fine.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
  2026-11-19  5:22   ` sashiko-bot
  2026-11-19 12:14   ` Anthony Krowiak
@ 2026-11-19 22:55   ` kernel test robot
  2026-11-19 23:16   ` kernel test robot
  2026-11-20  2:12   ` kernel test robot
  4 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2026-11-19 22:55 UTC (permalink / raw)
  To: Alex Williamson, Uwe Kleine-König
  Cc: oe-kbuild-all, Alex Williamson, Greg Kroah-Hartman,
	Jonathan Corbet, Shuah Khan, Randy Dunlap, Rafael J . Wysocki,
	Danilo Krummrich, Johan Hovold, Steven Rostedt, Masami Hiramatsu,
	Mathieu Desnoyers, David Lechner, Armin Wolf, Thierry Reding,
	Mike Rapoport, Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton,
	Linux Memory Management List, Petr Mladek, Pnina Feder,
	Mete Durlu

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on kvms390/next]
[also build test ERROR on awilliam-vfio/next soc/for-next awilliam-vfio/for-linus linus/master v7.4-rc3 next-20261116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/s390-vfio-Allow-untainted-use-of-driver_override/20261118-221504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
patch link:    https://lore.kernel.org/r/20261119051507.3306075-1-alex%40shazbot.org
patch subject: [PATCH] s390/vfio: Allow untainted use of driver_override
config: s390-randconfig-1001-20261119 (https://download.01.org/0day-ci/archive/20261120/202611200633.VVreDSbc-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261120/202611200633.VVreDSbc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611200633.VVreDSbc-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/s390/cio/vfio_ccw_drv.c:378:18: error: 'struct device_driver' has no member named 'support_driver_override'
     378 |                 .support_driver_override = true,
         |                  ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/s390/cio/vfio_ccw_drv.c:378:44: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     378 |                 .support_driver_override = true,
         |                                            ^~~~
   drivers/s390/cio/vfio_ccw_drv.c:378:44: note: (near initialization for 'vfio_ccw_sch_driver.drv.mod_name')


vim +378 drivers/s390/cio/vfio_ccw_drv.c

   373	
   374	static struct css_driver vfio_ccw_sch_driver = {
   375		.drv = {
   376			.name = "vfio_ccw",
   377			.owner = THIS_MODULE,
 > 378			.support_driver_override = true,
   379		},
   380		.subchannel_type = vfio_ccw_sch_ids,
   381		.irq = vfio_ccw_sch_irq,
   382		.probe = vfio_ccw_sch_probe,
   383		.remove = vfio_ccw_sch_remove,
   384		.shutdown = vfio_ccw_sch_shutdown,
   385		.sch_event = vfio_ccw_sch_event,
   386		.chp_event = vfio_ccw_chp_event,
   387	};
   388	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
                     ` (2 preceding siblings ...)
  2026-11-19 22:55   ` kernel test robot
@ 2026-11-19 23:16   ` kernel test robot
  2026-11-20  2:12   ` kernel test robot
  4 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2026-11-19 23:16 UTC (permalink / raw)
  To: Alex Williamson, Uwe Kleine-König
  Cc: oe-kbuild-all, Alex Williamson, Greg Kroah-Hartman,
	Jonathan Corbet, Shuah Khan, Randy Dunlap, Rafael J . Wysocki,
	Danilo Krummrich, Johan Hovold, Steven Rostedt, Masami Hiramatsu,
	Mathieu Desnoyers, David Lechner, Armin Wolf, Thierry Reding,
	Mike Rapoport, Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton,
	Linux Memory Management List, Petr Mladek, Pnina Feder,
	Mete Durlu

Hi Alex,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kvms390/next]
[also build test WARNING on awilliam-vfio/next soc/for-next awilliam-vfio/for-linus linus/master v7.4-rc3 next-20261116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/s390-vfio-Allow-untainted-use-of-driver_override/20261118-221504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
patch link:    https://lore.kernel.org/r/20261119051507.3306075-1-alex%40shazbot.org
patch subject: [PATCH] s390/vfio: Allow untainted use of driver_override
config: s390-randconfig-1000-20261119 (https://download.01.org/0day-ci/archive/20261120/202611200615.C2fWqXpC-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261120/202611200615.C2fWqXpC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611200615.C2fWqXpC-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/s390/cio/vfio_ccw_drv.c:378:4: error: 'struct device_driver' has no member named 'support_driver_override'
      .support_driver_override = true,
       ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/s390/cio/vfio_ccw_drv.c:378:30: warning: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      .support_driver_override = true,
                                 ^~~~
   drivers/s390/cio/vfio_ccw_drv.c:378:30: note: (near initialization for 'vfio_ccw_sch_driver.drv.mod_name')


vim +378 drivers/s390/cio/vfio_ccw_drv.c

   373	
   374	static struct css_driver vfio_ccw_sch_driver = {
   375		.drv = {
   376			.name = "vfio_ccw",
   377			.owner = THIS_MODULE,
 > 378			.support_driver_override = true,
   379		},
   380		.subchannel_type = vfio_ccw_sch_ids,
   381		.irq = vfio_ccw_sch_irq,
   382		.probe = vfio_ccw_sch_probe,
   383		.remove = vfio_ccw_sch_remove,
   384		.shutdown = vfio_ccw_sch_shutdown,
   385		.sch_event = vfio_ccw_sch_event,
   386		.chp_event = vfio_ccw_chp_event,
   387	};
   388	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
                     ` (3 preceding siblings ...)
  2026-11-19 23:16   ` kernel test robot
@ 2026-11-20  2:12   ` kernel test robot
  4 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2026-11-20  2:12 UTC (permalink / raw)
  To: Alex Williamson, Uwe Kleine-König
  Cc: llvm, oe-kbuild-all, Alex Williamson, Greg Kroah-Hartman,
	Jonathan Corbet, Shuah Khan, Randy Dunlap, Rafael J . Wysocki,
	Danilo Krummrich, Johan Hovold, Steven Rostedt, Masami Hiramatsu,
	Mathieu Desnoyers, David Lechner, Armin Wolf, Thierry Reding,
	Mike Rapoport, Arnd Bergmann, Karl Mehltretter, Paul E . McKenney,
	Borislav Petkov, Dapeng Mi, Marco Elver, Ethan Nelson-Moore,
	Jeff Layton, Bradley Morgan, Andrew Morton,
	Linux Memory Management List, Petr Mladek, Pnina Feder,
	Mete Durlu

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on kvms390/next]
[also build test ERROR on awilliam-vfio/next soc/for-next awilliam-vfio/for-linus linus/master v7.4-rc3 next-20261116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/s390-vfio-Allow-untainted-use-of-driver_override/20261118-221504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
patch link:    https://lore.kernel.org/r/20261119051507.3306075-1-alex%40shazbot.org
patch subject: [PATCH] s390/vfio: Allow untainted use of driver_override
config: s390-defconfig (https://download.01.org/0day-ci/archive/20261120/202611200956.drD2v0r8-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261120/202611200956.drD2v0r8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611200956.drD2v0r8-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/s390/cio/vfio_ccw_drv.c:378:4: error: field designator 'support_driver_override' does not refer to any field in type 'struct device_driver'
     378 |                 .support_driver_override = true,
         |                 ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.
--
>> drivers/s390/crypto/vfio_ap_drv.c:65:10: error: field designator 'support_driver_override' does not refer to any field in type 'struct device_driver'
      65 |         .driver.support_driver_override = true,
         |         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +378 drivers/s390/cio/vfio_ccw_drv.c

   373	
   374	static struct css_driver vfio_ccw_sch_driver = {
   375		.drv = {
   376			.name = "vfio_ccw",
   377			.owner = THIS_MODULE,
 > 378			.support_driver_override = true,
   379		},
   380		.subchannel_type = vfio_ccw_sch_ids,
   381		.irq = vfio_ccw_sch_irq,
   382		.probe = vfio_ccw_sch_probe,
   383		.remove = vfio_ccw_sch_remove,
   384		.shutdown = vfio_ccw_sch_shutdown,
   385		.sch_event = vfio_ccw_sch_event,
   386		.chp_event = vfio_ccw_chp_event,
   387	};
   388	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
@ 2026-11-21  7:34 kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2026-11-21  7:34 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "too many reports for this commit"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20261119051507.3306075-1-alex@shazbot.org>
References: <20261119051507.3306075-1-alex@shazbot.org>
TO: Alex Williamson <alex@shazbot.org>
TO: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
CC: Alex Williamson <alex@shazbot.org>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: Randy Dunlap <rdunlap@infradead.org>
CC: "Rafael J . Wysocki" <rafael@kernel.org>
CC: Danilo Krummrich <dakr@kernel.org>
CC: Johan Hovold <johan@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>
CC: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: David Lechner <dlechner@baylibre.com>
CC: Armin Wolf <W_Armin@gmx.de>
CC: Thierry Reding <thierry.reding@kernel.org>
CC: Mike Rapoport <rppt@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Karl Mehltretter <kmehltretter@gmail.com>
CC: "Paul E . McKenney" <paulmck@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Marco Elver <elver@google.com>
CC: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
CC: Jeff Layton <jlayton@kernel.org>
CC: Bradley Morgan <brads@mainlining.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Petr Mladek <pmladek@suse.com>
CC: Pnina Feder <pnina.feder@mobileye.com>
CC: Mete Durlu <meted@linux.ibm.com>

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on kvms390/next]
[also build test ERROR on awilliam-vfio/next soc/for-next awilliam-vfio/for-linus linus/master v7.4-rc3 next-20261119]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/s390-vfio-Allow-untainted-use-of-driver_override/20261118-221504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
patch link:    https://lore.kernel.org/r/20261119051507.3306075-1-alex%40shazbot.org
patch subject: [PATCH] s390/vfio: Allow untainted use of driver_override
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20261121/202611211550.M3lFLEKu-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261121/202611211550.M3lFLEKu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202611211550.M3lFLEKu-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/s390/crypto/vfio_ap_drv.c:65:17: error: 'struct device_driver' has no member named 'support_driver_override'
      65 |         .driver.support_driver_override = true,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/s390/crypto/vfio_ap_drv.c:65:43: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      65 |         .driver.support_driver_override = true,
         |                                           ^~~~
   drivers/s390/crypto/vfio_ap_drv.c:65:43: note: (near initialization for 'vfio_ap_drv.driver.name')


vim +65 drivers/s390/crypto/vfio_ap_drv.c

1fde573413b549 Tony Krowiak    2018-09-25  57  
31aae32ca1258a Julian Wiedmann 2021-05-14  58  static struct ap_driver vfio_ap_drv = {
260f3ea1413823 Tony Krowiak    2020-10-14  59  	.probe = vfio_ap_mdev_probe_queue,
260f3ea1413823 Tony Krowiak    2020-10-14  60  	.remove = vfio_ap_mdev_remove_queue,
3f85d1df26a9d9 Tony Krowiak    2021-09-30  61  	.in_use = vfio_ap_mdev_resource_in_use,
eeb386aeb5b7c8 Tony Krowiak    2022-04-04  62  	.on_config_changed = vfio_ap_on_cfg_changed,
eeb386aeb5b7c8 Tony Krowiak    2022-04-04  63  	.on_scan_complete = vfio_ap_on_scan_complete,
31aae32ca1258a Julian Wiedmann 2021-05-14  64  	.ids = ap_queue_ids,
66fe1c784ba4f6 Alex Williamson 2026-11-18 @65  	.driver.support_driver_override = true,
31aae32ca1258a Julian Wiedmann 2021-05-14  66  };
31aae32ca1258a Julian Wiedmann 2021-05-14  67  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-11-21  7:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  7:34 [PATCH] s390/vfio: Allow untainted use of driver_override kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-11-18 16:22 [PATCH] driver core: Disable driver overriding by default Danilo Krummrich
2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19  5:22   ` sashiko-bot
2026-11-19 12:14   ` Anthony Krowiak
2026-11-19 18:03     ` Uwe Kleine-König
2026-11-19 22:55   ` kernel test robot
2026-11-19 23:16   ` kernel test robot
2026-11-20  2:12   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.