All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] s390/vfio: Allow untainted use of driver_override
@ 2026-11-21  7:34 kernel test robot
  0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2026-11-21  7:34 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "too many reports for this commit"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20261119051507.3306075-1-alex@shazbot.org>
References: <20261119051507.3306075-1-alex@shazbot.org>
TO: Alex Williamson <alex@shazbot.org>
TO: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
CC: Alex Williamson <alex@shazbot.org>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Jonathan Corbet <corbet@lwn.net>
CC: Shuah Khan <skhan@linuxfoundation.org>
CC: Randy Dunlap <rdunlap@infradead.org>
CC: "Rafael J . Wysocki" <rafael@kernel.org>
CC: Danilo Krummrich <dakr@kernel.org>
CC: Johan Hovold <johan@kernel.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Masami Hiramatsu <mhiramat@kernel.org>
CC: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: David Lechner <dlechner@baylibre.com>
CC: Armin Wolf <W_Armin@gmx.de>
CC: Thierry Reding <thierry.reding@kernel.org>
CC: Mike Rapoport <rppt@kernel.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Karl Mehltretter <kmehltretter@gmail.com>
CC: "Paul E . McKenney" <paulmck@kernel.org>
CC: Borislav Petkov <bp@alien8.de>
CC: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Marco Elver <elver@google.com>
CC: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
CC: Jeff Layton <jlayton@kernel.org>
CC: Bradley Morgan <brads@mainlining.org>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: Petr Mladek <pmladek@suse.com>
CC: Pnina Feder <pnina.feder@mobileye.com>
CC: Mete Durlu <meted@linux.ibm.com>

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on kvms390/next]
[also build test ERROR on awilliam-vfio/next soc/for-next awilliam-vfio/for-linus linus/master v7.4-rc3 next-20261119]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Williamson/s390-vfio-Allow-untainted-use-of-driver_override/20261118-221504
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git next
patch link:    https://lore.kernel.org/r/20261119051507.3306075-1-alex%40shazbot.org
patch subject: [PATCH] s390/vfio: Allow untainted use of driver_override
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20261121/202611211550.M3lFLEKu-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261121/202611211550.M3lFLEKu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202611211550.M3lFLEKu-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/s390/crypto/vfio_ap_drv.c:65:17: error: 'struct device_driver' has no member named 'support_driver_override'
      65 |         .driver.support_driver_override = true,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/s390/crypto/vfio_ap_drv.c:65:43: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
      65 |         .driver.support_driver_override = true,
         |                                           ^~~~
   drivers/s390/crypto/vfio_ap_drv.c:65:43: note: (near initialization for 'vfio_ap_drv.driver.name')


vim +65 drivers/s390/crypto/vfio_ap_drv.c

1fde573413b549 Tony Krowiak    2018-09-25  57  
31aae32ca1258a Julian Wiedmann 2021-05-14  58  static struct ap_driver vfio_ap_drv = {
260f3ea1413823 Tony Krowiak    2020-10-14  59  	.probe = vfio_ap_mdev_probe_queue,
260f3ea1413823 Tony Krowiak    2020-10-14  60  	.remove = vfio_ap_mdev_remove_queue,
3f85d1df26a9d9 Tony Krowiak    2021-09-30  61  	.in_use = vfio_ap_mdev_resource_in_use,
eeb386aeb5b7c8 Tony Krowiak    2022-04-04  62  	.on_config_changed = vfio_ap_on_cfg_changed,
eeb386aeb5b7c8 Tony Krowiak    2022-04-04  63  	.on_scan_complete = vfio_ap_on_scan_complete,
31aae32ca1258a Julian Wiedmann 2021-05-14  64  	.ids = ap_queue_ids,
66fe1c784ba4f6 Alex Williamson 2026-11-18 @65  	.driver.support_driver_override = true,
31aae32ca1258a Julian Wiedmann 2021-05-14  66  };
31aae32ca1258a Julian Wiedmann 2021-05-14  67  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] driver core: Disable driver overriding by default
@ 2026-11-18 16:22 Danilo Krummrich
  2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
  0 siblings, 1 reply; 8+ messages in thread
From: Danilo Krummrich @ 2026-11-18 16:22 UTC (permalink / raw)
  To: Uwe Kleine-König
  Cc: Greg Kroah-Hartman, Jonathan Corbet, Shuah Khan, Randy Dunlap,
	Rafael J. Wysocki, Johan Hovold, Steven Rostedt, Masami Hiramatsu,
	Mathieu Desnoyers, David Lechner, Armin Wolf, Thierry Reding,
	Mike Rapoport (Microsoft), Arnd Bergmann, Karl Mehltretter,
	Paul E. McKenney, Borislav Petkov (AMD), Dapeng Mi, Marco Elver,
	Ethan Nelson-Moore, Jeff Layton, Bradley Morgan, Andrew Morton,
	Petr Mladek, Pnina Feder, Mete Durlu, Aaron Tomlin, Rio,
	Feng Tang, linux-doc, linux-kernel, driver-core,
	linux-trace-kernel, Mark Brown, Bjorn Helgaas, Alex Williamson

On Mon Nov 16, 2026 at 12:08 PM CET, Uwe Kleine-König wrote:
> If this patch is accepted, a number of drivers that are supposed to be
> force-bound need to get their .support_driver_override property set. I'm
> aware of the following:
>
>  - spidev_spi_driver in drivers/spi/spidev.c
>  - stub_driver in drivers/pci/pci-stub.c
>  - uio_dmem_genirq in drivers/uio/uio_dmem_genirq.c
>  - uio_pci_driver in drivers/uio/uio_pci_generic.c
>  - uio_pdrv_genirq in drivers/uio/uio_pdrv_genirq.c
>  - vfio_amba_driver in drivers/vfio/platform/vfio_amba.c
>  - vfio_ccw_sch_driver in drivers/s390/cio/vfio_ccw_drv.c
>  - vfio_pci_driver in drivers/vfio/pci/vfio_pci.c
>  - vfio_platform_driver in drivers/vfio/platform/vfio_platform.c
>
> This is not needed for the userspace i2c driver.
>
> As the flag to set is only introduced in this patch and assuming this
> patch is accepted, I suggest to create an immutable branch for it to
> allow setting the needed flags in driver trees. Alternatively let all
> these go together via a single tree or branch.

Either is fine with me, but it's probably easier to just include the
corresponding patches in this series and merge them all together such that we
avoid having things broken in individual trees.

Can you please add the corresponding patches in a v2?

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-11-21  7:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21  7:34 [PATCH] s390/vfio: Allow untainted use of driver_override kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-11-18 16:22 [PATCH] driver core: Disable driver overriding by default Danilo Krummrich
2026-11-19  5:15 ` [PATCH] s390/vfio: Allow untainted use of driver_override Alex Williamson
2026-11-19  5:22   ` sashiko-bot
2026-11-19 12:14   ` Anthony Krowiak
2026-11-19 18:03     ` Uwe Kleine-König
2026-11-19 22:55   ` kernel test robot
2026-11-19 23:16   ` kernel test robot
2026-11-20  2:12   ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.