[PATCH] drm/rcar-du: Add missing dependency on CMA

[PATCH] drm/rcar-du: Add missing dependency on CMA

[Mark Brown]

From: Mark Brown <broonie@linaro.org>

The driver uses CMA APIs so won't link if CMA is not being built.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/gpu/drm/rcar-du/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index 72887df..e75575a 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -1,6 +1,6 @@
 config DRM_RCAR_DU
 	tristate "DRM Support for R-Car Display Unit"
-	depends on DRM && ARM
+	depends on DRM && ARM && CMA
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
-- 
1.8.3.2

Re: [PATCH] drm/rcar-du: Add missing dependency on CMA

[Laurent Pinchart]

Hi Mark,

Thanks for the patch.

On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> The driver uses CMA APIs so won't link if CMA is not being built.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/gpu/drm/rcar-du/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/Kconfig
> b/drivers/gpu/drm/rcar-du/Kconfig index 72887df..e75575a 100644
> --- a/drivers/gpu/drm/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/rcar-du/Kconfig
> @@ -1,6 +1,6 @@
>  config DRM_RCAR_DU
>  	tristate "DRM Support for R-Car Display Unit"
> -	depends on DRM && ARM
> +	depends on DRM && ARM && CMA
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_CMA_HELPER
>  	select DRM_GEM_CMA_HELPER

Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH] drm/rcar-du: Add missing dependency on CMA

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 500 bytes --]

On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote:
> On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:

> >  config DRM_RCAR_DU
> >  	tristate "DRM Support for R-Car Display Unit"
> > -	depends on DRM && ARM
> > +	depends on DRM && ARM && CMA
> >  	select DRM_KMS_HELPER
> >  	select DRM_KMS_CMA_HELPER
> >  	select DRM_GEM_CMA_HELPER

> Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?

Sadly select doesn't do the right thing with dependencies - it just
ignores them.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/rcar-du: Add missing dependency on CMA

[Laurent Pinchart]

[-- Attachment #1.1: Type: text/plain, Size: 925 bytes --]

On Wednesday 10 July 2013 12:07:24 Mark Brown wrote:
> On Wed, Jul 10, 2013 at 12:54:40PM +0200, Laurent Pinchart wrote:
> > On Wednesday 10 July 2013 11:52:14 Mark Brown wrote:
> > >  config DRM_RCAR_DU
> > >  
> > >  	tristate "DRM Support for R-Car Display Unit"
> > > 
> > > -	depends on DRM && ARM
> > > +	depends on DRM && ARM && CMA
> > > 
> > >  	select DRM_KMS_HELPER
> > >  	select DRM_KMS_CMA_HELPER
> > >  	select DRM_GEM_CMA_HELPER
> > 
> > Shouldn't we instead make DRM_GEM_CMA_HELPER depend on CMA ?
> 
> Sadly select doesn't do the right thing with dependencies - it just ignores
> them.

OK, my bad.

On the other hand, thinking a bit more about this, the DU driver doesn't use 
the CMA API directly, as there's no CMA API exposed to drivers :-) I've 
successfully built the driver with CONFIG_CMA disabled. Could you please share 
the .config that resulted in a link error ?

-- 
Regards,

Laurent Pinchart

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel