From: Federico Vaga <federico.vaga@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Kamil Debski <k.debski@samsung.com>,
Srinivas Kandagatla <srinivas.kandagatla@st.com>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
devel@driverdev.osuosl.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
linux-samsung-soc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Sachin Kamat <sachin.kamat@linaro.org>,
Prabhakar Lad <prabhakar.lad@ti.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sasha Levin <sasha.levin@oracle.com>,
linux-media@vger.kernel.org,
Tomasz Stanislawski <t.stanislaws@samsung.com>,
Pawel Osciak <pawel@osciak.com>,
davinci-linux-open-source@linux.davincidsp.com,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Jeongtae Park <jtp.park@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
linux-arm
Subject: Re: [PATCH v5 1/3] videobuf2-dma-contig: user can specify GFP flags
Date: Thu, 10 Jan 2013 15:32:37 +0100 [thread overview]
Message-ID: <2134637.remWHy6RQA@harkonnen> (raw)
In-Reply-To: <1357822010-30419-2-git-send-email-federico.vaga@gmail.com>
> struct vb2_dc_buf {
> @@ -165,7 +166,8 @@ static void *vb2_dc_alloc(void *alloc_ctx, unsigned long
> size) /* align image size to PAGE_SIZE */
> size = PAGE_ALIGN(size);
>
> - buf->vaddr = dma_alloc_coherent(dev, size, &buf->dma_addr,
GFP_KERNEL);
> + buf->vaddr = dma_alloc_coherent(dev, size, &buf->dma_addr,
> +
GFP_KERNEL | conf->mem_flags);
Unfortunately, I forgot to remove this from Patch v4 series. I did not see it
while re-reading the first time. I'll send a new patch series (v6). It should
be:
buf->vaddr = dma_alloc_coherent(dev, size, &buf->dma_addr, conf->mem_flags);
I'm terribly sorry
--
Federico Vaga
WARNING: multiple messages have this Message-ID (diff)
From: federico.vaga@gmail.com (Federico Vaga)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/3] videobuf2-dma-contig: user can specify GFP flags
Date: Thu, 10 Jan 2013 15:32:37 +0100 [thread overview]
Message-ID: <2134637.remWHy6RQA@harkonnen> (raw)
In-Reply-To: <1357822010-30419-2-git-send-email-federico.vaga@gmail.com>
> struct vb2_dc_buf {
> @@ -165,7 +166,8 @@ static void *vb2_dc_alloc(void *alloc_ctx, unsigned long
> size) /* align image size to PAGE_SIZE */
> size = PAGE_ALIGN(size);
>
> - buf->vaddr = dma_alloc_coherent(dev, size, &buf->dma_addr,
GFP_KERNEL);
> + buf->vaddr = dma_alloc_coherent(dev, size, &buf->dma_addr,
> +
GFP_KERNEL | conf->mem_flags);
Unfortunately, I forgot to remove this from Patch v4 series. I did not see it
while re-reading the first time. I'll send a new patch series (v6). It should
be:
buf->vaddr = dma_alloc_coherent(dev, size, &buf->dma_addr, conf->mem_flags);
I'm terribly sorry
--
Federico Vaga
next prev parent reply other threads:[~2013-01-10 14:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 12:46 [PATCH v5] modify videobuf2-dma-contig and update sta2x11_vip Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 1/3] videobuf2-dma-contig: user can specify GFP flags Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 14:16 ` Laurent Pinchart
2013-01-10 14:32 ` Federico Vaga [this message]
2013-01-10 14:32 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 12:57 ` Federico Vaga
2013-01-10 12:57 ` Federico Vaga
2013-01-10 14:41 ` Hans Verkuil
2013-01-10 14:41 ` Hans Verkuil
2013-01-10 14:58 ` Federico Vaga
2013-01-10 14:58 ` Federico Vaga
2013-01-10 14:01 ` Dan Carpenter
2013-01-10 14:01 ` Dan Carpenter
2013-01-10 14:43 ` Federico Vaga
2013-01-10 14:43 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 3/3] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 15:22 ` [PATCH v5] modify videobuf2-dma-contig and update sta2x11_vip Federico Vaga
2013-01-10 15:22 ` Federico Vaga
2013-01-10 16:06 ` Mauro Carvalho Chehab
2013-01-10 16:06 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2134637.remWHy6RQA@harkonnen \
--to=federico.vaga@gmail.com \
--cc=andrzej.p@samsung.com \
--cc=corbet@lwn.net \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=devel@driverdev.osuosl.org \
--cc=giancarlo.asnaghi@st.com \
--cc=hans.verkuil@cisco.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
--cc=pawel@osciak.com \
--cc=peter.senna@gmail.com \
--cc=prabhakar.lad@ti.com \
--cc=sachin.kamat@linaro.org \
--cc=sasha.levin@oracle.com \
--cc=srinivas.kandagatla@st.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.