From: Dan Carpenter <dan.carpenter@oracle.com>
To: Federico Vaga <federico.vaga@gmail.com>
Cc: Kamil Debski <k.debski@samsung.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Srinivas Kandagatla <srinivas.kandagatla@st.com>,
Sungchun Kang <sungchun.kang@samsung.com>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
devel@driverdev.osuosl.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
linux-samsung-soc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Sachin Kamat <sachin.kamat@linaro.org>,
Prabhakar Lad <prabhakar.lad@ti.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Sasha Levin <sasha.levin@oracle.com>,
linux-media@vger.kernel.org,
Tomasz Stanislawski <t.stanislaws@samsung.com>,
Pawel Osciak <pawel@osciak.com>,
Scott Jiang <scott.jiang.linux@gmail.com>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Jeongtae Park <jtp.park@samsung.com>Andrzej Pietrasiewicz <and>
Subject: Re: [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework
Date: Thu, 10 Jan 2013 17:01:50 +0300 [thread overview]
Message-ID: <20130110140150.GA19949@mwanda> (raw)
In-Reply-To: <1357822010-30419-3-git-send-email-federico.vaga@gmail.com>
This would be easier to review if it were broken up into separate
patches.
1) There are superflous white spaces changes
2) Changes to the copyright
3) pr_warning => pr_warn
4) The REG_READ and REG_WRITE macros are now inline functions
5) KBUILD_MODNAME is used instead of DRV_NAME
6) It now uses the video_drvdata() function
7) Lots of comments deleted. For exmple, vidioc_enum_fmt_vid_cap()
didn't change. Just the comments were deleted.
8) Comments added for existing code.
9) Other behavior changes not related to using videobuf2 like in
vidioc_try_fmt_vid_cap().
10) etc...
If all the uninteresting changes are in separate patches it makes
the complicated stuff much shorter and easier to review.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework
Date: Thu, 10 Jan 2013 17:01:50 +0300 [thread overview]
Message-ID: <20130110140150.GA19949@mwanda> (raw)
In-Reply-To: <1357822010-30419-3-git-send-email-federico.vaga@gmail.com>
This would be easier to review if it were broken up into separate
patches.
1) There are superflous white spaces changes
2) Changes to the copyright
3) pr_warning => pr_warn
4) The REG_READ and REG_WRITE macros are now inline functions
5) KBUILD_MODNAME is used instead of DRV_NAME
6) It now uses the video_drvdata() function
7) Lots of comments deleted. For exmple, vidioc_enum_fmt_vid_cap()
didn't change. Just the comments were deleted.
8) Comments added for existing code.
9) Other behavior changes not related to using videobuf2 like in
vidioc_try_fmt_vid_cap().
10) etc...
If all the uninteresting changes are in separate patches it makes
the complicated stuff much shorter and easier to review.
regards,
dan carpenter
next prev parent reply other threads:[~2013-01-10 14:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 12:46 [PATCH v5] modify videobuf2-dma-contig and update sta2x11_vip Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 1/3] videobuf2-dma-contig: user can specify GFP flags Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 14:16 ` Laurent Pinchart
2013-01-10 14:32 ` Federico Vaga
2013-01-10 14:32 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 2/3] sta2x11_vip: convert to videobuf2 and control framework Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 12:57 ` Federico Vaga
2013-01-10 12:57 ` Federico Vaga
2013-01-10 14:41 ` Hans Verkuil
2013-01-10 14:41 ` Hans Verkuil
2013-01-10 14:58 ` Federico Vaga
2013-01-10 14:58 ` Federico Vaga
2013-01-10 14:01 ` Dan Carpenter [this message]
2013-01-10 14:01 ` Dan Carpenter
2013-01-10 14:43 ` Federico Vaga
2013-01-10 14:43 ` Federico Vaga
2013-01-10 12:46 ` [PATCH v5 3/3] adv7180: remove {query/g_/s_}ctrl Federico Vaga
2013-01-10 12:46 ` Federico Vaga
2013-01-10 15:22 ` [PATCH v5] modify videobuf2-dma-contig and update sta2x11_vip Federico Vaga
2013-01-10 15:22 ` Federico Vaga
2013-01-10 16:06 ` Mauro Carvalho Chehab
2013-01-10 16:06 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110140150.GA19949@mwanda \
--to=dan.carpenter@oracle.com \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=federico.vaga@gmail.com \
--cc=giancarlo.asnaghi@st.com \
--cc=hans.verkuil@cisco.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
--cc=pawel@osciak.com \
--cc=peter.senna@gmail.com \
--cc=prabhakar.lad@ti.com \
--cc=sachin.kamat@linaro.org \
--cc=sasha.levin@oracle.com \
--cc=scott.jiang.linux@gmail.com \
--cc=srinivas.kandagatla@st.com \
--cc=sungchun.kang@samsung.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.