From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/bridge: Rename argument from crtc to bridge
Date: Mon, 29 Jan 2018 11:58:00 +0200 [thread overview]
Message-ID: <2430917.BY1P9l4EpX@avalon> (raw)
In-Reply-To: <20180129095531.4557-1-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Monday, 29 January 2018 11:55:31 EET Linus Walleij wrote:
> Why is the argument to ->mode_valid() called "crtc"?
> I guess a copy/paste error. Fix it.
I confirm it's a mistake, so you can probably replace "guess" with a word
carrying a bit more confidence :)
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/drm/drm_bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index bb7b97dfb93e..3270fec46979 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -91,7 +91,7 @@ struct drm_bridge_funcs {
> *
> * drm_mode_status Enum
> */
> - enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc,
> + enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge,
> const struct drm_display_mode *mode);
>
> /**
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/bridge: Rename argument from crtc to bridge
Date: Mon, 29 Jan 2018 11:58:00 +0200 [thread overview]
Message-ID: <2430917.BY1P9l4EpX@avalon> (raw)
In-Reply-To: <20180129095531.4557-1-linus.walleij@linaro.org>
Hi Linus,
Thank you for the patch.
On Monday, 29 January 2018 11:55:31 EET Linus Walleij wrote:
> Why is the argument to ->mode_valid() called "crtc"?
> I guess a copy/paste error. Fix it.
I confirm it's a mistake, so you can probably replace "guess" with a word
carrying a bit more confidence :)
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/drm/drm_bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index bb7b97dfb93e..3270fec46979 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -91,7 +91,7 @@ struct drm_bridge_funcs {
> *
> * drm_mode_status Enum
> */
> - enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc,
> + enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge,
> const struct drm_display_mode *mode);
>
> /**
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-29 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 9:55 [PATCH] drm/bridge: Rename argument from crtc to bridge Linus Walleij
2018-01-29 9:55 ` Linus Walleij
2018-01-29 9:58 ` Laurent Pinchart [this message]
2018-01-29 9:58 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2430917.BY1P9l4EpX@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.