* [PATCH] drm/bridge: Rename argument from crtc to bridge
@ 2018-01-29 9:55 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-01-29 9:55 UTC (permalink / raw)
To: linux-arm-kernel
Why is the argument to ->mode_valid() called "crtc"?
I guess a copy/paste error. Fix it.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
include/drm/drm_bridge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index bb7b97dfb93e..3270fec46979 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -91,7 +91,7 @@ struct drm_bridge_funcs {
*
* drm_mode_status Enum
*/
- enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc,
+ enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge,
const struct drm_display_mode *mode);
/**
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: Rename argument from crtc to bridge
@ 2018-01-29 9:55 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2018-01-29 9:55 UTC (permalink / raw)
To: Archit Taneja, Andrzej Hajda, Laurent Pinchart
Cc: linux-arm-kernel, dri-devel
Why is the argument to ->mode_valid() called "crtc"?
I guess a copy/paste error. Fix it.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
include/drm/drm_bridge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index bb7b97dfb93e..3270fec46979 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -91,7 +91,7 @@ struct drm_bridge_funcs {
*
* drm_mode_status Enum
*/
- enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc,
+ enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge,
const struct drm_display_mode *mode);
/**
--
2.14.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: Rename argument from crtc to bridge
2018-01-29 9:55 ` Linus Walleij
@ 2018-01-29 9:58 ` Laurent Pinchart
-1 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2018-01-29 9:58 UTC (permalink / raw)
To: linux-arm-kernel
Hi Linus,
Thank you for the patch.
On Monday, 29 January 2018 11:55:31 EET Linus Walleij wrote:
> Why is the argument to ->mode_valid() called "crtc"?
> I guess a copy/paste error. Fix it.
I confirm it's a mistake, so you can probably replace "guess" with a word
carrying a bit more confidence :)
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/drm/drm_bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index bb7b97dfb93e..3270fec46979 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -91,7 +91,7 @@ struct drm_bridge_funcs {
> *
> * drm_mode_status Enum
> */
> - enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc,
> + enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge,
> const struct drm_display_mode *mode);
>
> /**
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: Rename argument from crtc to bridge
@ 2018-01-29 9:58 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2018-01-29 9:58 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-arm-kernel, dri-devel
Hi Linus,
Thank you for the patch.
On Monday, 29 January 2018 11:55:31 EET Linus Walleij wrote:
> Why is the argument to ->mode_valid() called "crtc"?
> I guess a copy/paste error. Fix it.
I confirm it's a mistake, so you can probably replace "guess" with a word
carrying a bit more confidence :)
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/drm/drm_bridge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index bb7b97dfb93e..3270fec46979 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h
> @@ -91,7 +91,7 @@ struct drm_bridge_funcs {
> *
> * drm_mode_status Enum
> */
> - enum drm_mode_status (*mode_valid)(struct drm_bridge *crtc,
> + enum drm_mode_status (*mode_valid)(struct drm_bridge *bridge,
> const struct drm_display_mode *mode);
>
> /**
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-29 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-29 9:55 [PATCH] drm/bridge: Rename argument from crtc to bridge Linus Walleij
2018-01-29 9:55 ` Linus Walleij
2018-01-29 9:58 ` Laurent Pinchart
2018-01-29 9:58 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.