All of lore.kernel.org
 help / color / mirror / Atom feed
From: govinds@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Rob Herring <robh@kernel.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
Date: Tue, 17 Apr 2018 09:57:35 +0530	[thread overview]
Message-ID: <2807e56b227f483ac343c0e4d098aebe@codeaurora.org> (raw)
In-Reply-To: <878t9np561.fsf@kamboji.qca.qualcomm.com>


On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh@kernel.org> writes:
> 
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>> 
>>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>>> ---
>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 31 
>>> ++++++++++++++++++++++
>>>  1 file changed, 31 insertions(+)
>> 
>> One nit, otherwise:
>> 
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> 
> 
> [...]
> 
>>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>>>  	qcom,msi_base = <0x40>;
>>>  	qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>>  };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi@18000000 {
>> 
>> wifi@...
> 
> I added this and Rob's Reviewed-by to the patch in the pending branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
> 
> Govind, please check that it's ok.

Looks good to me.

Thanks,
Govind

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: govinds@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
Date: Tue, 17 Apr 2018 09:57:35 +0530	[thread overview]
Message-ID: <2807e56b227f483ac343c0e4d098aebe@codeaurora.org> (raw)
In-Reply-To: <878t9np561.fsf@kamboji.qca.qualcomm.com>


On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh@kernel.org> writes:
> 
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>> 
>>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>>> ---
>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 31 
>>> ++++++++++++++++++++++
>>>  1 file changed, 31 insertions(+)
>> 
>> One nit, otherwise:
>> 
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> 
> 
> [...]
> 
>>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>>>  	qcom,msi_base = <0x40>;
>>>  	qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>>  };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi@18000000 {
>> 
>> wifi@...
> 
> I added this and Rob's Reviewed-by to the patch in the pending branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
> 
> Govind, please check that it's ok.

Looks good to me.

Thanks,
Govind

WARNING: multiple messages have this Message-ID (diff)
From: govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
To: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
Date: Tue, 17 Apr 2018 09:57:35 +0530	[thread overview]
Message-ID: <2807e56b227f483ac343c0e4d098aebe@codeaurora.org> (raw)
In-Reply-To: <878t9np561.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>


On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
> 
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>> 
>>> Signed-off-by: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>>> ---
>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 31 
>>> ++++++++++++++++++++++
>>>  1 file changed, 31 insertions(+)
>> 
>> One nit, otherwise:
>> 
>> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> 
> 
> [...]
> 
>>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>>>  	qcom,msi_base = <0x40>;
>>>  	qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>>  };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi@18000000 {
>> 
>> wifi@...
> 
> I added this and Rob's Reviewed-by to the patch in the pending branch:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
> 
> Govind, please check that it's ok.

Looks good to me.

Thanks,
Govind

  reply	other threads:[~2018-04-17  4:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 16:49 [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block Govind Singh
2018-04-10 16:49 ` Govind Singh
2018-04-13 21:53 ` Rob Herring
2018-04-13 21:53   ` Rob Herring
2018-04-13 21:53   ` Rob Herring
2018-04-16 15:00   ` Kalle Valo
2018-04-16 15:00     ` Kalle Valo
2018-04-16 15:00     ` Kalle Valo
2018-04-17  4:27     ` govinds [this message]
2018-04-17  4:27       ` govinds-sgV2jX0FEOL9JmXXK+q4OQ
2018-04-17  4:27       ` govinds
  -- strict thread matches above, loose matches on Subject: below --
2018-03-23  5:03 [PATCH v2 00/13] ***Set4: Add support of WCN3990 bus layer support *** Govind Singh
2018-03-23  5:03 ` [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block Govind Singh
2018-03-23  5:03   ` Govind Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2807e56b227f483ac343c0e4d098aebe@codeaurora.org \
    --to=govinds@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.