* [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-10 16:49 ` Govind Singh
0 siblings, 0 replies; 13+ messages in thread
From: Govind Singh @ 2018-04-10 16:49 UTC (permalink / raw)
To: ath10k; +Cc: devicetree, Govind Singh, linux-wireless
Add device tree binding documentation details for wcn3990
wifi block present in Qualcomm SDM845/APQ8098 SoC into
"qcom,ath10k.txt".
Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
.../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 3d2a031..34e4f98 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -4,6 +4,7 @@ Required properties:
- compatible: Should be one of the following:
* "qcom,ath10k"
* "qcom,ipq4019-wifi"
+ * "qcom,wcn3990-wifi"
PCI based devices uses compatible string "qcom,ath10k" and takes calibration
data along with board specific data via "qcom,ath10k-calibration-data".
@@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
"qcom,ath10k-calibration-data" conflict with each other and only one
can be provided per device.
+SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
+
Optional properties:
- reg: Address and length of the register set for the device.
+- reg-names: Must include the list of following reg names,
+ "membase"
- resets: Must contain an entry for each entry in reset-names.
See ../reset/reseti.txt for details.
- reset-names: Must include the list of following reset names,
@@ -49,6 +54,8 @@ Optional properties:
hw versions.
- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
the length can vary between hw versions.
+- <supply-name>-supply: handle to the regulator device tree node
+ optional "supply-name" is "vdd-0.8-cx-mx".
Example (to supply the calibration data alone):
@@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
qcom,msi_base = <0x40>;
qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
};
+
+Example (to supply wcn3990 SoC wifi block details):
+
+qcom,wifi@18000000 {
+ compatible = "qcom,wcn3990-wifi";
+ reg = <0x18800000 0x800000>;
+ reg-names = "membase";
+ clocks = <&clock_gcc clk_aggre2_noc_clk>;
+ clock-names = "smmu_aggre2_noc_clk"
+ interrupts =
+ <0 130 0 /* CE0 */ >,
+ <0 131 0 /* CE1 */ >,
+ <0 132 0 /* CE2 */ >,
+ <0 133 0 /* CE3 */ >,
+ <0 134 0 /* CE4 */ >,
+ <0 135 0 /* CE5 */ >,
+ <0 136 0 /* CE6 */ >,
+ <0 137 0 /* CE7 */ >,
+ <0 138 0 /* CE8 */ >,
+ <0 139 0 /* CE9 */ >,
+ <0 140 0 /* CE10 */ >,
+ <0 141 0 /* CE11 */ >;
+ vdd-0.8-cx-mx-supply = <&pm8998_l5>;
+};
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-10 16:49 ` Govind Singh
0 siblings, 0 replies; 13+ messages in thread
From: Govind Singh @ 2018-04-10 16:49 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, devicetree, Govind Singh
Add device tree binding documentation details for wcn3990
wifi block present in Qualcomm SDM845/APQ8098 SoC into
"qcom,ath10k.txt".
Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
.../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 3d2a031..34e4f98 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -4,6 +4,7 @@ Required properties:
- compatible: Should be one of the following:
* "qcom,ath10k"
* "qcom,ipq4019-wifi"
+ * "qcom,wcn3990-wifi"
PCI based devices uses compatible string "qcom,ath10k" and takes calibration
data along with board specific data via "qcom,ath10k-calibration-data".
@@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
"qcom,ath10k-calibration-data" conflict with each other and only one
can be provided per device.
+SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
+
Optional properties:
- reg: Address and length of the register set for the device.
+- reg-names: Must include the list of following reg names,
+ "membase"
- resets: Must contain an entry for each entry in reset-names.
See ../reset/reseti.txt for details.
- reset-names: Must include the list of following reset names,
@@ -49,6 +54,8 @@ Optional properties:
hw versions.
- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
the length can vary between hw versions.
+- <supply-name>-supply: handle to the regulator device tree node
+ optional "supply-name" is "vdd-0.8-cx-mx".
Example (to supply the calibration data alone):
@@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
qcom,msi_base = <0x40>;
qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
};
+
+Example (to supply wcn3990 SoC wifi block details):
+
+qcom,wifi@18000000 {
+ compatible = "qcom,wcn3990-wifi";
+ reg = <0x18800000 0x800000>;
+ reg-names = "membase";
+ clocks = <&clock_gcc clk_aggre2_noc_clk>;
+ clock-names = "smmu_aggre2_noc_clk"
+ interrupts =
+ <0 130 0 /* CE0 */ >,
+ <0 131 0 /* CE1 */ >,
+ <0 132 0 /* CE2 */ >,
+ <0 133 0 /* CE3 */ >,
+ <0 134 0 /* CE4 */ >,
+ <0 135 0 /* CE5 */ >,
+ <0 136 0 /* CE6 */ >,
+ <0 137 0 /* CE7 */ >,
+ <0 138 0 /* CE8 */ >,
+ <0 139 0 /* CE9 */ >,
+ <0 140 0 /* CE10 */ >,
+ <0 141 0 /* CE11 */ >;
+ vdd-0.8-cx-mx-supply = <&pm8998_l5>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
2018-04-10 16:49 ` Govind Singh
(?)
@ 2018-04-13 21:53 ` Rob Herring
-1 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2018-04-13 21:53 UTC (permalink / raw)
To: Govind Singh; +Cc: devicetree, linux-wireless, ath10k
On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
> Add device tree binding documentation details for wcn3990
> wifi block present in Qualcomm SDM845/APQ8098 SoC into
> "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> ---
> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
One nit, otherwise:
Reviewed-by: Rob Herring <robh@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 3d2a031..34e4f98 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible: Should be one of the following:
> * "qcom,ath10k"
> * "qcom,ipq4019-wifi"
> + * "qcom,wcn3990-wifi"
>
> PCI based devices uses compatible string "qcom,ath10k" and takes calibration
> data along with board specific data via "qcom,ath10k-calibration-data".
> @@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
> "qcom,ath10k-calibration-data" conflict with each other and only one
> can be provided per device.
>
> +SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
> +
> Optional properties:
> - reg: Address and length of the register set for the device.
> +- reg-names: Must include the list of following reg names,
> + "membase"
> - resets: Must contain an entry for each entry in reset-names.
> See ../reset/reseti.txt for details.
> - reset-names: Must include the list of following reset names,
> @@ -49,6 +54,8 @@ Optional properties:
> hw versions.
> - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> the length can vary between hw versions.
> +- <supply-name>-supply: handle to the regulator device tree node
> + optional "supply-name" is "vdd-0.8-cx-mx".
>
> Example (to supply the calibration data alone):
>
> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
> qcom,msi_base = <0x40>;
> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
> };
> +
> +Example (to supply wcn3990 SoC wifi block details):
> +
> +qcom,wifi@18000000 {
wifi@...
> + compatible = "qcom,wcn3990-wifi";
> + reg = <0x18800000 0x800000>;
> + reg-names = "membase";
> + clocks = <&clock_gcc clk_aggre2_noc_clk>;
> + clock-names = "smmu_aggre2_noc_clk"
> + interrupts =
> + <0 130 0 /* CE0 */ >,
> + <0 131 0 /* CE1 */ >,
> + <0 132 0 /* CE2 */ >,
> + <0 133 0 /* CE3 */ >,
> + <0 134 0 /* CE4 */ >,
> + <0 135 0 /* CE5 */ >,
> + <0 136 0 /* CE6 */ >,
> + <0 137 0 /* CE7 */ >,
> + <0 138 0 /* CE8 */ >,
> + <0 139 0 /* CE9 */ >,
> + <0 140 0 /* CE10 */ >,
> + <0 141 0 /* CE11 */ >;
> + vdd-0.8-cx-mx-supply = <&pm8998_l5>;
> +};
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-13 21:53 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2018-04-13 21:53 UTC (permalink / raw)
To: Govind Singh
Cc: ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA
On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
> Add device tree binding documentation details for wcn3990
> wifi block present in Qualcomm SDM845/APQ8098 SoC into
> "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> ---
> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
One nit, otherwise:
Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 3d2a031..34e4f98 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible: Should be one of the following:
> * "qcom,ath10k"
> * "qcom,ipq4019-wifi"
> + * "qcom,wcn3990-wifi"
>
> PCI based devices uses compatible string "qcom,ath10k" and takes calibration
> data along with board specific data via "qcom,ath10k-calibration-data".
> @@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
> "qcom,ath10k-calibration-data" conflict with each other and only one
> can be provided per device.
>
> +SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
> +
> Optional properties:
> - reg: Address and length of the register set for the device.
> +- reg-names: Must include the list of following reg names,
> + "membase"
> - resets: Must contain an entry for each entry in reset-names.
> See ../reset/reseti.txt for details.
> - reset-names: Must include the list of following reset names,
> @@ -49,6 +54,8 @@ Optional properties:
> hw versions.
> - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> the length can vary between hw versions.
> +- <supply-name>-supply: handle to the regulator device tree node
> + optional "supply-name" is "vdd-0.8-cx-mx".
>
> Example (to supply the calibration data alone):
>
> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
> qcom,msi_base = <0x40>;
> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
> };
> +
> +Example (to supply wcn3990 SoC wifi block details):
> +
> +qcom,wifi@18000000 {
wifi@...
> + compatible = "qcom,wcn3990-wifi";
> + reg = <0x18800000 0x800000>;
> + reg-names = "membase";
> + clocks = <&clock_gcc clk_aggre2_noc_clk>;
> + clock-names = "smmu_aggre2_noc_clk"
> + interrupts =
> + <0 130 0 /* CE0 */ >,
> + <0 131 0 /* CE1 */ >,
> + <0 132 0 /* CE2 */ >,
> + <0 133 0 /* CE3 */ >,
> + <0 134 0 /* CE4 */ >,
> + <0 135 0 /* CE5 */ >,
> + <0 136 0 /* CE6 */ >,
> + <0 137 0 /* CE7 */ >,
> + <0 138 0 /* CE8 */ >,
> + <0 139 0 /* CE9 */ >,
> + <0 140 0 /* CE10 */ >,
> + <0 141 0 /* CE11 */ >;
> + vdd-0.8-cx-mx-supply = <&pm8998_l5>;
> +};
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-13 21:53 ` Rob Herring
0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2018-04-13 21:53 UTC (permalink / raw)
To: Govind Singh; +Cc: ath10k, linux-wireless, devicetree
On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
> Add device tree binding documentation details for wcn3990
> wifi block present in Qualcomm SDM845/APQ8098 SoC into
> "qcom,ath10k.txt".
>
> Signed-off-by: Govind Singh <govinds@codeaurora.org>
> ---
> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
One nit, otherwise:
Reviewed-by: Rob Herring <robh@kernel.org>
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index 3d2a031..34e4f98 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible: Should be one of the following:
> * "qcom,ath10k"
> * "qcom,ipq4019-wifi"
> + * "qcom,wcn3990-wifi"
>
> PCI based devices uses compatible string "qcom,ath10k" and takes calibration
> data along with board specific data via "qcom,ath10k-calibration-data".
> @@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
> "qcom,ath10k-calibration-data" conflict with each other and only one
> can be provided per device.
>
> +SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
> +
> Optional properties:
> - reg: Address and length of the register set for the device.
> +- reg-names: Must include the list of following reg names,
> + "membase"
> - resets: Must contain an entry for each entry in reset-names.
> See ../reset/reseti.txt for details.
> - reset-names: Must include the list of following reset names,
> @@ -49,6 +54,8 @@ Optional properties:
> hw versions.
> - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> the length can vary between hw versions.
> +- <supply-name>-supply: handle to the regulator device tree node
> + optional "supply-name" is "vdd-0.8-cx-mx".
>
> Example (to supply the calibration data alone):
>
> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
> qcom,msi_base = <0x40>;
> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
> };
> +
> +Example (to supply wcn3990 SoC wifi block details):
> +
> +qcom,wifi@18000000 {
wifi@...
> + compatible = "qcom,wcn3990-wifi";
> + reg = <0x18800000 0x800000>;
> + reg-names = "membase";
> + clocks = <&clock_gcc clk_aggre2_noc_clk>;
> + clock-names = "smmu_aggre2_noc_clk"
> + interrupts =
> + <0 130 0 /* CE0 */ >,
> + <0 131 0 /* CE1 */ >,
> + <0 132 0 /* CE2 */ >,
> + <0 133 0 /* CE3 */ >,
> + <0 134 0 /* CE4 */ >,
> + <0 135 0 /* CE5 */ >,
> + <0 136 0 /* CE6 */ >,
> + <0 137 0 /* CE7 */ >,
> + <0 138 0 /* CE8 */ >,
> + <0 139 0 /* CE9 */ >,
> + <0 140 0 /* CE10 */ >,
> + <0 141 0 /* CE11 */ >;
> + vdd-0.8-cx-mx-supply = <&pm8998_l5>;
> +};
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
2018-04-13 21:53 ` Rob Herring
(?)
@ 2018-04-16 15:00 ` Kalle Valo
-1 siblings, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2018-04-16 15:00 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, Govind Singh, linux-wireless, ath10k
Rob Herring <robh@kernel.org> writes:
> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>> Add device tree binding documentation details for wcn3990
>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>> "qcom,ath10k.txt".
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> ---
>> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>
> One nit, otherwise:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
[...]
>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>> qcom,msi_base = <0x40>;
>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>> };
>> +
>> +Example (to supply wcn3990 SoC wifi block details):
>> +
>> +qcom,wifi@18000000 {
>
> wifi@...
I added this and Rob's Reviewed-by to the patch in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
Govind, please check that it's ok.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-16 15:00 ` Kalle Valo
0 siblings, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2018-04-16 15:00 UTC (permalink / raw)
To: Rob Herring
Cc: Govind Singh, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>> Add device tree binding documentation details for wcn3990
>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>> "qcom,ath10k.txt".
>>
>> Signed-off-by: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>
> One nit, otherwise:
>
> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
[...]
>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>> qcom,msi_base = <0x40>;
>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>> };
>> +
>> +Example (to supply wcn3990 SoC wifi block details):
>> +
>> +qcom,wifi@18000000 {
>
> wifi@...
I added this and Rob's Reviewed-by to the patch in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
Govind, please check that it's ok.
--
Kalle Valo
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-16 15:00 ` Kalle Valo
0 siblings, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2018-04-16 15:00 UTC (permalink / raw)
To: Rob Herring; +Cc: Govind Singh, devicetree, linux-wireless, ath10k
Rob Herring <robh@kernel.org> writes:
> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>> Add device tree binding documentation details for wcn3990
>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>> "qcom,ath10k.txt".
>>
>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>> ---
>> .../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>
> One nit, otherwise:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
[...]
>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>> qcom,msi_base = <0x40>;
>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>> };
>> +
>> +Example (to supply wcn3990 SoC wifi block details):
>> +
>> +qcom,wifi@18000000 {
>
> wifi@...
I added this and Rob's Reviewed-by to the patch in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
Govind, please check that it's ok.
--
Kalle Valo
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
2018-04-16 15:00 ` Kalle Valo
(?)
@ 2018-04-17 4:27 ` govinds
-1 siblings, 0 replies; 13+ messages in thread
From: govinds @ 2018-04-17 4:27 UTC (permalink / raw)
To: Kalle Valo; +Cc: Rob Herring, linux-wireless, ath10k, devicetree
On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh@kernel.org> writes:
>
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>>
>>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>>> ---
>>> .../bindings/net/wireless/qcom,ath10k.txt | 31
>>> ++++++++++++++++++++++
>>> 1 file changed, 31 insertions(+)
>>
>> One nit, otherwise:
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>
> [...]
>
>>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>>> qcom,msi_base = <0x40>;
>>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>> };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi@18000000 {
>>
>> wifi@...
>
> I added this and Rob's Reviewed-by to the patch in the pending branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
>
> Govind, please check that it's ok.
Looks good to me.
Thanks,
Govind
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-17 4:27 ` govinds
0 siblings, 0 replies; 13+ messages in thread
From: govinds-sgV2jX0FEOL9JmXXK+q4OQ @ 2018-04-17 4:27 UTC (permalink / raw)
To: Kalle Valo
Cc: Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
ath10k-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
>
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>>
>>> Signed-off-by: Govind Singh <govinds-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>>> ---
>>> .../bindings/net/wireless/qcom,ath10k.txt | 31
>>> ++++++++++++++++++++++
>>> 1 file changed, 31 insertions(+)
>>
>> One nit, otherwise:
>>
>> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>
>
> [...]
>
>>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>>> qcom,msi_base = <0x40>;
>>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>> };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi@18000000 {
>>
>> wifi@...
>
> I added this and Rob's Reviewed-by to the patch in the pending branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
>
> Govind, please check that it's ok.
Looks good to me.
Thanks,
Govind
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-04-17 4:27 ` govinds
0 siblings, 0 replies; 13+ messages in thread
From: govinds @ 2018-04-17 4:27 UTC (permalink / raw)
To: Kalle Valo; +Cc: Rob Herring, devicetree, linux-wireless, ath10k
On 2018-04-16 20:30, Kalle Valo wrote:
> Rob Herring <robh@kernel.org> writes:
>
>> On Tue, Apr 10, 2018 at 10:19:46PM +0530, Govind Singh wrote:
>>> Add device tree binding documentation details for wcn3990
>>> wifi block present in Qualcomm SDM845/APQ8098 SoC into
>>> "qcom,ath10k.txt".
>>>
>>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>>> ---
>>> .../bindings/net/wireless/qcom,ath10k.txt | 31
>>> ++++++++++++++++++++++
>>> 1 file changed, 31 insertions(+)
>>
>> One nit, otherwise:
>>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>
> [...]
>
>>> @@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
>>> qcom,msi_base = <0x40>;
>>> qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
>>> };
>>> +
>>> +Example (to supply wcn3990 SoC wifi block details):
>>> +
>>> +qcom,wifi@18000000 {
>>
>> wifi@...
>
> I added this and Rob's Reviewed-by to the patch in the pending branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=20f4accbe76af8f137b4218ce4973bda6fc3d23e
>
> Govind, please check that it's ok.
Looks good to me.
Thanks,
Govind
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v2 00/13] ***Set4: Add support of WCN3990 bus layer support ***
@ 2018-03-23 5:03 Govind Singh
2018-03-23 5:03 ` Govind Singh
0 siblings, 1 reply; 13+ messages in thread
From: Govind Singh @ 2018-03-23 5:03 UTC (permalink / raw)
To: ath10k; +Cc: Govind Singh, linux-wireless
This change adds support for integrated wcn3990 chipset on
MSM platforms. WCN3990 is 2x2 802.11ac chipset where wlan
subsystem is interfaced over system interconnect.
Wlan fw runs in Q6 DSP. WCN3990 chipset uses 12 copy engine
for host to target and target to host communication. It has
extra 2 copy engine in rx data path and packet log capability
is exposed via new HTC service over dedicated copy engine.
Each CE has dedicated interrupt of rx path and tx completion.
[CE0] :host->target control and raw streams
[CE1] :target->host HTT
[CE2] :target->host WMI
[CE3] :host->target WMI
[CE4] :host->target HTT
[CE5] :reserved
[CE6] :Target autonomous HIF_memcpy
[CE7] :reserved
[CE8] :reserved
[CE9] :target->host HTT
[CE10] :target->host HTT
[CE11] :target -> host PKTLOG
Changes in V2:
Rebased the set on top of https://patchwork.kernel.org/patch/10298657/.
Removed qcom,<supply>-config and minor clean up in dt binding documentation.
Govind Singh (11):
ath10k: platform driver for WCN3990 SNOC WLAN module
ath10k: add resource init and deinit for WCN3990
ath10k: Add hif start/stop methods for wcn3990 snoc layer
ath10k: Add HTC services for WCN3990
ath10k: Map HTC services to tx/rx pipes for wcn3990
ath10k: Add hif power-up/power-down methods
ath10k: Add hif tx methods for wcn3990
ath10k: Add hif rx methods for wcn3990
ath10k: Modify hif tx paddr to dma_addr_t type
ath10k: Vote for hardware resources for WCN3990
dt: bindings: add bindings for wcn3990 wifi block
Rakesh Pillai (2):
ath10k: Add support to get target info from hif ops
ath10k: Check all CE for data if irq summary is not retained
.../bindings/net/wireless/qcom,ath10k.txt | 31 +
drivers/net/wireless/ath/ath10k/Kconfig | 8 +
drivers/net/wireless/ath/ath10k/Makefile | 3 +
drivers/net/wireless/ath/ath10k/ce.h | 10 +-
drivers/net/wireless/ath/ath10k/core.c | 21 +
drivers/net/wireless/ath/ath10k/hif.h | 15 +-
drivers/net/wireless/ath/ath10k/htc.c | 6 +
drivers/net/wireless/ath/ath10k/htc.h | 4 +
drivers/net/wireless/ath/ath10k/hw.h | 3 +
drivers/net/wireless/ath/ath10k/pci.c | 8 +-
drivers/net/wireless/ath/ath10k/snoc.c | 1411 ++++++++++++++++++++
drivers/net/wireless/ath/ath10k/snoc.h | 95 ++
12 files changed, 1607 insertions(+), 8 deletions(-)
create mode 100644 drivers/net/wireless/ath/ath10k/snoc.c
create mode 100644 drivers/net/wireless/ath/ath10k/snoc.h
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread* [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
2018-03-23 5:03 [PATCH v2 00/13] ***Set4: Add support of WCN3990 bus layer support *** Govind Singh
@ 2018-03-23 5:03 ` Govind Singh
0 siblings, 0 replies; 13+ messages in thread
From: Govind Singh @ 2018-03-23 5:03 UTC (permalink / raw)
To: ath10k; +Cc: Govind Singh, linux-wireless
Add device tree binding documentation details for wcn3990
wifi block present in Qualcomm SDM845/APQ8098 SoC into
"qcom,ath10k.txt".
Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
.../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 3d2a031..34e4f98 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -4,6 +4,7 @@ Required properties:
- compatible: Should be one of the following:
* "qcom,ath10k"
* "qcom,ipq4019-wifi"
+ * "qcom,wcn3990-wifi"
PCI based devices uses compatible string "qcom,ath10k" and takes calibration
data along with board specific data via "qcom,ath10k-calibration-data".
@@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
"qcom,ath10k-calibration-data" conflict with each other and only one
can be provided per device.
+SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
+
Optional properties:
- reg: Address and length of the register set for the device.
+- reg-names: Must include the list of following reg names,
+ "membase"
- resets: Must contain an entry for each entry in reset-names.
See ../reset/reseti.txt for details.
- reset-names: Must include the list of following reset names,
@@ -49,6 +54,8 @@ Optional properties:
hw versions.
- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
the length can vary between hw versions.
+- <supply-name>-supply: handle to the regulator device tree node
+ optional "supply-name" is "vdd-0.8-cx-mx".
Example (to supply the calibration data alone):
@@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
qcom,msi_base = <0x40>;
qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
};
+
+Example (to supply wcn3990 SoC wifi block details):
+
+qcom,wifi@18000000 {
+ compatible = "qcom,wcn3990-wifi";
+ reg = <0x18800000 0x800000>;
+ reg-names = "membase";
+ clocks = <&clock_gcc clk_aggre2_noc_clk>;
+ clock-names = "smmu_aggre2_noc_clk"
+ interrupts =
+ <0 130 0 /* CE0 */ >,
+ <0 131 0 /* CE1 */ >,
+ <0 132 0 /* CE2 */ >,
+ <0 133 0 /* CE3 */ >,
+ <0 134 0 /* CE4 */ >,
+ <0 135 0 /* CE5 */ >,
+ <0 136 0 /* CE6 */ >,
+ <0 137 0 /* CE7 */ >,
+ <0 138 0 /* CE8 */ >,
+ <0 139 0 /* CE9 */ >,
+ <0 140 0 /* CE10 */ >,
+ <0 141 0 /* CE11 */ >;
+ vdd-0.8-cx-mx-supply = <&pm8998_l5>;
+};
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block
@ 2018-03-23 5:03 ` Govind Singh
0 siblings, 0 replies; 13+ messages in thread
From: Govind Singh @ 2018-03-23 5:03 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Govind Singh
Add device tree binding documentation details for wcn3990
wifi block present in Qualcomm SDM845/APQ8098 SoC into
"qcom,ath10k.txt".
Signed-off-by: Govind Singh <govinds@codeaurora.org>
---
.../bindings/net/wireless/qcom,ath10k.txt | 31 ++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index 3d2a031..34e4f98 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -4,6 +4,7 @@ Required properties:
- compatible: Should be one of the following:
* "qcom,ath10k"
* "qcom,ipq4019-wifi"
+ * "qcom,wcn3990-wifi"
PCI based devices uses compatible string "qcom,ath10k" and takes calibration
data along with board specific data via "qcom,ath10k-calibration-data".
@@ -18,8 +19,12 @@ In general, entry "qcom,ath10k-pre-calibration-data" and
"qcom,ath10k-calibration-data" conflict with each other and only one
can be provided per device.
+SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
+
Optional properties:
- reg: Address and length of the register set for the device.
+- reg-names: Must include the list of following reg names,
+ "membase"
- resets: Must contain an entry for each entry in reset-names.
See ../reset/reseti.txt for details.
- reset-names: Must include the list of following reset names,
@@ -49,6 +54,8 @@ Optional properties:
hw versions.
- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
the length can vary between hw versions.
+- <supply-name>-supply: handle to the regulator device tree node
+ optional "supply-name" is "vdd-0.8-cx-mx".
Example (to supply the calibration data alone):
@@ -119,3 +126,27 @@ wifi0: wifi@a000000 {
qcom,msi_base = <0x40>;
qcom,ath10k-pre-calibration-data = [ 01 02 03 ... ];
};
+
+Example (to supply wcn3990 SoC wifi block details):
+
+qcom,wifi@18000000 {
+ compatible = "qcom,wcn3990-wifi";
+ reg = <0x18800000 0x800000>;
+ reg-names = "membase";
+ clocks = <&clock_gcc clk_aggre2_noc_clk>;
+ clock-names = "smmu_aggre2_noc_clk"
+ interrupts =
+ <0 130 0 /* CE0 */ >,
+ <0 131 0 /* CE1 */ >,
+ <0 132 0 /* CE2 */ >,
+ <0 133 0 /* CE3 */ >,
+ <0 134 0 /* CE4 */ >,
+ <0 135 0 /* CE5 */ >,
+ <0 136 0 /* CE6 */ >,
+ <0 137 0 /* CE7 */ >,
+ <0 138 0 /* CE8 */ >,
+ <0 139 0 /* CE9 */ >,
+ <0 140 0 /* CE10 */ >,
+ <0 141 0 /* CE11 */ >;
+ vdd-0.8-cx-mx-supply = <&pm8998_l5>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-04-17 4:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-10 16:49 [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block Govind Singh
2018-04-10 16:49 ` Govind Singh
2018-04-13 21:53 ` Rob Herring
2018-04-13 21:53 ` Rob Herring
2018-04-13 21:53 ` Rob Herring
2018-04-16 15:00 ` Kalle Valo
2018-04-16 15:00 ` Kalle Valo
2018-04-16 15:00 ` Kalle Valo
2018-04-17 4:27 ` govinds
2018-04-17 4:27 ` govinds-sgV2jX0FEOL9JmXXK+q4OQ
2018-04-17 4:27 ` govinds
-- strict thread matches above, loose matches on Subject: below --
2018-03-23 5:03 [PATCH v2 00/13] ***Set4: Add support of WCN3990 bus layer support *** Govind Singh
2018-03-23 5:03 ` [PATCH v2 13/13] dt: bindings: add bindings for wcn3990 wifi block Govind Singh
2018-03-23 5:03 ` Govind Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.