From: Arnd Bergmann <arnd@arndb.de>
To: Zhou Wang <wangzhou1@hisilicon.com>
Cc: Fabrice Gasnier <fabrice.gasnier@st.com>,
Jingoo Han <jingoohan1@gmail.com>,
zhudacai@hisilicon.com, devicetree@vger.kernel.org,
'Gabriele Paoloni' <gabriele.paoloni@huawei.com>,
'Richard Zhu' <Richard.Zhu@freescale.com>,
linux-pci@vger.kernel.org,
'Pratyush Anand' <pratyush.anand@gmail.com>,
'Liviu Dudau' <liviu.dudau@arm.com>,
'Zhichang Yuan' <yuanzhichang@hisilicon.com>,
'Kishon Vijay Abraham I' <kishon@ti.com>,
qiuzhenfa@hisilicon.com, 'Bjorn Helgaas' <bhelgaas@google.com>,
'Zhang Jukuo' <zhangjukuo@huawei.com>,
'Liguozhu' <liguozhu@hisilicon.com>,
linux-arm-kernel@lists.infradead.org,
'Lucas Stach' <l.stach@pengutronix.de>
Subject: Re: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support
Date: Tue, 26 May 2015 10:02:29 +0200 [thread overview]
Message-ID: <3340422.95mKZ6cYUI@wuerfel> (raw)
In-Reply-To: <5563DF4F.4080601@hisilicon.com>
On Tuesday 26 May 2015 10:49:51 Zhou Wang wrote:
>
> I am a little confused that pci_sys_data is still needed as we don't use the code
> in bios32. What was the problem you met? Could you share me more information? Then
> let's see how to solve the problem.
>
The PCI core code still calls pcibios_align_resource(), which will try to
use the dev->sysdata pointer as 'struct pci_sys_data'. To solve this, we
need to change the pci-mvebu driver and the core code first to let the
driver override pcibios_align_resource() through an operation in
struct pci_host_bridge.
The other remaining use of dev->sysdata is the ARM pcibios_msi_controller()
function that overrides the generic implementation. To solve this, we need
to change the five remaining drivers that set hw_pci->msi_ctrl to use
the new generic method, and remove the ARM specific implementation.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support
Date: Tue, 26 May 2015 10:02:29 +0200 [thread overview]
Message-ID: <3340422.95mKZ6cYUI@wuerfel> (raw)
In-Reply-To: <5563DF4F.4080601@hisilicon.com>
On Tuesday 26 May 2015 10:49:51 Zhou Wang wrote:
>
> I am a little confused that pci_sys_data is still needed as we don't use the code
> in bios32. What was the problem you met? Could you share me more information? Then
> let's see how to solve the problem.
>
The PCI core code still calls pcibios_align_resource(), which will try to
use the dev->sysdata pointer as 'struct pci_sys_data'. To solve this, we
need to change the pci-mvebu driver and the core code first to let the
driver override pcibios_align_resource() through an operation in
struct pci_host_bridge.
The other remaining use of dev->sysdata is the ARM pcibios_msi_controller()
function that overrides the generic implementation. To solve this, we need
to change the five remaining drivers that set hw_pci->msi_ctrl to use
the new generic method, and remove the ARM specific implementation.
Arnd
next prev parent reply other threads:[~2015-05-26 8:03 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 5:10 [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support Jingoo Han
2015-05-25 5:10 ` Jingoo Han
2015-05-25 9:52 ` Zhou Wang
2015-05-25 9:52 ` Zhou Wang
2015-05-25 9:52 ` Zhou Wang
2015-05-25 13:48 ` Jingoo Han
2015-05-25 13:48 ` Jingoo Han
2015-05-25 13:48 ` Jingoo Han
2015-05-25 15:51 ` Fabrice Gasnier
2015-05-25 15:51 ` Fabrice Gasnier
2015-05-25 15:51 ` Fabrice Gasnier
2015-05-26 2:49 ` Zhou Wang
2015-05-26 2:49 ` Zhou Wang
2015-05-26 2:49 ` Zhou Wang
2015-05-26 8:02 ` Arnd Bergmann [this message]
2015-05-26 8:02 ` Arnd Bergmann
2015-05-27 13:56 ` Zhou Wang
2015-05-27 13:56 ` Zhou Wang
2015-05-27 13:56 ` Zhou Wang
2015-05-27 15:31 ` Arnd Bergmann
2015-05-27 15:31 ` Arnd Bergmann
2015-05-27 15:31 ` Arnd Bergmann
2015-05-27 15:43 ` Arnd Bergmann
2015-05-27 15:43 ` Arnd Bergmann
2015-05-27 16:19 ` Fabrice Gasnier
2015-05-27 16:19 ` Fabrice Gasnier
2015-05-27 16:19 ` Fabrice Gasnier
2015-05-27 19:51 ` Arnd Bergmann
2015-05-27 19:51 ` Arnd Bergmann
2015-05-28 11:48 ` Zhou Wang
2015-05-28 11:48 ` Zhou Wang
2015-05-28 11:48 ` Zhou Wang
2015-05-28 12:25 ` Arnd Bergmann
2015-05-28 12:25 ` Arnd Bergmann
2015-05-28 11:40 ` Zhou Wang
2015-05-28 11:40 ` Zhou Wang
2015-05-28 11:40 ` Zhou Wang
2015-05-28 11:34 ` Zhou Wang
2015-05-28 11:34 ` Zhou Wang
2015-05-28 11:34 ` Zhou Wang
2015-05-28 12:30 ` Arnd Bergmann
2015-05-28 12:30 ` Arnd Bergmann
2015-05-28 12:30 ` Arnd Bergmann
2015-05-26 8:03 ` Fabrice Gasnier
2015-05-26 8:03 ` Fabrice Gasnier
2015-05-26 8:03 ` Fabrice Gasnier
2015-05-27 13:24 ` Zhou Wang
2015-05-27 13:24 ` Zhou Wang
2015-05-27 13:24 ` Zhou Wang
2015-05-27 13:52 ` Fabrice Gasnier
2015-05-27 13:52 ` Fabrice Gasnier
2015-05-27 13:52 ` Fabrice Gasnier
2015-05-26 2:04 ` Zhou Wang
2015-05-26 2:04 ` Zhou Wang
2015-05-26 2:04 ` Zhou Wang
2015-05-26 8:09 ` Arnd Bergmann
2015-05-26 8:09 ` Arnd Bergmann
2015-05-27 13:28 ` Zhou Wang
2015-05-27 13:28 ` Zhou Wang
2015-05-27 13:28 ` Zhou Wang
-- strict thread matches above, loose matches on Subject: below --
2015-05-20 6:21 [RFC PATCH v1 0/3] PCI: hisi: Add PCIe host support for Hisilicon Soc Hip05 Zhou Wang
2015-05-20 6:21 ` [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support Zhou Wang
2015-05-20 6:21 ` Zhou Wang
2015-05-20 6:21 ` Zhou Wang
2015-05-25 1:33 ` Zhou Wang
2015-05-25 1:33 ` Zhou Wang
2015-05-25 1:33 ` Zhou Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3340422.95mKZ6cYUI@wuerfel \
--to=arnd@arndb.de \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=gabriele.paoloni@huawei.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=l.stach@pengutronix.de \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=pratyush.anand@gmail.com \
--cc=qiuzhenfa@hisilicon.com \
--cc=wangzhou1@hisilicon.com \
--cc=yuanzhichang@hisilicon.com \
--cc=zhangjukuo@huawei.com \
--cc=zhudacai@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.