From: Matthew Dobson <colpatch@us.ibm.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, LSE <lse-tech@lists.sourceforge.net>,
Andrew Morton <akpm@zip.com.au>,
Michael Hohnbaum <hohnbaum@us.ibm.com>
Subject: Re: [rfc][patch] Memory Binding API v0.3 2.5.41
Date: Thu, 10 Oct 2002 11:43:34 -0700 [thread overview]
Message-ID: <3DA5CA56.6070402@us.ibm.com> (raw)
In-Reply-To: 1586204621.1034197575@[10.10.2.3]
Martin J. Bligh wrote:
>>+#define for_each_valid_zone(zone, zonelist) \
>>+ for (zone = *zonelist->zones; zone; zone++) \
>>+ if (current->memblk_binding.bitmask & (1 << zone->zone_pgdat->memblk_id))
>
> Does the compiler optimise the last bit away on non-NUMA?
Nope.
> Want to wrap it in #ifdef CONFIG_NUMA_MEMBIND or something?
Not a problem... I've got some free time this afternoon... Should only
take me a few hours to retool the patch to include this change. ;)
> Not sure what the speed impact of this would be, but I'd
> rather it was optional, even on NUMA boxen.
Sounds reasonable... It'll be in the next itteration.
> Other than that, looks pretty good.
Glad to hear!
> M.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Dobson <colpatch@us.ibm.com>
To: "Martin J. Bligh" <mbligh@aracnet.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, LSE <lse-tech@lists.sourceforge.net>,
Andrew Morton <akpm@zip.com.au>,
Michael Hohnbaum <hohnbaum@us.ibm.com>
Subject: Re: [rfc][patch] Memory Binding API v0.3 2.5.41
Date: Thu, 10 Oct 2002 11:43:34 -0700 [thread overview]
Message-ID: <3DA5CA56.6070402@us.ibm.com> (raw)
In-Reply-To: 1586204621.1034197575@[10.10.2.3]
Martin J. Bligh wrote:
>>+#define for_each_valid_zone(zone, zonelist) \
>>+ for (zone = *zonelist->zones; zone; zone++) \
>>+ if (current->memblk_binding.bitmask & (1 << zone->zone_pgdat->memblk_id))
>
> Does the compiler optimise the last bit away on non-NUMA?
Nope.
> Want to wrap it in #ifdef CONFIG_NUMA_MEMBIND or something?
Not a problem... I've got some free time this afternoon... Should only
take me a few hours to retool the patch to include this change. ;)
> Not sure what the speed impact of this would be, but I'd
> rather it was optional, even on NUMA boxen.
Sounds reasonable... It'll be in the next itteration.
> Other than that, looks pretty good.
Glad to hear!
> M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-10-10 18:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-10 1:12 [rfc][patch] Memory Binding API v0.3 2.5.41 Matthew Dobson
2002-10-10 3:05 ` Andrew Morton
2002-10-10 3:05 ` Andrew Morton
2002-10-10 18:29 ` Matthew Dobson
2002-10-10 18:29 ` Matthew Dobson
2002-10-10 4:06 ` Martin J. Bligh
2002-10-10 4:06 ` Martin J. Bligh
2002-10-10 18:43 ` Matthew Dobson [this message]
2002-10-10 18:43 ` Matthew Dobson
2002-10-10 9:00 ` Arjan van de Ven
2002-10-10 18:55 ` Matthew Dobson
2002-10-10 18:55 ` Matthew Dobson
2002-10-10 10:06 ` Arjan van de Ven
2002-10-10 11:22 ` Alan Cox
2002-10-10 11:22 ` Alan Cox
2002-10-10 11:28 ` William Lee Irwin III
2002-10-10 11:28 ` William Lee Irwin III
2002-10-10 19:09 ` Matthew Dobson
2002-10-10 19:09 ` Matthew Dobson
2002-10-10 19:06 ` Matthew Dobson
2002-10-10 19:06 ` Matthew Dobson
2002-10-10 19:01 ` Matthew Dobson
2002-10-10 19:01 ` Matthew Dobson
2002-10-13 22:22 ` Eric W. Biederman
2002-10-13 22:22 ` Eric W. Biederman
2002-10-15 0:14 ` Matthew Dobson
2002-10-15 0:14 ` Matthew Dobson
2002-10-15 0:20 ` Martin J. Bligh
2002-10-15 0:20 ` Martin J. Bligh
2002-10-15 0:38 ` Matthew Dobson
2002-10-15 0:38 ` Matthew Dobson
2002-10-15 0:43 ` Martin J. Bligh
2002-10-15 0:43 ` Martin J. Bligh
2002-10-15 0:51 ` Matthew Dobson
2002-10-15 0:51 ` Matthew Dobson
2002-10-15 0:58 ` William Lee Irwin III
2002-10-15 0:58 ` William Lee Irwin III
2002-10-15 0:55 ` [Lse-tech] " john stultz
2002-10-15 0:55 ` john stultz
2002-10-15 1:08 ` Martin J. Bligh
2002-10-15 1:08 ` Martin J. Bligh
2002-10-15 1:20 ` William Lee Irwin III
2002-10-15 1:20 ` William Lee Irwin III
2002-10-15 1:29 ` Martin J. Bligh
2002-10-15 1:29 ` Martin J. Bligh
2002-10-15 1:40 ` William Lee Irwin III
2002-10-15 1:40 ` William Lee Irwin III
2002-10-15 1:57 ` William Lee Irwin III
2002-10-15 1:57 ` William Lee Irwin III
2002-10-15 1:08 ` William Lee Irwin III
2002-10-15 1:08 ` William Lee Irwin III
2002-10-15 1:16 ` Martin J. Bligh
2002-10-15 1:16 ` Martin J. Bligh
2002-10-15 17:21 ` Eric W. Biederman
2002-10-15 17:21 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DA5CA56.6070402@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=akpm@zip.com.au \
--cc=hohnbaum@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.