* [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
@ 2018-12-24 17:49 ` Aditya Pakki
0 siblings, 0 replies; 6+ messages in thread
From: Aditya Pakki @ 2018-12-24 17:49 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Marek Lindner, Simon Wunderlich, Antonio Quartulli,
David S. Miller, b.a.t.m.a.n, netdev, linux-kernel
rtnl_link_register() may fail and can impact registering the device.
The fix checks the return value and pushes the error upstream.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
net/batman-adv/main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 69c0d85bceb3..e0007f242823 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -109,7 +109,10 @@ static int __init batadv_init(void)
batadv_debugfs_init();
register_netdevice_notifier(&batadv_hard_if_notifier);
- rtnl_link_register(&batadv_link_ops);
+ ret = rtnl_link_register(&batadv_link_ops);
+ if (ret < 0)
+ return ret;
+
batadv_netlink_register();
pr_info("B.A.T.M.A.N. advanced %s (compatibility version %i) loaded\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
@ 2018-12-24 17:49 ` Aditya Pakki
0 siblings, 0 replies; 6+ messages in thread
From: Aditya Pakki @ 2018-12-24 17:49 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Marek Lindner, Simon Wunderlich, Antonio Quartulli,
David S. Miller, b.a.t.m.a.n, netdev, linux-kernel
rtnl_link_register() may fail and can impact registering the device.
The fix checks the return value and pushes the error upstream.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
net/batman-adv/main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
index 69c0d85bceb3..e0007f242823 100644
--- a/net/batman-adv/main.c
+++ b/net/batman-adv/main.c
@@ -109,7 +109,10 @@ static int __init batadv_init(void)
batadv_debugfs_init();
register_netdevice_notifier(&batadv_hard_if_notifier);
- rtnl_link_register(&batadv_link_ops);
+ ret = rtnl_link_register(&batadv_link_ops);
+ if (ret < 0)
+ return ret;
+
batadv_netlink_register();
pr_info("B.A.T.M.A.N. advanced %s (compatibility version %i) loaded\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
@ 2018-12-24 18:43 ` Sven Eckelmann
0 siblings, 0 replies; 6+ messages in thread
From: Sven Eckelmann @ 2018-12-24 18:43 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: Aditya Pakki, Marek Lindner, kjlu, Antonio Quartulli,
linux-kernel, netdev, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 69c0d85bceb3..e0007f242823 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -109,7 +109,10 @@ static int __init batadv_init(void)
> batadv_debugfs_init();
>
> register_netdevice_notifier(&batadv_hard_if_notifier);
> - rtnl_link_register(&batadv_link_ops);
> + ret = rtnl_link_register(&batadv_link_ops);
> + if (ret < 0)
> + return ret;
> +
> batadv_netlink_register();
Uhm, but shouldn't the already initialized parts be unregistered/uninitialized
in this case?
Rejecting this patch because this could cause a new bug.
Also "Fixes: " line is missing
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
@ 2018-12-24 18:43 ` Sven Eckelmann
0 siblings, 0 replies; 6+ messages in thread
From: Sven Eckelmann @ 2018-12-24 18:43 UTC (permalink / raw)
To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
Cc: Marek Lindner, netdev-u79uwXL29TY76Z2rM5mHXA, Antonio Quartulli,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Aditya Pakki,
kjlu-OJFnDUYgAso, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 69c0d85bceb3..e0007f242823 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -109,7 +109,10 @@ static int __init batadv_init(void)
> batadv_debugfs_init();
>
> register_netdevice_notifier(&batadv_hard_if_notifier);
> - rtnl_link_register(&batadv_link_ops);
> + ret = rtnl_link_register(&batadv_link_ops);
> + if (ret < 0)
> + return ret;
> +
> batadv_netlink_register();
Uhm, but shouldn't the already initialized parts be unregistered/uninitialized
in this case?
Rejecting this patch because this could cause a new bug.
Also "Fixes: " line is missing
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
@ 2018-12-24 18:46 ` Sven Eckelmann
0 siblings, 0 replies; 6+ messages in thread
From: Sven Eckelmann @ 2018-12-24 18:46 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: Aditya Pakki, Marek Lindner, kjlu, Antonio Quartulli,
linux-kernel, netdev, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
> rtnl_link_register() may fail and can impact registering the device.
> The fix checks the return value and pushes the error upstream.
Regarding the commit message - what is "batman-adv/main"? Shouldn't this be
"batman-adv: "?
And the device can still be registered without batadv_link_ops - just not
using rtnl.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register
@ 2018-12-24 18:46 ` Sven Eckelmann
0 siblings, 0 replies; 6+ messages in thread
From: Sven Eckelmann @ 2018-12-24 18:46 UTC (permalink / raw)
To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
Cc: Marek Lindner, netdev-u79uwXL29TY76Z2rM5mHXA, Antonio Quartulli,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Aditya Pakki,
kjlu-OJFnDUYgAso, David S. Miller
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
On Monday, 24 December 2018 18.49.26 CET Aditya Pakki wrote:
> rtnl_link_register() may fail and can impact registering the device.
> The fix checks the return value and pushes the error upstream.
Regarding the commit message - what is "batman-adv/main"? Shouldn't this be
"batman-adv: "?
And the device can still be registered without batadv_link_ops - just not
using rtnl.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-24 18:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-24 17:49 [B.A.T.M.A.N.] [PATCH] batman-adv/main: Fix check on return value of rtnl_link_register Aditya Pakki
2018-12-24 17:49 ` Aditya Pakki
2018-12-24 18:43 ` [B.A.T.M.A.N.] " Sven Eckelmann
2018-12-24 18:43 ` Sven Eckelmann
2018-12-24 18:46 ` [B.A.T.M.A.N.] " Sven Eckelmann
2018-12-24 18:46 ` Sven Eckelmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.