All of lore.kernel.org
 help / color / mirror / Atom feed
* Daily Xen Builds
@ 2006-08-30 15:58 David F Barrera
  2006-08-30 16:31 ` [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c Harry Butterworth
  0 siblings, 1 reply; 5+ messages in thread
From: David F Barrera @ 2006-08-30 15:58 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

August 30, 2006, using xen-unstable changeset:

changeset:   11288:a47951e59cbf
tag:         tip
user:        Ewan Mellor <ewan@xensource.com>
date:        Wed Aug 30 03:47:24 2006 +0100
summary:     Shadow memory should be in MiB, not KiB.  It also needs rounding up to be safe.

ISSUES:
* Bugzilla Bug 725 xm-test - FAIL: 11_create_concurrent_pos.test -- Console run-away (exceeded 131072 bytes)


x86_32 (no PAE support)

* SLES 9 SP2 on IBM xSeries 335, and 235
* Builds and boots without problems
* Able to create fully functional guest domains
* Ran xm-test on all boxes

x86_32 (PAE)

* FC4 on x335, RHEL 4 on IBM HS20 Blade
* Builds and boots without problems
* Able to create fully functional guest domains

ISSUES:

x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)

Unable to start xen on this machine. Build log shows:

/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemu] Error 2
make: *** [all] Error 2
...
make[3]: *** [vnc.o] Error 1
make[2]: *** [subdir-i386-dm] Error 2
make[1]: *** [ioemuinstall] Error 2
make: *** [install] Error 2"


XM-TEST results summary:  
            Platform | PASS | FAIL | XPASS | XFAIL |
---------------------+------+------+-------+-------+
          x235-sles9 |  105 |    4 |     0 |     3 |
         x335fc4-PAE |  107 |    4 |     0 |     3 |
           x335sles9 |  107 |    4 |     0 |     3 |


-- 

Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
	
                          Euripides


[-- Attachment #2: x335fc4-PAE.report --]
[-- Type: text/plain, Size: 378 bytes --]

Xm-test execution summary:
  PASS:  107
  FAIL:  4
  XPASS: 0
  XFAIL: 3


Details:

 FAIL: 11_create_concurrent_pos 
	Unknown reason

XFAIL: 02_network_local_ping_pos 
	 ping loopback failed for size 65507. ping eth0 failed for size 65507.

XFAIL: 05_network_dom0_ping_pos 
	 Ping to dom0 failed for size 65507.

XFAIL: 11_network_domU_ping_pos 
	 Ping failed for size 65507.


[-- Attachment #3: x335sles9.report --]
[-- Type: text/plain, Size: 378 bytes --]

Xm-test execution summary:
  PASS:  107
  FAIL:  4
  XPASS: 0
  XFAIL: 3


Details:

 FAIL: 11_create_concurrent_pos 
	Unknown reason

XFAIL: 02_network_local_ping_pos 
	 ping loopback failed for size 65507. ping eth0 failed for size 65507.

XFAIL: 05_network_dom0_ping_pos 
	 Ping to dom0 failed for size 65507.

XFAIL: 11_network_domU_ping_pos 
	 Ping failed for size 65507.


[-- Attachment #4: x235-sles9.report --]
[-- Type: text/plain, Size: 378 bytes --]

Xm-test execution summary:
  PASS:  105
  FAIL:  4
  XPASS: 0
  XFAIL: 3


Details:

 FAIL: 11_create_concurrent_pos 
	Unknown reason

XFAIL: 02_network_local_ping_pos 
	 ping loopback failed for size 65507. ping eth0 failed for size 65507.

XFAIL: 05_network_dom0_ping_pos 
	 Ping to dom0 failed for size 65507.

XFAIL: 11_network_domU_ping_pos 
	 Ping failed for size 65507.


[-- Attachment #5: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
  2006-08-30 15:58 Daily Xen Builds David F Barrera
@ 2006-08-30 16:31 ` Harry Butterworth
  2006-08-30 18:20   ` David F Barrera
  2006-09-08 16:01   ` Harry Butterworth
  0 siblings, 2 replies; 5+ messages in thread
From: Harry Butterworth @ 2006-08-30 16:31 UTC (permalink / raw)
  To: David F Barrera; +Cc: xen-devel

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Wed, 2006-08-30 at 10:58 -0500, David F Barrera wrote:
> August 30, 2006, using xen-unstable changeset:
> 
> changeset:   11288:a47951e59cbf

> ISSUES:
> 
> x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
> 
> Unable to start xen on this machine. Build log shows:
> 
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call
> make[3]: *** [vnc.o] Error 1
> make[2]: *** [subdir-i386-dm] Error 2
> make[1]: *** [ioemu] Error 2
> make: *** [all] Error 2
> ...
> make[3]: *** [vnc.o] Error 1
> make[2]: *** [subdir-i386-dm] Error 2
> make[1]: *** [ioemuinstall] Error 2
> make: *** [install] Error 2"

This patch should fix your problem here.  I have not tested it.  Please
give it a go and report whether it is OK to be committed to the tree.

The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
sentinel needs to be a 64 bit null pointer for the code to be correct.

Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com>

[-- Attachment #2: sentinel.patch --]
[-- Type: text/x-patch, Size: 369 bytes --]

diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
--- a/tools/ioemu/vnc.c	Wed Aug 30 10:05:00 2006
+++ b/tools/ioemu/vnc.c	Wed Aug 30 16:23:38 2006
@@ -1269,7 +1269,7 @@
 	exit(1);
 
     case 0:	/* child */
-	execlp("vncviewer", "vncviewer", s, 0);
+	execlp("vncviewer", "vncviewer", s, (char *)NULL);
 	fprintf(stderr, "vncviewer execlp failed\n");
 	exit(1);
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
  2006-08-30 16:31 ` [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c Harry Butterworth
@ 2006-08-30 18:20   ` David F Barrera
  2006-08-31 13:14     ` Harry Butterworth
  2006-09-08 16:01   ` Harry Butterworth
  1 sibling, 1 reply; 5+ messages in thread
From: David F Barrera @ 2006-08-30 18:20 UTC (permalink / raw)
  To: Harry Butterworth; +Cc: xen-devel

Harry Butterworth wrote:
> This patch should fix your problem here.  I have not tested it.  Please
> give it a go and report whether it is OK to be committed to the tree.
>
> The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
> sentinel needs to be a 64 bit null pointer for the code to be correct.
>
> Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com>
>   
> ------------------------------------------------------------------------
>
> diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
> --- a/tools/ioemu/vnc.c	Wed Aug 30 10:05:00 2006
> +++ b/tools/ioemu/vnc.c	Wed Aug 30 16:23:38 2006
> @@ -1269,7 +1269,7 @@
>  	exit(1);
>  
>      case 0:	/* child */
> -	execlp("vncviewer", "vncviewer", s, 0);
> +	execlp("vncviewer", "vncviewer", s, (char *)NULL);
>  	fprintf(stderr, "vncviewer execlp failed\n");
>  	exit(1);
>  
>   
Here's the tail end of what I get:

...
XK_Control_Lâ undeclared (first use in this function)
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847: 
error: âXK_Alt_Lâ undeclared (first use in this function)
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: 
error: âXK_1â undeclared (first use in this function)
/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: 
error: âXK_9â undeclared (first use in this function)
make[4]: *** [vnc.o] Error 1
make[4]: Leaving directory 
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'
make[3]: *** [subdir-i386-dm] Error 2
make[3]: Leaving directory 
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'
make[2]: *** [ioemuinstall] Error 2
make[2]: Leaving directory 
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make[1]: *** [install] Error 2
make[1]: Leaving directory 
`/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
make: *** [install-tools] Error 2


-- 

Regards,

David F Barrera
Linux Technology Center
Systems and Technology Group, IBM

"The wisest men follow their own direction. "
	
                          Euripides

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
  2006-08-30 18:20   ` David F Barrera
@ 2006-08-31 13:14     ` Harry Butterworth
  0 siblings, 0 replies; 5+ messages in thread
From: Harry Butterworth @ 2006-08-31 13:14 UTC (permalink / raw)
  To: David F Barrera; +Cc: xen-devel

On Wed, 2006-08-30 at 13:20 -0500, David F Barrera wrote:
> Harry Butterworth wrote:
> > This patch should fix your problem here.  I have not tested it.  Please
> > give it a go and report whether it is OK to be committed to the tree.
> >
> > The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
> > sentinel needs to be a 64 bit null pointer for the code to be correct.
> >
> > Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com>
> >   
> > ------------------------------------------------------------------------
> >
> > diff -r dc773bf49664 -r 606ec67fb063 tools/ioemu/vnc.c
> > --- a/tools/ioemu/vnc.c	Wed Aug 30 10:05:00 2006
> > +++ b/tools/ioemu/vnc.c	Wed Aug 30 16:23:38 2006
> > @@ -1269,7 +1269,7 @@
> >  	exit(1);
> >  
> >      case 0:	/* child */
> > -	execlp("vncviewer", "vncviewer", s, 0);
> > +	execlp("vncviewer", "vncviewer", s, (char *)NULL);
> >  	fprintf(stderr, "vncviewer execlp failed\n");
> >  	exit(1);
> >  
> >   
> Here's the tail end of what I get:
> 
> ...
> XK_Control_Lâ undeclared (first use in this function)
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:847: 
> error: âXK_Alt_Lâ undeclared (first use in this function)
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: 
> error: âXK_1â undeclared (first use in this function)
> /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:864: 
> error: âXK_9â undeclared (first use in this function)
> make[4]: *** [vnc.o] Error 1
> make[4]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/i386-dm'
> make[3]: *** [subdir-i386-dm] Error 2
> make[3]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu'
> make[2]: *** [ioemuinstall] Error 2
> make[2]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
> make[1]: *** [install] Error 2
> make[1]: Leaving directory 
> `/usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools'
> make: *** [install-tools] Error 2

Well, my patch seems to have fixed your previous compile error so I
think it is good.  The errors above are unrelated to the patch.

The errors above indicate that the symbols XK_Alt_L XK_1 and XK_9 are
undefined.  (I don't understand where the weird 'â' characters are
coming from in the error report above).

These symbols should be defined in /usr/include/X11/keysymdef.h which is
included by vnc.c.

Please check that you have this header file installed on your build
machine and that the symbols are defined in it.

Harry.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c
  2006-08-30 16:31 ` [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c Harry Butterworth
  2006-08-30 18:20   ` David F Barrera
@ 2006-09-08 16:01   ` Harry Butterworth
  1 sibling, 0 replies; 5+ messages in thread
From: Harry Butterworth @ 2006-09-08 16:01 UTC (permalink / raw)
  To: chris; +Cc: David F Barrera, xen-devel

The following code in vnc.c needs to change.  I'm not sure if the patch
below is the way to change it or if it should be changed in
tools/ioemu/patches/vnc-start-vncviewer or in both places.

Why is the code checked in in two places?

It's trivial, please commit a fix or explain exactly what is required
and I'll re-spin the patch.

Harry.

On Wed, 2006-08-30 at 17:31 +0100, Harry Butterworth wrote:
> On Wed, 2006-08-30 at 10:58 -0500, David F Barrera wrote:
> > August 30, 2006, using xen-unstable changeset:
> > 
> > changeset:   11288:a47951e59cbf
> 
> > ISSUES:
> > 
> > x86_64 **BLOCKED (SLES 10 on IBM HS20 Blade 8843)
> > 
> > Unable to start xen on this machine. Build log shows:
> > 
> > /usr/local/autobench/var/tmp/xen/xen-unstable.hg/tools/ioemu/vnc.c:1272: warning: missing sentinel in function call
> > make[3]: *** [vnc.o] Error 1
> > make[2]: *** [subdir-i386-dm] Error 2
> > make[1]: *** [ioemu] Error 2
> > make: *** [all] Error 2
> > ...
> > make[3]: *** [vnc.o] Error 1
> > make[2]: *** [subdir-i386-dm] Error 2
> > make[1]: *** [ioemuinstall] Error 2
> > make: *** [install] Error 2"
> 
> This patch should fix your problem here.  I have not tested it.  Please
> give it a go and report whether it is OK to be committed to the tree.
> 
> The issue is that 0 on a 64 bit machine is a 32 bit integer whereas the
> sentinel needs to be a 64 bit null pointer for the code to be correct.
> 
> Signed-off-by: Harry Butterworth <butterwo@uk.ibm.com>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-09-08 16:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-30 15:58 Daily Xen Builds David F Barrera
2006-08-30 16:31 ` [PATCH] [UNTESTED] Fix sentinel in call to execlp in tools/iommu/vnc.c Harry Butterworth
2006-08-30 18:20   ` David F Barrera
2006-08-31 13:14     ` Harry Butterworth
2006-09-08 16:01   ` Harry Butterworth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.