* hvm_decode() questions
@ 2006-11-24 14:03 Jan Beulich
2006-11-24 14:08 ` Keir Fraser
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2006-11-24 14:03 UTC (permalink / raw)
To: xen-devel
1) single-byte opcode 0x87 (xchg): What is this strange conditional
if ( ((*(opcode+1)) & 0xc7) == 5 )
supposed to address? xchg has absolutely symmetric operands.
2) two-byte opcode 0xB7 (movzx): What is this dependency on rex
bit 3 doing here? Apparently this was based on Intel's (broken)
documentation - the source operand is always 16 bits.
Unless someone can explain these, I'll send a patch to remove them.
Jan
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: hvm_decode() questions
@ 2006-11-24 14:07 Li, Xin B
0 siblings, 0 replies; 3+ messages in thread
From: Li, Xin B @ 2006-11-24 14:07 UTC (permalink / raw)
To: Jan Beulich, xen-devel
>1) single-byte opcode 0x87 (xchg): What is this strange conditional
>
> if ( ((*(opcode+1)) & 0xc7) == 5 )
>
>supposed to address? xchg has absolutely symmetric operands.
>
>2) two-byte opcode 0xB7 (movzx): What is this dependency on rex
>bit 3 doing here? Apparently this was based on Intel's (broken)
>documentation - the source operand is always 16 bits.
>
>Unless someone can explain these, I'll send a patch to remove them.
I agree that hvm_decode needs a careful review.
-Xin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: hvm_decode() questions
2006-11-24 14:03 hvm_decode() questions Jan Beulich
@ 2006-11-24 14:08 ` Keir Fraser
0 siblings, 0 replies; 3+ messages in thread
From: Keir Fraser @ 2006-11-24 14:08 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 24/11/06 14:03, "Jan Beulich" <jbeulich@novell.com> wrote:
> 1) single-byte opcode 0x87 (xchg): What is this strange conditional
>
> if ( ((*(opcode+1)) & 0xc7) == 5 )
>
> supposed to address? xchg has absolutely symmetric operands.
>
> 2) two-byte opcode 0xB7 (movzx): What is this dependency on rex
> bit 3 doing here? Apparently this was based on Intel's (broken)
> documentation - the source operand is always 16 bits.
>
> Unless someone can explain these, I'll send a patch to remove them.
Yes, these can both be removed.
-- Keir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-24 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-24 14:03 hvm_decode() questions Jan Beulich
2006-11-24 14:08 ` Keir Fraser
-- strict thread matches above, loose matches on Subject: below --
2006-11-24 14:07 Li, Xin B
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.