All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] romsignature/checksum cleanup
Date: Mon, 25 Dec 2006 01:53:15 +0100	[thread overview]
Message-ID: <458F20FB.7040900@gmail.com> (raw)
In-Reply-To: <458EEDF7.4000200@gmail.com>

Rene Herman wrote:

> Use adding __init to romsignature() (it's only called from probe_roms() 
> which is itself __init) as an excuse to submit a pedantic cleanup.

Hmm, by the way, if romsignature() needs this probe_kernel_address() 
thing, why doesn't romchecksum()?

(Rusty in CC as author of bd472c794bbf6771c3fc1c58f188bc16c393d2fe)

Rene.

  reply	other threads:[~2006-12-25  1:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-24 21:15 [PATCH] romsignature/checksum cleanup Rene Herman
2006-12-25  0:53 ` Rene Herman [this message]
2006-12-27  0:31   ` Rusty Russell
2006-12-27  0:45     ` Rene Herman
2006-12-28  0:32     ` Zachary Amsden
2007-01-02 20:01       ` Rene Herman
2007-01-05 23:22         ` Jeremy Fitzhardinge
2007-01-06  3:46           ` Rene Herman
2007-01-07  8:59             ` Jeremy Fitzhardinge
2007-01-07  9:02               ` Rene Herman
2007-01-07 10:20                 ` Jeremy Fitzhardinge
2007-01-07 10:47                   ` Rene Herman
2007-01-07 18:07                     ` Jeremy Fitzhardinge
2007-01-08  2:48                       ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=458F20FB.7040900@gmail.com \
    --to=rene.herman@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.