From: Rene Herman <rene.herman@gmail.com>
To: Zachary Amsden <zach@vmware.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] romsignature/checksum cleanup
Date: Tue, 02 Jan 2007 21:01:51 +0100 [thread overview]
Message-ID: <459ABA2F.6070907@gmail.com> (raw)
In-Reply-To: <459310A3.4060706@vmware.com>
Zachary Amsden wrote:
>> Rusty Russell wrote:
>>
>>> Rene Herman wrote:
>>>
>>> Hmm, by the way, if romsignature() needs this
>>> probe_kernel_address() thing, why doesn't romchecksum()?
>>
>> I assume it's all in the same page, but CC'ing Zach is easier than
>> reading the code 8)
>>
>
> Some hypervisors don't emulate the traditional physical layout of the
> first 1M of memory, so those pages might never get physical mappings
> established during the boot process, causing access to them to
> fault. Presumably, if the first page is there with a good signature,
> the entire ROM is mapped. I think Jeremy added this for Xen, and
> it's harmless on native hardware.
Jeremy? Is it okay to only check the signature word? The checksum will
generally be done over more than 1 (hw) page... That "presumably" there
seems a bit flaky?
Rene.
next prev parent reply other threads:[~2007-01-02 20:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-24 21:15 [PATCH] romsignature/checksum cleanup Rene Herman
2006-12-25 0:53 ` Rene Herman
2006-12-27 0:31 ` Rusty Russell
2006-12-27 0:45 ` Rene Herman
2006-12-28 0:32 ` Zachary Amsden
2007-01-02 20:01 ` Rene Herman [this message]
2007-01-05 23:22 ` Jeremy Fitzhardinge
2007-01-06 3:46 ` Rene Herman
2007-01-07 8:59 ` Jeremy Fitzhardinge
2007-01-07 9:02 ` Rene Herman
2007-01-07 10:20 ` Jeremy Fitzhardinge
2007-01-07 10:47 ` Rene Herman
2007-01-07 18:07 ` Jeremy Fitzhardinge
2007-01-08 2:48 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459ABA2F.6070907@gmail.com \
--to=rene.herman@gmail.com \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.