From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Rene Herman <rene.herman@gmail.com>
Cc: Zachary Amsden <zach@vmware.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] romsignature/checksum cleanup
Date: Sun, 07 Jan 2007 02:20:39 -0800 [thread overview]
Message-ID: <45A0C977.4070800@goop.org> (raw)
In-Reply-To: <45A0B71F.1080704@gmail.com>
Rene Herman wrote:
> How is it for efficiency? I thought it was for correctness.
> romsignature is using probe_kernel_adress() while all other accesses
> to the ROMs there aren't.
>
> If nothing else, anyone reading that code is likely to ask himself the
> very same question -- why the one, and not the others.
Well, I was wondering about all the uses of __get_user; why not
probe_kernel_address() everywhere?
I think its reasonable to assume that if the signature is mapped and
correct, then everything else is mapped. That's certainly the case for
Xen, which is why I added it. If you think this is unclear, then I
think a comment to explain this rather than code changes is the
appropriate fix.
J
next prev parent reply other threads:[~2007-01-07 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-24 21:15 [PATCH] romsignature/checksum cleanup Rene Herman
2006-12-25 0:53 ` Rene Herman
2006-12-27 0:31 ` Rusty Russell
2006-12-27 0:45 ` Rene Herman
2006-12-28 0:32 ` Zachary Amsden
2007-01-02 20:01 ` Rene Herman
2007-01-05 23:22 ` Jeremy Fitzhardinge
2007-01-06 3:46 ` Rene Herman
2007-01-07 8:59 ` Jeremy Fitzhardinge
2007-01-07 9:02 ` Rene Herman
2007-01-07 10:20 ` Jeremy Fitzhardinge [this message]
2007-01-07 10:47 ` Rene Herman
2007-01-07 18:07 ` Jeremy Fitzhardinge
2007-01-08 2:48 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A0C977.4070800@goop.org \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.