All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Rene Herman <rene.herman@gmail.com>,
	Andrew Morton <akpm@osdl.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] romsignature/checksum cleanup
Date: Wed, 27 Dec 2006 16:32:35 -0800	[thread overview]
Message-ID: <459310A3.4060706@vmware.com> (raw)
In-Reply-To: <1167179512.16175.4.camel@localhost.localdomain>

Rusty Russell wrote:
> On Mon, 2006-12-25 at 01:53 +0100, Rene Herman wrote:
>   
>> Rene Herman wrote:
>>
>>     
>>> Use adding __init to romsignature() (it's only called from probe_roms() 
>>> which is itself __init) as an excuse to submit a pedantic cleanup.
>>>       
>> Hmm, by the way, if romsignature() needs this probe_kernel_address() 
>> thing, why doesn't romchecksum()?
>>     
>
> I assume it's all in the same page, but CC'ing Zach is easier than
> reading the code 8)
>   

Some hypervisors don't emulate the traditional physical layout of the 
first 1M of memory, so those pages might never get physical mappings 
established during the boot process, causing access to them to fault.  
Presumably, if the first page is there with a good signature, the entire 
ROM is mapped.  I think Jeremy added this for Xen, and it's harmless on 
native hardware.

Zach

  parent reply	other threads:[~2006-12-28  0:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-24 21:15 [PATCH] romsignature/checksum cleanup Rene Herman
2006-12-25  0:53 ` Rene Herman
2006-12-27  0:31   ` Rusty Russell
2006-12-27  0:45     ` Rene Herman
2006-12-28  0:32     ` Zachary Amsden [this message]
2007-01-02 20:01       ` Rene Herman
2007-01-05 23:22         ` Jeremy Fitzhardinge
2007-01-06  3:46           ` Rene Herman
2007-01-07  8:59             ` Jeremy Fitzhardinge
2007-01-07  9:02               ` Rene Herman
2007-01-07 10:20                 ` Jeremy Fitzhardinge
2007-01-07 10:47                   ` Rene Herman
2007-01-07 18:07                     ` Jeremy Fitzhardinge
2007-01-08  2:48                       ` Rene Herman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=459310A3.4060706@vmware.com \
    --to=zach@vmware.com \
    --cc=akpm@osdl.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@gmail.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.