[Adeos-main] 2.6.23 x86_64 broken for SMP ?

[Adeos-main] 2.6.23 x86_64 broken for SMP ?

[Paul]

Attempting to compile on x86_64 with SMP enabled, getting quite a few failures 
cetered around ipipe_declare_cpuid being undeclared in 
arch/x86_64/kernel/ipipe.c. Should we be including ipipe_compat.h or 
following the lead set in arch/i386/kernel/ipipe.c ?


Regards, Paul.

Re: [Adeos-main] 2.6.23 x86_64 broken for SMP ?

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

Paul wrote:
> Attempting to compile on x86_64 with SMP enabled, getting quite a few failures 
> cetered around ipipe_declare_cpuid being undeclared in 
> arch/x86_64/kernel/ipipe.c. Should we be including ipipe_compat.h or 
> following the lead set in arch/i386/kernel/ipipe.c ?

Nope, we should rather remove the obsolete code from the ipipe core. You
could simply kill ipipe_declare_cpuid and replace the cpuid spots with
ipipe_processor_id() (compare to latest i386 ipipe). Cleanup patches
always welcome!

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]

Re: [Adeos-main] 2.6.23 x86_64 broken for SMP ?

[Philippe Gerum]

On Thu, 2007-10-18 at 21:16 +0100, Paul wrote:
> Attempting to compile on x86_64 with SMP enabled, getting quite a few failures 
> cetered around ipipe_declare_cpuid being undeclared in 
> arch/x86_64/kernel/ipipe.c.

It seems I forgot to compile with IPIPE_COMPAT off before releasing...
Sorry for that. This one should be ok:

http://download.gna.org/adeos/patches/v2.6/x86_64/adeos-ipipe-2.6.23-x86_64-1.2-05.patch

> Should we be including ipipe_compat.h or 
> following the lead set in arch/i386/kernel/ipipe.c ?
> 

We really want to get rid of the ipipe_get/lock_cpu constructs, so i386
should be followed.

> 
> Regards, Paul.
> 
> _______________________________________________
> Adeos-main mailing list
> Adeos-main@domain.hid
> https://mail.gna.org/listinfo/adeos-main
-- 
Philippe.