All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: John Stoffel <john@stoffel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig
Date: Wed, 20 Feb 2008 20:50:52 +0530	[thread overview]
Message-ID: <47BC4554.10304@linux.vnet.ibm.com> (raw)
In-Reply-To: <18364.16552.455371.242369@stoffel.org>

John Stoffel wrote:
> I know this is a pedantic comment, but why the heck is it called such
> a generic term as "Memory Controller" which doesn't give any
> indication of what it does.
> 
> Shouldn't it be something like "Memory Quota Controller", or "Memory
> Limits Controller"?
> 

It's called the memory controller since it controls the amount of memory that a
user can allocate (via limits). The generic term for any resource manager
plugged into cgroups is a controller. If you look through some of the references
in the document, we've listed our plans to support other categories of memory as
well. Hence it's called a memory controller

> Also, the Kconfig name "CGROUP_MEM_CONT" is just wrong, it should be
> "CGROUP_MEM_CONTROLLER", just spell it out so it's clear what's up.
> 

This has some history as well. Control groups was called containers earlier.
That way a name like CGROUP_MEM_CONT could stand for cgroup memory container or
cgroup memory controller.

> It took me a bunch of reading of Documentation/controllers/memory.txt
> to even start to understand what the purpose of this was.  The
> document could also use a re-writing to include a clear introduction
> at the top to explain "what" a memory controller is.  
> 
> Something which talks about limits, resource management, quotas, etc
> would be nice.  
> 


The references, specially reference [1] contains a lot of details on limits,
guarantees, etc.  Since they've been documented in the past on lkml, I decided
to keep them out of the documentation and mention them as references. If it's
going to help to add that terminology; I can create another document describing
what resource management means and what the commonly used terms mean.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: John Stoffel <john@stoffel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig
Date: Wed, 20 Feb 2008 20:50:52 +0530	[thread overview]
Message-ID: <47BC4554.10304@linux.vnet.ibm.com> (raw)
In-Reply-To: <18364.16552.455371.242369@stoffel.org>

John Stoffel wrote:
> I know this is a pedantic comment, but why the heck is it called such
> a generic term as "Memory Controller" which doesn't give any
> indication of what it does.
> 
> Shouldn't it be something like "Memory Quota Controller", or "Memory
> Limits Controller"?
> 

It's called the memory controller since it controls the amount of memory that a
user can allocate (via limits). The generic term for any resource manager
plugged into cgroups is a controller. If you look through some of the references
in the document, we've listed our plans to support other categories of memory as
well. Hence it's called a memory controller

> Also, the Kconfig name "CGROUP_MEM_CONT" is just wrong, it should be
> "CGROUP_MEM_CONTROLLER", just spell it out so it's clear what's up.
> 

This has some history as well. Control groups was called containers earlier.
That way a name like CGROUP_MEM_CONT could stand for cgroup memory container or
cgroup memory controller.

> It took me a bunch of reading of Documentation/controllers/memory.txt
> to even start to understand what the purpose of this was.  The
> document could also use a re-writing to include a clear introduction
> at the top to explain "what" a memory controller is.  
> 
> Something which talks about limits, resource management, quotas, etc
> would be nice.  
> 


The references, specially reference [1] contains a lot of details on limits,
guarantees, etc.  Since they've been documented in the past on lkml, I decided
to keep them out of the documentation and mention them as references. If it's
going to help to add that terminology; I can create another document describing
what resource management means and what the commonly used terms mean.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-02-20 15:30 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-20 12:23 [PATCH] Document huge memory/cache overhead of memory controller in Kconfig Andi Kleen
2008-02-20 12:23 ` Andi Kleen
2008-02-20 12:52 ` Balbir Singh
2008-02-20 12:52   ` Balbir Singh
2008-02-20 15:00   ` John Stoffel
2008-02-20 15:00     ` John Stoffel
2008-02-20 15:20     ` Balbir Singh [this message]
2008-02-20 15:20       ` Balbir Singh
2008-02-20 15:49       ` Jan Engelhardt
2008-02-20 15:49         ` Jan Engelhardt
2008-02-20 16:10         ` John Stoffel
2008-02-20 16:10           ` John Stoffel
2008-02-20 16:15           ` Balbir Singh
2008-02-20 16:15             ` Balbir Singh
2008-02-20 17:00             ` Andi Kleen
2008-02-20 17:00               ` Andi Kleen
2008-02-21  6:49             ` KAMEZAWA Hiroyuki
2008-02-21  6:49               ` KAMEZAWA Hiroyuki
2008-02-21  6:52               ` Balbir Singh
2008-02-21  6:52                 ` Balbir Singh
2008-02-20 18:19         ` Pavel Machek
2008-02-20 18:19           ` Pavel Machek
2008-02-20 18:28           ` Jan Engelhardt
2008-02-20 18:28             ` Jan Engelhardt
2008-02-20 18:51             ` Pavel Machek
2008-02-20 18:51               ` Pavel Machek
2008-02-21 14:46               ` KOSAKI Motohiro
2008-02-21 14:46                 ` KOSAKI Motohiro
2008-02-21 14:52                 ` Balbir Singh
2008-02-21 14:52                   ` Balbir Singh
2008-02-21 23:55                 ` Pavel Machek
2008-02-21 23:55                   ` Pavel Machek
2008-02-22  3:09                   ` KOSAKI Motohiro
2008-02-22  3:09                     ` KOSAKI Motohiro
2008-02-20 16:15       ` John Stoffel
2008-02-20 16:15         ` John Stoffel
2008-02-20 16:54       ` Ray Lee
2008-02-20 16:54         ` Ray Lee
2008-02-20 16:57     ` Andi Kleen
2008-02-20 16:57       ` Andi Kleen
2008-02-21  4:35   ` Nick Piggin
2008-02-21  4:35     ` Nick Piggin
2008-02-21  5:06     ` Balbir Singh
2008-02-21  5:06       ` Balbir Singh
     [not found]       ` <200802211622.51751.nickpiggin@yahoo.com.au>
2008-02-21  5:46         ` Balbir Singh
2008-02-21  5:46           ` Balbir Singh
2008-02-21 10:44       ` Andi Kleen
2008-02-21 10:44         ` Andi Kleen
2008-02-22  4:41         ` Balbir Singh
2008-02-22  4:41           ` Balbir Singh
2008-02-22  9:51           ` Andi Kleen
2008-02-22  9:51             ` Andi Kleen
2008-02-22 12:14             ` Balbir Singh
2008-02-22 12:14               ` Balbir Singh
2008-02-22 13:00               ` Andi Kleen
2008-02-22 13:00                 ` Andi Kleen
2008-02-22 15:47                 ` Balbir Singh
2008-02-22 15:47                   ` Balbir Singh
2008-02-21 10:37     ` Andi Kleen
2008-02-21 10:37       ` Andi Kleen
2008-02-21 11:03       ` Balbir Singh
2008-02-21 11:03         ` Balbir Singh
2008-02-22  6:59         ` KAMEZAWA Hiroyuki
2008-02-22  6:59           ` KAMEZAWA Hiroyuki
2008-02-22  7:06           ` Balbir Singh
2008-02-22  7:06             ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47BC4554.10304@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=john@stoffel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.