From: Jeremy Fitzhardinge <jeremy-TSDbQ3PG+2Y@public.gmane.org>
To: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
Cc: Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
npiggin-l3A5Bk7waGM@public.gmane.org,
torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Peter Zijlstra
<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>
Subject: Re: [PATCH 2/11] x86: convert to generic helpers for IPI function calls
Date: Sat, 26 Apr 2008 01:59:55 -0700 [thread overview]
Message-ID: <4812EF0B.4060109@goop.org> (raw)
In-Reply-To: <20080422084738.GB2388-X9Un+BFzKDI@public.gmane.org>
Ingo Molnar wrote:
> * Jens Axboe <jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
>
>
>> This converts x86 and x86-64 to use the new helpers for
>> smp_call_function() and friends, and adds support for
>> smp_call_function_single().
>>
>
> nice stuff. The x86 and generic bits:
>
> Acked-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
>
> this has been brewing for months, what is the testing/confidence status
> of it? Could we still merge it into v2.6.26? (i think we should)
>
I commented on an earlier version of this patch, but it looks like it
will break Xen. If you enable CONFIG_XEN, it will try to define both
native and Xen versions of arch_send_call_function[_single]_ipi(). It
needs to vector them via smp_ops.
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jens Axboe <jens.axboe@oracle.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
npiggin@suse.de, torvalds@linux-foundation.org,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 2/11] x86: convert to generic helpers for IPI function calls
Date: Sat, 26 Apr 2008 01:59:55 -0700 [thread overview]
Message-ID: <4812EF0B.4060109@goop.org> (raw)
Message-ID: <20080426085955.171y9GFZRuOer3oHpEWjzTlvDNvM9ioVt2Ujrdq6hHg@z> (raw)
In-Reply-To: <20080422084738.GB2388@elte.hu>
Ingo Molnar wrote:
> * Jens Axboe <jens.axboe@oracle.com> wrote:
>
>
>> This converts x86 and x86-64 to use the new helpers for
>> smp_call_function() and friends, and adds support for
>> smp_call_function_single().
>>
>
> nice stuff. The x86 and generic bits:
>
> Acked-by: Ingo Molnar <mingo@elte.hu>
>
> this has been brewing for months, what is the testing/confidence status
> of it? Could we still merge it into v2.6.26? (i think we should)
>
I commented on an earlier version of this patch, but it looks like it
will break Xen. If you enable CONFIG_XEN, it will try to define both
native and Xen versions of arch_send_call_function[_single]_ipi(). It
needs to vector them via smp_ops.
J
next prev parent reply other threads:[~2008-04-26 8:59 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 7:57 [PATCH 0/11] Generic smp_call_function() and friends Jens Axboe
2008-04-22 7:57 ` Jens Axboe
[not found] ` <1208851058-8500-1-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 7:57 ` [PATCH 1/11] Add generic helpers for arch IPI function calls Jens Axboe
2008-04-22 7:57 ` Jens Axboe
[not found] ` <1208851058-8500-2-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 9:16 ` Avi Kivity
2008-04-22 9:16 ` Avi Kivity
[not found] ` <480DACDD.7040108-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-04-22 9:22 ` Jens Axboe
2008-04-22 9:22 ` Jens Axboe
[not found] ` <20080422092230.GW12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 11:14 ` Jens Axboe
2008-04-22 11:14 ` Jens Axboe
2008-04-22 13:00 ` Peter Zijlstra
2008-04-22 14:25 ` Jens Axboe
2008-04-22 14:25 ` Jens Axboe
[not found] ` <20080422142543.GG12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 14:38 ` Avi Kivity
2008-04-22 14:38 ` Avi Kivity
[not found] ` <480DF861.6000705-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2008-04-22 14:43 ` Peter Zijlstra
2008-04-22 14:43 ` Peter Zijlstra
2008-04-22 14:47 ` Avi Kivity
2008-04-22 14:47 ` Avi Kivity
2008-04-22 14:53 ` Jens Axboe
2008-04-22 14:43 ` Linus Torvalds
2008-04-22 14:43 ` Linus Torvalds
[not found] ` <alpine.LFD.1.10.0804220735350.2779-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-22 14:51 ` Jens Axboe
2008-04-22 14:51 ` Jens Axboe
2008-04-22 15:01 ` Linus Torvalds
2008-04-22 16:49 ` Jens Axboe
2008-04-22 16:49 ` Jens Axboe
[not found] ` <20080422164947.GN12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 17:04 ` Jens Axboe
2008-04-22 17:04 ` Jens Axboe
[not found] ` <20080422170405.GO12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 17:13 ` Jens Axboe
2008-04-22 17:13 ` Jens Axboe
[not found] ` <20080422171324.GP12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 17:29 ` Linus Torvalds
2008-04-22 17:29 ` Linus Torvalds
[not found] ` <alpine.LFD.1.10.0804221027210.2779-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-22 18:23 ` Jens Axboe
2008-04-22 18:23 ` Jens Axboe
2008-04-22 18:23 ` Jens Axboe
[not found] ` <20080422182337.GQ12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 18:39 ` Linus Torvalds
2008-04-22 18:39 ` Linus Torvalds
2008-04-22 14:58 ` Linus Torvalds
2008-04-22 14:58 ` Linus Torvalds
[not found] ` <alpine.LFD.1.10.0804220749450.2779-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-22 15:07 ` Jens Axboe
2008-04-22 15:07 ` Jens Axboe
2008-04-22 23:12 ` Mark Lord
2008-04-22 23:12 ` Mark Lord
[not found] ` <480E70ED.3030701-gsilrlXbHYg@public.gmane.org>
2008-04-23 7:24 ` Jens Axboe
2008-04-23 7:24 ` Jens Axboe
[not found] ` <20080423072432.GX12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-23 13:42 ` Mark Lord
2008-04-23 13:42 ` Mark Lord
[not found] ` <480F3CBC.60305-gsilrlXbHYg@public.gmane.org>
2008-04-23 13:51 ` Jens Axboe
2008-04-23 13:51 ` Jens Axboe
2008-04-23 14:46 ` Mark Lord
[not found] ` <480F4BD9.8090003-gsilrlXbHYg@public.gmane.org>
2008-04-24 10:59 ` Jens Axboe
2008-04-24 10:59 ` Jens Axboe
[not found] ` <20080424105908.GW12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-24 12:44 ` Mark Lord
2008-04-24 12:44 ` Mark Lord
[not found] ` <481080A0.9050804-gsilrlXbHYg@public.gmane.org>
2008-04-24 21:30 ` Rafael J. Wysocki
2008-04-24 21:30 ` Rafael J. Wysocki
2008-04-25 11:08 ` Pavel Machek
2008-04-25 11:08 ` Pavel Machek
2008-04-26 8:04 ` Pavel Machek
2008-04-26 8:04 ` Pavel Machek
2008-04-28 15:13 ` Mark Lord
2008-05-01 16:23 ` Pavel Machek
2008-04-22 7:57 ` [PATCH 2/11] x86: convert to generic helpers for " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
[not found] ` <1208851058-8500-3-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 8:38 ` Sam Ravnborg
2008-04-22 8:38 ` Sam Ravnborg
[not found] ` <20080422083810.GA23540-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2008-04-22 8:43 ` Jens Axboe
2008-04-22 8:43 ` Jens Axboe
[not found] ` <20080422084315.GT12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 11:15 ` Jens Axboe
2008-04-22 11:15 ` Jens Axboe
2008-04-22 8:47 ` Ingo Molnar
2008-04-22 8:47 ` Ingo Molnar
[not found] ` <20080422084738.GB2388-X9Un+BFzKDI@public.gmane.org>
2008-04-22 8:48 ` Jacek Luczak
2008-04-22 8:48 ` Jacek Luczak
[not found] ` <480DA670.4060707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2008-04-22 8:56 ` Jens Axboe
2008-04-22 8:56 ` Jens Axboe
[not found] ` <20080422085629.GV12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 9:04 ` Jacek Luczak
2008-04-22 9:04 ` Jacek Luczak
2008-04-22 8:52 ` Jens Axboe
2008-04-22 8:52 ` Jens Axboe
2008-04-26 8:59 ` Jeremy Fitzhardinge [this message]
2008-04-26 8:59 ` Jeremy Fitzhardinge
2008-04-22 7:57 ` [PATCH 3/11] powerpc: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
[not found] ` <1208851058-8500-4-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 12:03 ` Paul Mackerras
2008-04-22 12:03 ` Paul Mackerras
[not found] ` <18445.54284.194023.553595-UYQwCShxghk5kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
2008-04-22 12:13 ` Jens Axboe
2008-04-22 12:13 ` Jens Axboe
[not found] ` <20080422121315.GE12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 12:42 ` Paul Mackerras
2008-04-22 12:42 ` Paul Mackerras
[not found] ` <18445.56653.957832.720681-UYQwCShxghk5kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
2008-04-22 18:51 ` Jens Axboe
2008-04-22 18:51 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 4/11] ia64: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 5/11] alpha: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 6/11] arm: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 15:00 ` Catalin Marinas
[not found] ` <1208876447.31997.30.camel-hhZApKj8DF/YkXV2EHHjLW3o5bpOHsLO@public.gmane.org>
2008-04-22 18:43 ` Jens Axboe
2008-04-22 18:43 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 7/11] m32r: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 8/11] mips: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 9/11] parisc: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
[not found] ` <1208851058-8500-10-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 14:09 ` Kyle McMartin
2008-04-22 14:09 ` Kyle McMartin
[not found] ` <20080422140914.GD19802-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>
2008-04-22 14:27 ` Jens Axboe
2008-04-22 14:27 ` Jens Axboe
[not found] ` <20080422142738.GH12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-22 14:30 ` Kyle McMartin
2008-04-22 14:30 ` Kyle McMartin
[not found] ` <20080422143016.GE19802-EK4dZfYtfFRW/gs8oUvUg/d9D2ou9A/h@public.gmane.org>
2008-04-22 14:49 ` Jens Axboe
2008-04-22 14:49 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 10/11] sh: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 7:57 ` [PATCH 11/11] s390: " Jens Axboe
2008-04-22 7:57 ` Jens Axboe
[not found] ` <1208851058-8500-12-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 8:04 ` Martin Schwidefsky
2008-04-22 8:04 ` Martin Schwidefsky
2008-04-22 8:07 ` Jens Axboe
2008-04-22 8:07 ` Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 7:57 ` Jens Axboe
2008-04-22 8:48 ` [PATCH 0/11] Generic smp_call_function() and friends Peter Zijlstra
2008-04-22 8:48 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2008-04-22 18:50 [PATCH 0/11] Generic smp_call_function() #2 Jens Axboe
[not found] ` <1208890227-24808-1-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-22 18:50 ` [PATCH 2/11] x86: convert to generic helpers for IPI function calls Jens Axboe
2008-04-22 18:50 ` Jens Axboe
2008-04-22 19:03 ` Linus Torvalds
[not found] ` <alpine.LFD.1.10.0804221157220.2779-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-22 19:12 ` Ingo Molnar
2008-04-22 19:12 ` Ingo Molnar
[not found] ` <20080422191213.GA6370-X9Un+BFzKDI@public.gmane.org>
2008-04-22 19:22 ` Linus Torvalds
2008-04-22 19:22 ` Linus Torvalds
2008-04-22 19:26 ` Ingo Molnar
[not found] ` <20080422192601.GB12588-X9Un+BFzKDI@public.gmane.org>
2008-04-22 19:50 ` Linus Torvalds
2008-04-22 19:50 ` Linus Torvalds
[not found] ` <alpine.LFD.1.10.0804221244350.2779-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-23 1:11 ` Nick Piggin
2008-04-23 1:11 ` Nick Piggin
[not found] ` <20080423011153.GB17572-B4tOwbsTzaBolqkO4TVVkw@public.gmane.org>
2008-04-23 1:22 ` Linus Torvalds
2008-04-23 1:22 ` Linus Torvalds
[not found] ` <alpine.LFD.1.10.0804221817050.2779-5CScLwifNT1QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
2008-04-23 1:36 ` Nick Piggin
2008-04-23 1:36 ` Nick Piggin
2008-04-23 7:08 ` Jens Axboe
2008-04-23 7:08 ` Jens Axboe
2008-04-23 12:54 ` Jens Axboe
2008-04-23 12:54 ` Jens Axboe
[not found] ` <1208890227-24808-3-git-send-email-jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2008-04-26 6:44 ` Jeremy Fitzhardinge
2008-04-26 6:44 ` Jeremy Fitzhardinge
[not found] ` <4812CF5B.4080902-TSDbQ3PG+2Y@public.gmane.org>
2008-04-27 10:23 ` Jens Axboe
2008-04-27 10:23 ` Jens Axboe
[not found] ` <20080427102335.GS12774-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2008-04-27 15:18 ` Jeremy Fitzhardinge
2008-04-27 15:18 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4812EF0B.4060109@goop.org \
--to=jeremy-tsdbq3pg+2y@public.gmane.org \
--cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
--cc=jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=npiggin-l3A5Bk7waGM@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.