Re: [PATCH v3 4/5] tests/intel/xe_exec_reset: Add long-spin-sys-reuse-many-preempt-threads

["Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>]

On 9/23/2025 11:13 PM, Matthew Brost wrote:
> Add long-spin-sys-reuse-many-preempt-threads which verifies system
> memory can be used during this test. Useful to test VF migration.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>   lib/xe/xe_legacy.c          | 3 +++
>   tests/intel/xe_exec_reset.c | 8 ++++++++
>   2 files changed, 11 insertions(+)
> 
> diff --git a/lib/xe/xe_legacy.c b/lib/xe/xe_legacy.c
> index c0c0c4605c..cb53a8cfc8 100644
> --- a/lib/xe/xe_legacy.c
> +++ b/lib/xe/xe_legacy.c
> @@ -12,6 +12,7 @@
>   
>   /* Batch buffer element count, in number of dwords(u32) */
>   #define BATCH_DW_COUNT			16
> +#define SYSTEM				(0x1 << 12)
>   #define LONG_SPIN_REUSE_QUEUE		(0x1 << 11)
>   #define LONG_SPIN			(0x1 << 8)
>   #define CANCEL				(0x1 << 7)
> @@ -79,6 +80,8 @@ xe_legacy_test_mode(int fd, struct drm_xe_engine_class_instance *eci,
>   	bo_size = xe_bb_size(fd, bo_size);
>   
>   	bo = xe_bo_create(fd, vm, bo_size,
> +			  flags & SYSTEM ?
> +			  system_memory(fd) :
>   			  vram_if_possible(fd, eci->gt_id),
>   			  DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
>   	data = xe_bo_map(fd, bo, bo_size);
> diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> index 8685b84270..113ceb2178 100644
> --- a/tests/intel/xe_exec_reset.c
> +++ b/tests/intel/xe_exec_reset.c
> @@ -122,6 +122,7 @@ static void test_spin(int fd, struct drm_xe_engine_class_instance *eci,
>   #define GT0				(0x1 << 9)
>   #define GT1				(0x1 << 10)
>   #define LONG_SPIN_REUSE_QUEUE		(0x1 << 11)
> +#define SYSTEM				(0x1 << 12)
>   
>   /**
>    * SUBTEST: %s-cat-error
> @@ -698,6 +699,9 @@ static void *thread(void *data)
>    * SUBTEST: long-spin-reuse-many-preempt-threads
>    * Description: Test long spinners with many preemptable jobs on each engine instance with a thread, use queues again spinners complete, both GTs
>    *
> + * SUBTEST: long-spin-sys-reuse-many-preempt-threads
> + * Description: Test long spinners with many preemptable jobs on each engine instance with a thread, use queues again spinners complete, both GTs, use system memory
> + *
>    * SUBTEST: long-spin-reuse-many-preempt-gt0-threads
>    * Description: Test long spinners with many preemptable jobs on each engine instance with a thread, use queues again spinners complete, primary GT
>    *
> @@ -870,6 +874,10 @@ igt_main
>   		threads(fd, 2, 16, LONG_SPIN | PREEMPT |
>   			LONG_SPIN_REUSE_QUEUE);
>   
> +	igt_subtest("long-spin-sys-reuse-many-preempt-threads")
> +		threads(fd, 2, 16, SYSTEM | LONG_SPIN | PREEMPT |
> +			LONG_SPIN_REUSE_QUEUE);
> +
LGTM,
Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>> 
igt_subtest("long-spin-reuse-many-preempt-gt0-threads")
>   		threads(fd, 2, 16, LONG_SPIN | PREEMPT | GT0 |
>   			LONG_SPIN_REUSE_QUEUE);