From: Jan Beulich <jbeulich@suse.com>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>
Cc: Shawn Anastasio <sanastasio@raptorengineering.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Michal Orzel <michal.orzel@amd.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v6 1/8] xen/device-tree: Move Arm's setup.c bootinfo functions to common
Date: Mon, 15 Jul 2024 10:36:57 +0200 [thread overview]
Message-ID: <4876111b-8782-4b54-ad04-0a970cc8b4e7@suse.com> (raw)
In-Reply-To: <cb2348393294b8910d794d9d11fff28ff0e6996b.1720799926.git.oleksii.kurochko@gmail.com>
On 12.07.2024 18:22, Oleksii Kurochko wrote:> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -77,6 +77,7 @@ obj-$(CONFIG_UBSAN) += ubsan/
>
> obj-$(CONFIG_NEEDS_LIBELF) += libelf/
> obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/
> +obj-$(CONFIG_HAS_DEVICE_TREE) += device-tree/
>
> CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(objtree)/)$(KCONFIG_CONFIG)
> $(obj)/config.gz: $(CONF_FILE)
I think it would be nice for the bad placement of the two lib*/ entries
to not lead to further bad placements. Imo your addition wants to go
ahead of the
obj-$(CONFIG_HAS_DEVICE_TREE) += device_tree.o
line. (Eventually I expect common/device_tree.c would then also want to
move there, probably at the same time renaming it.)
Jan
next prev parent reply other threads:[~2024-07-15 8:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 16:22 [PATCH v2 0/8] RISCV device tree mapping Oleksii Kurochko
2024-07-12 16:22 ` [PATCH v6 1/8] xen/device-tree: Move Arm's setup.c bootinfo functions to common Oleksii Kurochko
2024-07-15 8:36 ` Jan Beulich [this message]
2024-07-15 10:15 ` Michal Orzel
2024-07-15 13:42 ` Oleksii
2024-07-12 16:22 ` [PATCH v6 2/8] xen/common: Move Arm's bootfdt.c " Oleksii Kurochko
2024-07-12 16:22 ` [PATCH v2 3/8] xen/riscv: enable CONFIG_HAS_DEVICE_TREE Oleksii Kurochko
2024-07-15 8:40 ` Jan Beulich
2024-07-12 16:22 ` [PATCH v2 4/8] xen/riscv: setup fixmap mapping Oleksii Kurochko
2024-07-21 8:46 ` Julien Grall
2024-07-22 14:31 ` Oleksii
2024-07-22 14:44 ` Julien Grall
2024-07-23 12:58 ` oleksii.kurochko
2024-07-23 13:32 ` Julien Grall
2024-07-23 13:27 ` oleksii.kurochko
2024-07-23 13:33 ` Julien Grall
2024-07-23 13:38 ` oleksii.kurochko
2024-07-22 12:42 ` Jan Beulich
2024-07-22 14:36 ` Oleksii
2024-07-22 15:25 ` Jan Beulich
2024-07-22 17:04 ` oleksii.kurochko
2024-07-23 13:34 ` oleksii.kurochko
2024-07-12 16:22 ` [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header Oleksii Kurochko
2024-07-21 8:51 ` Julien Grall
2024-07-22 12:58 ` Jan Beulich
2024-07-22 14:57 ` Julien Grall
2024-07-22 14:40 ` Oleksii
2024-07-22 12:54 ` Jan Beulich
2024-07-22 14:44 ` Oleksii Kurochko
2024-07-22 14:48 ` Julien Grall
2024-07-22 17:09 ` Oleksii Kurochko
2024-07-22 17:21 ` Julien Grall
2024-07-23 8:02 ` Oleksii Kurochko
2024-07-23 8:36 ` Jan Beulich
2024-07-23 8:55 ` oleksii.kurochko
2024-07-23 10:02 ` Jan Beulich
2024-07-23 15:36 ` oleksii.kurochko
2024-07-23 15:49 ` Julien Grall
2024-07-23 17:25 ` oleksii.kurochko
2024-07-23 17:28 ` oleksii.kurochko
2024-07-23 18:44 ` Julien Grall
2024-07-12 16:22 ` [PATCH v2 6/8] xen/riscv: introduce generic Xen page table handling Oleksii Kurochko
2024-07-21 9:02 ` Julien Grall
2024-07-22 6:59 ` Jan Beulich
2024-07-22 14:51 ` Oleksii
2024-07-12 16:22 ` [PATCH v2 7/8] xen/riscv: select CONFIG_GENREIC_PT Oleksii Kurochko
2024-07-12 16:22 ` [PATCH v2 8/8] xen/riscv: introduce early_fdt_map() Oleksii Kurochko
2024-07-15 8:52 ` Jan Beulich
2024-07-15 13:58 ` Oleksii
2024-07-15 14:58 ` Jan Beulich
2024-07-15 15:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876111b-8782-4b54-ad04-0a970cc8b4e7@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=dpsmith@apertussolutions.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.