From: Jan Beulich <jbeulich@suse.com>
To: Julien Grall <julien@xen.org>
Cc: Alistair Francis <alistair.francis@wdc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Connor Davis <connojdavis@gmail.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header
Date: Mon, 22 Jul 2024 14:58:29 +0200 [thread overview]
Message-ID: <c6a06c8d-ed6c-42d2-9ba3-56c37e878d9c@suse.com> (raw)
In-Reply-To: <15375179-1c94-43c3-a256-42a856905e21@xen.org>
On 21.07.2024 10:51, Julien Grall wrote:
> On 12/07/2024 17:22, Oleksii Kurochko wrote:
>> +inline pte_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr)
>> +{
>> + /* there is no attr field in RISC-V's pte */
>> + (void) attr;
>
> Surely you have a way to say indicate whether an entry is readable/writable?
I'm puzzled by this question. The sole outlier in Arm code is pmap.h, in
passing PAGE_HYPERVISOR_RW to this function when all others pass memory
types (MT_*). Afaics only the low three bits are then used in the
function, discarding access control bits altogether. R/W access appears
to be implied.
Jan
next prev parent reply other threads:[~2024-07-22 12:58 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 16:22 [PATCH v2 0/8] RISCV device tree mapping Oleksii Kurochko
2024-07-12 16:22 ` [PATCH v6 1/8] xen/device-tree: Move Arm's setup.c bootinfo functions to common Oleksii Kurochko
2024-07-15 8:36 ` Jan Beulich
2024-07-15 10:15 ` Michal Orzel
2024-07-15 13:42 ` Oleksii
2024-07-12 16:22 ` [PATCH v6 2/8] xen/common: Move Arm's bootfdt.c " Oleksii Kurochko
2024-07-12 16:22 ` [PATCH v2 3/8] xen/riscv: enable CONFIG_HAS_DEVICE_TREE Oleksii Kurochko
2024-07-15 8:40 ` Jan Beulich
2024-07-12 16:22 ` [PATCH v2 4/8] xen/riscv: setup fixmap mapping Oleksii Kurochko
2024-07-21 8:46 ` Julien Grall
2024-07-22 14:31 ` Oleksii
2024-07-22 14:44 ` Julien Grall
2024-07-23 12:58 ` oleksii.kurochko
2024-07-23 13:32 ` Julien Grall
2024-07-23 13:27 ` oleksii.kurochko
2024-07-23 13:33 ` Julien Grall
2024-07-23 13:38 ` oleksii.kurochko
2024-07-22 12:42 ` Jan Beulich
2024-07-22 14:36 ` Oleksii
2024-07-22 15:25 ` Jan Beulich
2024-07-22 17:04 ` oleksii.kurochko
2024-07-23 13:34 ` oleksii.kurochko
2024-07-12 16:22 ` [PATCH v2 5/8] xen/riscv: introduce asm/pmap.h header Oleksii Kurochko
2024-07-21 8:51 ` Julien Grall
2024-07-22 12:58 ` Jan Beulich [this message]
2024-07-22 14:57 ` Julien Grall
2024-07-22 14:40 ` Oleksii
2024-07-22 12:54 ` Jan Beulich
2024-07-22 14:44 ` Oleksii Kurochko
2024-07-22 14:48 ` Julien Grall
2024-07-22 17:09 ` Oleksii Kurochko
2024-07-22 17:21 ` Julien Grall
2024-07-23 8:02 ` Oleksii Kurochko
2024-07-23 8:36 ` Jan Beulich
2024-07-23 8:55 ` oleksii.kurochko
2024-07-23 10:02 ` Jan Beulich
2024-07-23 15:36 ` oleksii.kurochko
2024-07-23 15:49 ` Julien Grall
2024-07-23 17:25 ` oleksii.kurochko
2024-07-23 17:28 ` oleksii.kurochko
2024-07-23 18:44 ` Julien Grall
2024-07-12 16:22 ` [PATCH v2 6/8] xen/riscv: introduce generic Xen page table handling Oleksii Kurochko
2024-07-21 9:02 ` Julien Grall
2024-07-22 6:59 ` Jan Beulich
2024-07-22 14:51 ` Oleksii
2024-07-12 16:22 ` [PATCH v2 7/8] xen/riscv: select CONFIG_GENREIC_PT Oleksii Kurochko
2024-07-12 16:22 ` [PATCH v2 8/8] xen/riscv: introduce early_fdt_map() Oleksii Kurochko
2024-07-15 8:52 ` Jan Beulich
2024-07-15 13:58 ` Oleksii
2024-07-15 14:58 ` Jan Beulich
2024-07-15 15:00 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6a06c8d-ed6c-42d2-9ba3-56c37e878d9c@suse.com \
--to=jbeulich@suse.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.