Re: [PATCH] Move .power and .reset from soc_camera platform to sensor driver

[Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>]

Guennadi Liakhovetski schrieb:
> On Fri, 1 Aug 2008, Stefan Herbrechtsmeier wrote:
>
>   
>> Paulius Zaleckas schrieb:
>>     
>>> Stefan Herbrechtsmeier wrote:
>>>       
>>>> Move .power (enable_camera, disable_camera) and .reset from soc_camera
>>>> platform driver (pxa_camera_platform_data, sh_mobile_ceu_info) to sensor
>>>> driver (soc_camera_link) and add .init and .release to request and free
>>>> gpios.
>>>>
>>>> Signed-off-by: Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>
>>>>         
>>> While I agree that it is good to move .power and .reset to
>>> soc_camera_link... IMHO controlling of these should be left in
>>> host driver.
>>>       
>> How should we deal with the register based version of this functions (soft
>> reset)?
>> At the moment we reset the sensors twice, if we use a hardware reset (.reset).
>>     
>
> Paulius, can you give any specific reason why you think, calling those 
> functions from the host driver would be better?
>
> As for calling either platform-provided reset or internal one. Actually, 
> whyt about making platform reset (and power too) return an error code, and 
> if it failed call th internal one? 
At the moment I assume that reset and power will work, if they are 
defined, but we can change it.
> And as a parameter wouldn't it make 
> more sense to pass the soc_camera_link to the platform functions instead 
> of the struct device from the i2c device?
>   
I have simple make the function similar to other platform_data functions 
on my system.
At the moment I use the parameter only for printing messages via dev_err.

Regards
    Stefan

-- 
Dipl.-Ing. Stefan Herbrechtsmeier

Heinz Nixdorf Institute
University of Paderborn 
System and Circuit Technology 
Fürstenallee 11
D-33102 Paderborn (Germany)

office : F0.415
phone  : + 49 5251 - 60 6342
fax    : + 49 5251 - 60 6351

mailto : hbmeier@hni.upb.de

www    : http://wwwhni.upb.de/sct/mitarbeiter/hbmeier


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list