Re: [PATCH] soc-camera: Move .power and .reset from soc_camera host to sensor driver

[Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>]

Guennadi Liakhovetski schrieb:
> Make .power and .reset callbacks per camera instead of per host, also move 
> their invocation to camera drivers.
>
> Signed-off-by: Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> On Fri, 1 Aug 2008, Stefan Herbrechtsmeier wrote:
>   
>> Guennadi Liakhovetski schrieb:
>>     
>>> I'd rather preserve the possibility to use "soft" reset / poweroff also when
>>> a platform function is defined. In fact, it might be even better to do a
>>> soft power-off first and then call platform-provided one. Don't think it
>>> would make much sense for reset though.
>>>   
>>>       
>> You are right, I'll change it with the next version.
>>     
>
> How about the version below? I didn't understand why you need extra .init 
> and .release calls, so, I removed them for now. I think, .init per host 
> and power-on / off per camera should be enough for all init / release 
> needs, don't you think so
I use the .init call for gpio_request and gpio_direction_output and the 
.release call for gpio_free.
I do that this way, because I think they belongs more to the camera.

The patch looks ok for me.

Regards
    Stefan

-- 
Dipl.-Ing. Stefan Herbrechtsmeier

Heinz Nixdorf Institute
University of Paderborn 
System and Circuit Technology 
Fürstenallee 11
D-33102 Paderborn (Germany)

office : F0.415
phone  : + 49 5251 - 60 6342
fax    : + 49 5251 - 60 6351

mailto : hbmeier@hni.upb.de

www    : http://wwwhni.upb.de/sct/mitarbeiter/hbmeier


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list