Re: [PATCH] Move .power and .reset from soc_camera platform to sensor driver

[Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>]

Guennadi Liakhovetski schrieb:
> On Fri, 1 Aug 2008, Stefan Herbrechtsmeier wrote:
>
>   
>> Guennadi Liakhovetski schrieb:
>>     
>>> As for calling either platform-provided reset or internal one. Actually,
>>> whyt about making platform reset (and power too) return an error code, and
>>> if it failed call th internal one? 
>>>       
>> At the moment I assume that reset and power will work, if they are defined,
>> but we can change it.
>>     
>
> I'd rather preserve the possibility to use "soft" reset / poweroff also 
> when a platform function is defined. In fact, it might be even better to 
> do a soft power-off first and then call platform-provided one. Don't think 
> it would make much sense for reset though.
>   
You are right, I'll change it with the next version.
>   
>>> And as a parameter wouldn't it make more sense to pass the soc_camera_link
>>> to the platform functions instead of the struct device from the i2c device?
>>>   
>>>       
>> I have simple make the function similar to other platform_data functions on my
>> system.
>> At the moment I use the parameter only for printing messages via dev_err.
>>     
>
> You have to be able to trace which camera has to be resetted / powered on 
> or off in your platform code, and the camera_link structure is the object 
> that identifies a specific camera, ot, at least, it can be. Whereas the 
> device pointer doesn't easily tell you which camera you want to operate 
> upon.
>   
If you use the same function for different sensors (camera_links), you 
are right,
but you can get the camera_link from the dev pointer (.platform_data) if you
need it.

Regards
    Stefan

-- 
Dipl.-Ing. Stefan Herbrechtsmeier

Heinz Nixdorf Institute
University of Paderborn 
System and Circuit Technology 
Fürstenallee 11
D-33102 Paderborn (Germany)

office : F0.415
phone  : + 49 5251 - 60 6342
fax    : + 49 5251 - 60 6351

mailto : hbmeier@hni.upb.de

www    : http://wwwhni.upb.de/sct/mitarbeiter/hbmeier


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list