Re: [PATCH] soc-camera: Move .power and .reset from soc_camera host to sensor driver

[Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>]

Guennadi Liakhovetski schrieb:
> On Thu, 14 Aug 2008, Stefan Herbrechtsmeier wrote:
>
>   
>> Guennadi Liakhovetski schrieb:
>>     
>>> How about the version below? I didn't understand why you need extra .init
>>> and .release calls, so, I removed them for now. I think, .init per host and
>>> power-on / off per camera should be enough for all init / release needs,
>>> don't you think so
>>>       
>> I use the .init call for gpio_request and gpio_direction_output and the
>> .release call for gpio_free.
>> I do that this way, because I think they belongs more to the camera.
>>     
>
> What are these GPIOs? Are they interfacing to a specific camera, or do 
> they belong to the camera-host interface? If they belong to a specific 
> camera, then yes, it is logical to control them from the camera driver 
> platform callbacks.
The GPIOs belongs to the camera. One GPIO for the camera reset input and 
one for the power down
input of the camera.
> But cannot you do this in .power? Just do the .init 
> part on power-on and the .release part on power-off?
>   
The driver need to control the power down input after power-off to hold 
the camera in power down mode.
Maybe I can free the gpio after power-off without changing the gpio 
value, but I think the use of .init and
.release call is better and more clearly. Do you think it is ok to free 
the gpio even if it must stay high?
>   
>> The patch looks ok for me.
>>     
>
> Well, if you cannot use it in this form without .init and .release then it 
> can hardly be called "ok" for you:-)
>   
I mean it is ok except the .init and .release part. ;-)

Regards
    Stefan

-- 
Dipl.-Ing. Stefan Herbrechtsmeier

Heinz Nixdorf Institute
University of Paderborn 
System and Circuit Technology 
Fürstenallee 11
D-33102 Paderborn (Germany)

office : F0.415
phone  : + 49 5251 - 60 6342
fax    : + 49 5251 - 60 6351

mailto : hbmeier@hni.upb.de

www    : http://wwwhni.upb.de/sct/mitarbeiter/hbmeier


--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list