[PATCH] stubdom: Fix the Makefile

[PATCH] stubdom: Fix the Makefile

[Yosuke Iwamatsu]

While building stubdom, I saw an error.

  install: cannot stat `lib/{config,header,pci,types}.h': No such file
  or directory

It seems brace expansion is not available in some environments, so we
had better avoid using it.

Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>

diff -r f37a7ea71766 stubdom/Makefile
--- a/stubdom/Makefile  Fri Aug 01 09:45:36 2008 +0100
+++ b/stubdom/Makefile  Mon Aug 04 16:05:05 2008 +0900
@@ -132,7 +132,7 @@ cross-libpci: $(LIBPCI_STAMPFILE)
          $(MAKE) CC="$(CC) $(TARGET_CPPFLAGS) $(TARGET_CFLAGS)
-I$(realpath $(MINI_OS)/include)" lib/libpci.a && \
          $(INSTALL_DATA) lib/libpci.a
$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/lib/ && \
          $(INSTALL_DIR)
$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include/pci && \
-         $(INSTALL_DATA) lib/{config,header,pci,types}.h
$(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include/pci/ \
+         $(INSTALL_DATA) lib/config.h lib/header.h lib/pci.h
lib/types.h $(CROSS_PREFIX)/$(GNU_TARGET_ARCH)-xen-elf/include/pci/ \
        )

 ######

Re: [PATCH] stubdom: Fix the Makefile

[Ian Jackson]

Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] stubdom: Fix the Makefile"):
> While building stubdom, I saw an error.
> 
>   install: cannot stat `lib/{config,header,pci,types}.h': No such file
>   or directory
> 
> It seems brace expansion is not available in some environments, so we
> had better avoid using it.

I see that this has been committed already.  However for future
reference I think a better answer is to say
   SHELL=/bin/bash
in some appropriate place.

This kind of brace expansion is an excellent trick for removing
duplication in Makefile runes and our build system depends on bash
anyway.

Ian.

[PATCH] stubdom: Fix the Makefile

[Yosuke Iwamatsu]

Ian Jackson wrote:
> Yosuke Iwamatsu writes ("[Xen-devel] [PATCH] stubdom: Fix the Makefile"):
>> While building stubdom, I saw an error.
>>
>>   install: cannot stat `lib/{config,header,pci,types}.h': No such file
>>   or directory
>>
>> It seems brace expansion is not available in some environments, so we
>> had better avoid using it.
> 
> I see that this has been committed already.  However for future
> reference I think a better answer is to say
>    SHELL=/bin/bash
> in some appropriate place.
> 
> This kind of brace expansion is an excellent trick for removing
> duplication in Makefile runes and our build system depends on bash
> anyway.

I agree that brace expansion is convenient and sometimes desireble.
One thing I want to clarify is that, does our build system really depend
on bash? Non-linux systems as *BSD and Solaris are not likely to have
bash, so 'SHELL=/bin/bash' won't work. (I usually use a linux box myself
and assuming that bash is always available is O.K. to me, though.)

-- Yosuke