All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Sealey <matt@genesi-usa.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: USB support on mpc5200 broken
Date: Tue, 30 Sep 2008 10:20:37 -0500	[thread overview]
Message-ID: <48E243C5.7000100@genesi-usa.com> (raw)
In-Reply-To: <9e4733910809290714td2dc6cclecf2e2b080a80ca1@mail.gmail.com>

Jon Smirl wrote:

> 
> Efika has this:
> compatible = "fsl,mpc5200b-ohci","fsl,mpc5200-ohci";

It doesn't :D

My system, running production firmware, says

ohci-bigendian,ohci-be,mpc5200-ohci,mpc5200-usb

This is what we were recommended to use at the time. There is a patch
on www.powerdeveloper.org which tweaks the tree to make it ultra-compliant
with the Linux version of things, which implements every variation. It
also implements a suggested patch which added a "big-endian" property
(not built in to the compatible property, but another property).

I don't see why THAT patch got reverted as it was a great idea that we
all agreed was a great idea.

Linux development around here is getting really schizophrenic. Nobody
is writing these decisions down even as comments in the source code..

> If we really need a big endian flag, should it be an attribute?

Yes.

> Shouldn't the driver already know it is being used on a BE machine?

No; you can have little endian OHCI controllers on big endian machines.
It's a property of the host controller, not the system architecture, just
like PCI is always little endian (except when you have magic in hardware
like Amiga PowerUP cards which endianswap for you :)

-- 
Matt Sealey <matt@genesi-usa.com>
Genesi, Manager, Developer Relations

  parent reply	other threads:[~2008-09-30 15:20 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-24 21:51 USB support on mpc5200 broken Jon Smirl
2008-09-25  1:09 ` Jon Smirl
2008-09-25  1:50   ` Benjamin Herrenschmidt
2008-09-25  2:40     ` Jon Smirl
2008-09-29  1:30     ` Matt Sealey
2008-09-29  3:43       ` David Gibson
2008-09-29 14:14         ` Jon Smirl
2008-09-29 14:22           ` Peter Korsgaard
2008-09-29 14:28             ` Jon Smirl
2008-09-29 15:07               ` Peter Korsgaard
2008-09-29 20:18           ` Scott Wood
2008-09-29 21:04             ` Jon Smirl
2008-09-29 22:02               ` Grant Likely
2008-09-30 15:20           ` Matt Sealey [this message]
2008-10-01  3:31             ` Benjamin Herrenschmidt
2008-10-01  9:46               ` Carsten Schlote
2008-10-01 10:36                 ` Benjamin Herrenschmidt
2008-10-06 21:06               ` Matt Sealey
2008-09-29 15:18         ` Sven Luther
2008-09-29 17:05           ` Peter Korsgaard
2008-09-30  1:12           ` David Gibson
2008-09-30  1:24             ` Raquel and Bill
2008-09-30 15:15         ` Matt Sealey
2008-11-03 15:41   ` Grant Likely
2008-11-03 16:21     ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E243C5.7000100@genesi-usa.com \
    --to=matt@genesi-usa.com \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=jonsmirl@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.