* [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration
@ 2008-10-29 12:37 Wolfgang Grandegger
2008-10-29 13:01 ` Sebastian Smolorz
2008-10-30 0:26 ` Jan Kiszka
0 siblings, 2 replies; 4+ messages in thread
From: Wolfgang Grandegger @ 2008-10-29 12:37 UTC (permalink / raw)
To: xenomai-core; +Cc: Jan Kiszka, Sebastian Smolorz
Hi Jan and Sebastian,
attached is the patch fixing the filter problem. I'm going to apply it
to the trunk as well if there are no complaints.
Wolfgang.
Index: ChangeLog
===================================================================
--- ChangeLog (revision 4287)
+++ ChangeLog (working copy)
@@ -1,3 +1,9 @@
+2008-10-29 Wolfgang Grandegger <wg@domain.hid>
+
+ * ksrc/drivers/can/rtcan_raw_filter.c(rtcan_raw_mount_filter):
+ Applying the filter mask required for fast filter checks got lost
+ somehow with commit 2202.
+
2008-10-28 Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
* ksrc/nucleus/thread.c (xnthread_init): Change initialization
Index: ksrc/drivers/can/rtcan_raw_filter.c
===================================================================
--- ksrc/drivers/can/rtcan_raw_filter.c (revision 4287)
+++ ksrc/drivers/can/rtcan_raw_filter.c (working copy)
@@ -62,6 +62,9 @@
recv_filter->can_id = filter->can_id;
recv_filter->can_mask = filter->can_mask & ~CAN_INV_FILTER;
}
+
+ /* Apply mask for fast filter check */
+ recv_filter->can_id &= recv_filter->can_mask;
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration
2008-10-29 12:37 [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration Wolfgang Grandegger
@ 2008-10-29 13:01 ` Sebastian Smolorz
2008-10-30 0:26 ` Jan Kiszka
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Smolorz @ 2008-10-29 13:01 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: Jan Kiszka, xenomai-core
Wolfgang Grandegger wrote:
> Hi Jan and Sebastian,
>
> attached is the patch fixing the filter problem. I'm going to apply it
> to the trunk as well if there are no complaints.
No complaints from my side.
>
> Wolfgang.
>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 4287)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,9 @@
> +2008-10-29 Wolfgang Grandegger <wg@domain.hid>
> +
> + * ksrc/drivers/can/rtcan_raw_filter.c(rtcan_raw_mount_filter):
> + Applying the filter mask required for fast filter checks got lost
> + somehow with commit 2202.
> +
> 2008-10-28 Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
>
> * ksrc/nucleus/thread.c (xnthread_init): Change initialization
> Index: ksrc/drivers/can/rtcan_raw_filter.c
> ===================================================================
> --- ksrc/drivers/can/rtcan_raw_filter.c (revision 4287)
> +++ ksrc/drivers/can/rtcan_raw_filter.c (working copy)
> @@ -62,6 +62,9 @@
> recv_filter->can_id = filter->can_id;
> recv_filter->can_mask = filter->can_mask & ~CAN_INV_FILTER;
> }
> +
> + /* Apply mask for fast filter check */
> + recv_filter->can_id &= recv_filter->can_mask;
> }
--
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration
2008-10-29 12:37 [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration Wolfgang Grandegger
2008-10-29 13:01 ` Sebastian Smolorz
@ 2008-10-30 0:26 ` Jan Kiszka
2008-10-30 11:25 ` Wolfgang Grandegger
1 sibling, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2008-10-30 0:26 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: xenomai-core, Sebastian Smolorz
[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]
Wolfgang Grandegger wrote:
> Hi Jan and Sebastian,
>
> attached is the patch fixing the filter problem. I'm going to apply it
> to the trunk as well if there are no complaints.
>
> Wolfgang.
>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 4287)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,9 @@
> +2008-10-29 Wolfgang Grandegger <wg@domain.hid>
> +
> + * ksrc/drivers/can/rtcan_raw_filter.c(rtcan_raw_mount_filter):
> + Applying the filter mask required for fast filter checks got lost
> + somehow with commit 2202.
> +
> 2008-10-28 Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
>
> * ksrc/nucleus/thread.c (xnthread_init): Change initialization
> Index: ksrc/drivers/can/rtcan_raw_filter.c
> ===================================================================
> --- ksrc/drivers/can/rtcan_raw_filter.c (revision 4287)
> +++ ksrc/drivers/can/rtcan_raw_filter.c (working copy)
> @@ -62,6 +62,9 @@
> recv_filter->can_id = filter->can_id;
> recv_filter->can_mask = filter->can_mask & ~CAN_INV_FILTER;
> }
> +
> + /* Apply mask for fast filter check */
> + recv_filter->can_id &= recv_filter->can_mask;
> }
>
>
Ack from me, too. Please commit to trunk and 2.4.x.
Thanks for spotting this, Sebastian!
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration
2008-10-30 0:26 ` Jan Kiszka
@ 2008-10-30 11:25 ` Wolfgang Grandegger
0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Grandegger @ 2008-10-30 11:25 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai-core, Sebastian Smolorz
Jan Kiszka wrote:
> Wolfgang Grandegger wrote:
>> Hi Jan and Sebastian,
>>
>> attached is the patch fixing the filter problem. I'm going to apply it
>> to the trunk as well if there are no complaints.
>>
>> Wolfgang.
>>
>> Index: ChangeLog
>> ===================================================================
>> --- ChangeLog (revision 4287)
>> +++ ChangeLog (working copy)
>> @@ -1,3 +1,9 @@
>> +2008-10-29 Wolfgang Grandegger <wg@domain.hid>
>> +
>> + * ksrc/drivers/can/rtcan_raw_filter.c(rtcan_raw_mount_filter):
>> + Applying the filter mask required for fast filter checks got lost
>> + somehow with commit 2202.
>> +
>> 2008-10-28 Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
>>
>> * ksrc/nucleus/thread.c (xnthread_init): Change initialization
>> Index: ksrc/drivers/can/rtcan_raw_filter.c
>> ===================================================================
>> --- ksrc/drivers/can/rtcan_raw_filter.c (revision 4287)
>> +++ ksrc/drivers/can/rtcan_raw_filter.c (working copy)
>> @@ -62,6 +62,9 @@
>> recv_filter->can_id = filter->can_id;
>> recv_filter->can_mask = filter->can_mask & ~CAN_INV_FILTER;
>> }
>> +
>> + /* Apply mask for fast filter check */
>> + recv_filter->can_id &= recv_filter->can_mask;
>> }
>>
>>
>
> Ack from me, too. Please commit to trunk and 2.4.x.
I just applied it to both branches.
Thanks,
Wolfgang.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-30 11:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 12:37 [Xenomai-core] [PATCH] RT-Socket-CAN: correct bug with filter registration Wolfgang Grandegger
2008-10-29 13:01 ` Sebastian Smolorz
2008-10-30 0:26 ` Jan Kiszka
2008-10-30 11:25 ` Wolfgang Grandegger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.