All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range
Date: Thu, 13 Nov 2008 12:12:16 -0800	[thread overview]
Message-ID: <491C8A20.1070107@goop.org> (raw)
In-Reply-To: <20081113195341.GA8299@cmpxchg.org>

Johannes Weiner wrote:
>> -	do {
>> -		BUG_ON(!pte_none(*pte));
>>     
>
> Dropping by intention?
>   

Hm, I couldn't really see the point.   But I didn't really want to 
introduce any functional changes with this patch, so I'll add it back.

>> 	BUG_ON(addr >= end);
>> -	pfn -= addr >> PAGE_SHIFT;
>> -	pgd = pgd_offset(mm, addr);
>> -	flush_cache_range(vma, addr, end);
>>     
>
> Was the flushing redundant?  I can't spot it reappearing anywhere.

I guess its needed for virtually indexed cache architectures; I'll add 
it back.

Thanks for reviewing.

    J

WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range
Date: Thu, 13 Nov 2008 12:12:16 -0800	[thread overview]
Message-ID: <491C8A20.1070107@goop.org> (raw)
In-Reply-To: <20081113195341.GA8299@cmpxchg.org>

Johannes Weiner wrote:
>> -	do {
>> -		BUG_ON(!pte_none(*pte));
>>     
>
> Dropping by intention?
>   

Hm, I couldn't really see the point.   But I didn't really want to 
introduce any functional changes with this patch, so I'll add it back.

>> 	BUG_ON(addr >= end);
>> -	pfn -= addr >> PAGE_SHIFT;
>> -	pgd = pgd_offset(mm, addr);
>> -	flush_cache_range(vma, addr, end);
>>     
>
> Was the flushing redundant?  I can't spot it reappearing anywhere.

I guess its needed for virtually indexed cache architectures; I'll add 
it back.

Thanks for reviewing.

    J

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-11-13 20:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 17:19 [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Jeremy Fitzhardinge
2008-11-13 17:19 ` Jeremy Fitzhardinge
2008-11-13 19:53 ` Johannes Weiner
2008-11-13 19:53   ` Johannes Weiner
2008-11-13 20:12   ` Jeremy Fitzhardinge [this message]
2008-11-13 20:12     ` Jeremy Fitzhardinge
2008-11-13 20:13   ` [PATCH 3/2] mm/remap_pfn_range: restore missing flush Jeremy Fitzhardinge
2008-11-13 20:13     ` Jeremy Fitzhardinge
2008-11-14  2:19 ` [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Nick Piggin
2008-11-14  2:19   ` Nick Piggin
2008-11-14  2:56   ` Jeremy Fitzhardinge
2008-11-14  2:56     ` Jeremy Fitzhardinge
2008-11-14  3:17     ` Nick Piggin
2008-11-14  3:17       ` Nick Piggin
2008-11-14  5:22       ` Jeremy Fitzhardinge
2008-11-14  5:22         ` Jeremy Fitzhardinge
2008-11-14  7:35         ` Nick Piggin
2008-11-14  7:35           ` Nick Piggin
2008-11-14 18:04           ` Jeremy Fitzhardinge
2008-11-14 18:04             ` Jeremy Fitzhardinge
2008-11-15  9:28             ` Hugh Dickins
2008-11-15  9:28               ` Hugh Dickins
2008-11-17  3:03           ` Peter Chubb
2008-11-17  3:03             ` Peter Chubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491C8A20.1070107@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.