From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range
Date: Thu, 13 Nov 2008 18:56:06 -0800 [thread overview]
Message-ID: <491CE8C6.4060000@goop.org> (raw)
In-Reply-To: <200811141319.56713.nickpiggin@yahoo.com.au>
Nick Piggin wrote:
>
> This isn't performance critical to anyone?
>
The only difference should be between having the specialized code and an
indirect function call, no?
> I see DRM, IB, GRU, other media and video drivers use it.
>
> It IS exactly what apply_to_page_range does, I grant you. But so does
> our traditional set of nested loops. So is there any particular reason
> to change it? You're not planning to change fork/exit next, are you? :)
>
No ;) But I need to have a more Xen-specific version of
remap_pfn_range, and I wanted to 1) have the two versions look as
similar as possible, and 2) not have a pile of duplicate code.
J
WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range
Date: Thu, 13 Nov 2008 18:56:06 -0800 [thread overview]
Message-ID: <491CE8C6.4060000@goop.org> (raw)
In-Reply-To: <200811141319.56713.nickpiggin@yahoo.com.au>
Nick Piggin wrote:
>
> This isn't performance critical to anyone?
>
The only difference should be between having the specialized code and an
indirect function call, no?
> I see DRM, IB, GRU, other media and video drivers use it.
>
> It IS exactly what apply_to_page_range does, I grant you. But so does
> our traditional set of nested loops. So is there any particular reason
> to change it? You're not planning to change fork/exit next, are you? :)
>
No ;) But I need to have a more Xen-specific version of
remap_pfn_range, and I wanted to 1) have the two versions look as
similar as possible, and 2) not have a pile of duplicate code.
J
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-14 2:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 17:19 [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Jeremy Fitzhardinge
2008-11-13 17:19 ` Jeremy Fitzhardinge
2008-11-13 19:53 ` Johannes Weiner
2008-11-13 19:53 ` Johannes Weiner
2008-11-13 20:12 ` Jeremy Fitzhardinge
2008-11-13 20:12 ` Jeremy Fitzhardinge
2008-11-13 20:13 ` [PATCH 3/2] mm/remap_pfn_range: restore missing flush Jeremy Fitzhardinge
2008-11-13 20:13 ` Jeremy Fitzhardinge
2008-11-14 2:19 ` [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Nick Piggin
2008-11-14 2:19 ` Nick Piggin
2008-11-14 2:56 ` Jeremy Fitzhardinge [this message]
2008-11-14 2:56 ` Jeremy Fitzhardinge
2008-11-14 3:17 ` Nick Piggin
2008-11-14 3:17 ` Nick Piggin
2008-11-14 5:22 ` Jeremy Fitzhardinge
2008-11-14 5:22 ` Jeremy Fitzhardinge
2008-11-14 7:35 ` Nick Piggin
2008-11-14 7:35 ` Nick Piggin
2008-11-14 18:04 ` Jeremy Fitzhardinge
2008-11-14 18:04 ` Jeremy Fitzhardinge
2008-11-15 9:28 ` Hugh Dickins
2008-11-15 9:28 ` Hugh Dickins
2008-11-17 3:03 ` Peter Chubb
2008-11-17 3:03 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491CE8C6.4060000@goop.org \
--to=jeremy@goop.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.