All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: [PATCH 3/2] mm/remap_pfn_range: restore missing flush
Date: Thu, 13 Nov 2008 12:13:35 -0800	[thread overview]
Message-ID: <491C8A6F.3000404@goop.org> (raw)
In-Reply-To: <20081113195341.GA8299@cmpxchg.org>

Restore the cache flush and BUG_ON removed in the conversion to using
apply_to_page_range().

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citix.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
---
 mm/memory.c |    4 ++++
 1 file changed, 4 insertions(+)

===================================================================
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1484,6 +1484,8 @@
 	struct remap_data *rmd = data;
 	pte_t pte = pte_mkspecial(pfn_pte(rmd->pfn++, rmd->prot));
 
+	BUG_ON(!pte_none(*ptep));
+
 	set_pte_at(rmd->mm, addr, ptep, pte);
 
 	return 0;
@@ -1535,6 +1537,8 @@
 
 	BUG_ON(addr >= end);
 
+	flush_cache_range(vma, addr, end);
+
 	rmd.mm = mm;
 	rmd.pfn = pfn;
 	rmd.prot = prot;



WARNING: multiple messages have this Message-ID (diff)
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nick Piggin <nickpiggin@yahoo.com.au>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Subject: [PATCH 3/2] mm/remap_pfn_range: restore missing flush
Date: Thu, 13 Nov 2008 12:13:35 -0800	[thread overview]
Message-ID: <491C8A6F.3000404@goop.org> (raw)
In-Reply-To: <20081113195341.GA8299@cmpxchg.org>

Restore the cache flush and BUG_ON removed in the conversion to using
apply_to_page_range().

Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citix.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
---
 mm/memory.c |    4 ++++
 1 file changed, 4 insertions(+)

===================================================================
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1484,6 +1484,8 @@
 	struct remap_data *rmd = data;
 	pte_t pte = pte_mkspecial(pfn_pte(rmd->pfn++, rmd->prot));
 
+	BUG_ON(!pte_none(*ptep));
+
 	set_pte_at(rmd->mm, addr, ptep, pte);
 
 	return 0;
@@ -1535,6 +1537,8 @@
 
 	BUG_ON(addr >= end);
 
+	flush_cache_range(vma, addr, end);
+
 	rmd.mm = mm;
 	rmd.pfn = pfn;
 	rmd.prot = prot;


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2008-11-13 20:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 17:19 [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Jeremy Fitzhardinge
2008-11-13 17:19 ` Jeremy Fitzhardinge
2008-11-13 19:53 ` Johannes Weiner
2008-11-13 19:53   ` Johannes Weiner
2008-11-13 20:12   ` Jeremy Fitzhardinge
2008-11-13 20:12     ` Jeremy Fitzhardinge
2008-11-13 20:13   ` Jeremy Fitzhardinge [this message]
2008-11-13 20:13     ` [PATCH 3/2] mm/remap_pfn_range: restore missing flush Jeremy Fitzhardinge
2008-11-14  2:19 ` [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Nick Piggin
2008-11-14  2:19   ` Nick Piggin
2008-11-14  2:56   ` Jeremy Fitzhardinge
2008-11-14  2:56     ` Jeremy Fitzhardinge
2008-11-14  3:17     ` Nick Piggin
2008-11-14  3:17       ` Nick Piggin
2008-11-14  5:22       ` Jeremy Fitzhardinge
2008-11-14  5:22         ` Jeremy Fitzhardinge
2008-11-14  7:35         ` Nick Piggin
2008-11-14  7:35           ` Nick Piggin
2008-11-14 18:04           ` Jeremy Fitzhardinge
2008-11-14 18:04             ` Jeremy Fitzhardinge
2008-11-15  9:28             ` Hugh Dickins
2008-11-15  9:28               ` Hugh Dickins
2008-11-17  3:03           ` Peter Chubb
2008-11-17  3:03             ` Peter Chubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491C8A6F.3000404@goop.org \
    --to=jeremy@goop.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.