From: Larry Finger <Larry.Finger@lwfinger.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: Michael Buesch <mb@bu3sch.de>,
linux-wireless@vger.kernel.org,
John Linville <linville@tuxdriver.com>
Subject: Re: rate instability in wireless stack
Date: Sun, 04 Jan 2009 18:29:25 -0600 [thread overview]
Message-ID: <49615465.4090604@lwfinger.net> (raw)
In-Reply-To: <20090104174123.GW496@one.firstfloor.org>
Andi,
Andi Kleen wrote:
>
> Anyways with PID i get between 1Mbit/s and 5.5Mbit/s, most of the
> time 1Mbit/s. So it's not really much better.
Does this patch help? Recently mac80211 changed from expecting tries
to retries, and I don't think rtl8180 got changed.
Larry
===============
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8180_dev.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -188,7 +188,7 @@ static void rtl8180_handle_tx(struct iee
(flags & RTL818X_TX_DESC_FLAG_TX_OK))
info->flags |= IEEE80211_TX_STAT_ACK;
- info->status.rates[0].count = (flags & 0xFF) + 1;
+ info->status.rates[0].count = (flags & 0xFF);
ieee80211_tx_status_irqsafe(dev, skb);
if (ring->entries - skb_queue_len(&ring->queue) == 2)
-------
next prev parent reply other threads:[~2009-01-05 0:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 16:46 rate instability in wireless stack Andi Kleen
2009-01-04 16:36 ` Michael Buesch
2009-01-04 17:41 ` Andi Kleen
2009-01-05 0:29 ` Larry Finger [this message]
2009-01-05 2:53 ` Andi Kleen
2009-01-05 3:55 ` Larry Finger
2009-01-05 5:02 ` Andi Kleen
2009-01-05 4:59 ` Larry Finger
2009-01-05 5:48 ` Andi Kleen
2009-01-05 5:51 ` Larry Finger
2009-01-05 8:17 ` Johannes Berg
2009-01-05 12:54 ` Andi Kleen
2009-01-05 13:32 ` Felix Fietkau
2009-01-05 14:23 ` Andi Kleen
2009-01-05 14:41 ` Felix Fietkau
2009-01-05 15:24 ` Andi Kleen
2009-01-05 15:25 ` Felix Fietkau
2009-01-05 16:35 ` Andi Kleen
2009-01-05 16:36 ` Felix Fietkau
2009-01-05 17:11 ` Andi Kleen
2009-01-05 17:01 ` Felix Fietkau
2009-01-05 19:33 ` Hin-Tak Leung
2009-01-05 20:16 ` Larry Finger
2009-01-05 4:22 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2009-01-07 6:46 Martín Ernesto Barreyro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49615465.4090604@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=andi@firstfloor.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.