* [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value
@ 2009-02-04 17:14 Roel Kluin
2009-02-04 17:26 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-02-04 17:14 UTC (permalink / raw)
To: perex, tiwai, alsa-devel
vi sound/core/oss/pcm_oss.c +640
#define AFMT_S24_LE 0x00008000
#define AFMT_S24_BE 0x00010000
---------------------->8----------------------8<-------------------
AFMT_S24_LE is set twice in return value
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index e178366..0a1798e 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
AFMT_S8 | AFMT_U16_LE |
AFMT_U16_BE |
AFMT_S32_LE | AFMT_S32_BE |
- AFMT_S24_LE | AFMT_S24_LE |
+ AFMT_S24_LE | AFMT_S24_BE |
AFMT_S24_PACKED;
params = kmalloc(sizeof(*params), GFP_KERNEL);
if (!params)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value
2009-02-04 17:14 [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value Roel Kluin
@ 2009-02-04 17:26 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-02-04 17:26 UTC (permalink / raw)
To: Roel Kluin; +Cc: alsa-devel
At Wed, 04 Feb 2009 18:14:55 +0100,
Roel Kluin wrote:
>
> vi sound/core/oss/pcm_oss.c +640
> #define AFMT_S24_LE 0x00008000
> #define AFMT_S24_BE 0x00010000
>
> ---------------------->8----------------------8<-------------------
> AFMT_S24_LE is set twice in return value
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Thanks, applied now.
Takashi
> ---
> diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
> index e178366..0a1798e 100644
> --- a/sound/core/oss/pcm_oss.c
> +++ b/sound/core/oss/pcm_oss.c
> @@ -1767,7 +1767,7 @@ static int snd_pcm_oss_get_formats(struct snd_pcm_oss_file *pcm_oss_file)
> AFMT_S8 | AFMT_U16_LE |
> AFMT_U16_BE |
> AFMT_S32_LE | AFMT_S32_BE |
> - AFMT_S24_LE | AFMT_S24_LE |
> + AFMT_S24_LE | AFMT_S24_BE |
> AFMT_S24_PACKED;
> params = kmalloc(sizeof(*params), GFP_KERNEL);
> if (!params)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-04 17:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-04 17:14 [PATCH] pcm_oss: AFMT_S24_LE is set twice in return value Roel Kluin
2009-02-04 17:26 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.