From: Andriy Gapon <avg@icyb.net.ua>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Re : Re: patch: (attempt to) emulate 440BX/PIIX4
Date: Thu, 19 Mar 2009 16:56:55 +0200 [thread overview]
Message-ID: <49C25D37.90302@icyb.net.ua> (raw)
In-Reply-To: <201500.89408.qm@web24507.mail.ird.yahoo.com>
on 18/03/2009 18:12 Sylvain Petreolle said the following:
>
> This part should should change piix3_devfn to piix4_devfn IMHO.
>
> --- hw/pc.c.orig 2009-03-04 22:54:45.000000000 +0000
> +++ hw/pc.c 2009-03-17 07:47:58.120091474 +0000
> @@ -938,7 +941,7 @@
>
> if (pci_enabled) {
> pci_bus = i440fx_init(&i440fx_state, i8259);
> - piix3_devfn = piix3_init(pci_bus, -1);
> + piix3_devfn = piix4_init(pci_bus, 7 << 3);
> Kind regards,
Yes, this would be correct from code self-descriptiveness point of view and it
must be done. I just wanted to initially produce a minimalistic obvious patch, so
that people could review and comment.
--
Andriy Gapon
prev parent reply other threads:[~2009-03-19 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 15:58 [Qemu-devel] patch: (attempt to) emulate 440BX/PIIX4 Andriy Gapon
2009-03-17 16:00 ` [Qemu-devel] " Andriy Gapon
2009-03-18 13:32 ` Andriy Gapon
2009-03-18 16:12 ` Re : " Sylvain Petreolle
2009-03-19 14:56 ` Andriy Gapon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C25D37.90302@icyb.net.ua \
--to=avg@icyb.net.ua \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.