[PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Matthieu Poullet]

The wildcard doesn't work properly.
So either the wildcard support must be fixed or all the *.state files must be added in the SRC_URI.

---
 recipes/alsa/alsa-state.bb |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/recipes/alsa/alsa-state.bb b/recipes/alsa/alsa-state.bb
index 3ebc0d5..a878c57 100644
--- a/recipes/alsa/alsa-state.bb
+++ b/recipes/alsa/alsa-state.bb
@@ -13,7 +13,15 @@ SRC_URI = "\
   file://asound.conf \
   file://asound.state \
   file://alsa-state \
-  file://*.state \
+  file://asound.state \
+  file://at91sam9263ek/asound.state \
+  file://spitz/asound.state \
+  file://tosa/asound.state \
+  file://c7x0/asound.state \
+  file://magician/asound.state \
+  file://hx4700/asound.state \
+  file://nokia800/asound.state \
+  file://akita/asound.state \
 "
 
 inherit update-rc.d
-- 
1.5.6.3

Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Philip Balister]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

Matthieu Poullet wrote:
> The wildcard doesn't work properly.
> So either the wildcard support must be fixed or all the *.state files must be added in the SRC_URI.

Acked-by: Philip Balister (philip@balister.org)

This makes the packages created from this recipe more deterministic.


> 
> ---
>  recipes/alsa/alsa-state.bb |   10 +++++++++-
>  1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/recipes/alsa/alsa-state.bb b/recipes/alsa/alsa-state.bb
> index 3ebc0d5..a878c57 100644
> --- a/recipes/alsa/alsa-state.bb
> +++ b/recipes/alsa/alsa-state.bb
> @@ -13,7 +13,15 @@ SRC_URI = "\
>    file://asound.conf \
>    file://asound.state \
>    file://alsa-state \
> -  file://*.state \
> +  file://asound.state \
> +  file://at91sam9263ek/asound.state \
> +  file://spitz/asound.state \
> +  file://tosa/asound.state \
> +  file://c7x0/asound.state \
> +  file://magician/asound.state \
> +  file://hx4700/asound.state \
> +  file://nokia800/asound.state \
> +  file://akita/asound.state \
>  "
>  
>  inherit update-rc.d

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3303 bytes --]

Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Andrea Adami]

tested here. thx.

Acked-by: Andrea Adami (andrea.adami@gmail.com)

Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Marcin Juszkiewicz]

[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]

Dnia niedziela, 22 marca 2009 o 15:12:22 Matthieu Poullet napisał(a):
> The wildcard doesn't work properly.
> So either the wildcard support must be fixed or all the *.state files
> must be added in the SRC_URI.

NACK

> diff --git a/recipes/alsa/alsa-state.bb b/recipes/alsa/alsa-state.bb
> index 3ebc0d5..a878c57 100644
> --- a/recipes/alsa/alsa-state.bb
> +++ b/recipes/alsa/alsa-state.bb
> @@ -13,7 +13,15 @@ SRC_URI = "\
>    file://asound.conf \
>    file://asound.state \
>    file://alsa-state \
> -  file://*.state \
> +  file://asound.state \

This should be enough. BitBake will take proper asound.state from 
MACHINE/ directory if it is present.

> +  file://at91sam9263ek/asound.state \
> +  file://spitz/asound.state \
> +  file://tosa/asound.state \
> +  file://c7x0/asound.state \
> +  file://magician/asound.state \
> +  file://hx4700/asound.state \
> +  file://nokia800/asound.state \
> +  file://akita/asound.state \

That part is wrong.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 204 bytes --]

Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Marcin Juszkiewicz]

> > diff --git a/recipes/alsa/alsa-state.bb

I looked more at that recipe and found few bugs in it:

1. It assumes that 'asound.conf' is same for all devices. This is not
   true for 'at91sam9263ek' which kernel oops with default file.

2. It plays with INITSCRIPT_PARAMS in postinst script. I do not know
   maybe it was required in past but why it is present now? No idea and
   no info in recipe why it is that way.

3. Postinst script restore default ALSA settings which is ugly too - 
   what if user just muted all channels to have device quiet during 
   night and postinst just makes his 1000W 7.1 audio system goes to full
   volume at 02:00 at night?

4. With current version is is broken for a780 device which has few
   states files available.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Marcin Juszkiewicz]

Dnia niedziela, 22 marca 2009 o 20:15:33 Marcin Juszkiewicz napisał(a):
> > > diff --git a/recipes/alsa/alsa-state.bb
>
> I looked more at that recipe and found few bugs in it:
>
> 1. It assumes that 'asound.conf' is same for all devices. This is not
>    true for 'at91sam9263ek' which kernel oops with default file.

fixed in 139b0c1bad85fb628bc6a265a6da08dd190f684a

> 2. It plays with INITSCRIPT_PARAMS in postinst script. I do not know
>    maybe it was required in past but why it is present now? No idea
>    and no info in recipe why it is that way.

> 3. Postinst script restore default ALSA settings which is ugly too -
>    what if user just muted all channels to have device quiet during
>    night and postinst just makes his 1000W 7.1 audio system goes to
>    full volume at 02:00 at night?

> 4. With current version is is broken for a780 device which has few
>    states files available.

fixed in 30b5d30c274b2ae748ed65edea62cef40a23ce32

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

Re: [PATCH] Alsa-state: Wildcard removed and all *.state put back in the recipes

[Marcin Juszkiewicz]

Dnia niedziela, 22 marca 2009 o 19:29:47 Marcin Juszkiewicz napisał(a):
> > The wildcard doesn't work properly.
> > So either the wildcard support must be fixed or all the *.state
> > files must be added in the SRC_URI.
>
> NACK

fix pushed in dc6fc903acadd55c5fc5156f6997e0c055028a76

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz