All of lore.kernel.org
 help / color / mirror / Atom feed
* [BUGFIX]
@ 2009-04-02 12:52 phcoder
  2009-04-02 14:45 ` [BUGFIX] Bean
  0 siblings, 1 reply; 15+ messages in thread
From: phcoder @ 2009-04-02 12:52 UTC (permalink / raw)
  To: The development of GRUB 2

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Hello symbols from command.h aren't exported correctly. Here's a bugfix. 
It compiles with it but I haven't checked yet if compiled binary works. 
Can someone familiar with build system have a look at this?
-- 

Regards
Vladimir 'phcoder' Serbinenko

[-- Attachment #2: ppcfix.diff --]
[-- Type: text/x-diff, Size: 1280 bytes --]

diff --git a/conf/powerpc-ieee1275.rmk b/conf/powerpc-ieee1275.rmk
index 437bf83..9ce1c9a 100644
--- a/conf/powerpc-ieee1275.rmk
+++ b/conf/powerpc-ieee1275.rmk
@@ -16,7 +16,8 @@ DEFSYMFILES += kernel_syms.lst
 kernel_elf_HEADERS = boot.h cache.h device.h disk.h dl.h elf.h elfload.h \
 	env.h err.h file.h fs.h kernel.h misc.h mm.h net.h parser.h rescue.h \
 	symbol.h term.h time.h types.h powerpc/libgcc.h loader.h partition.h \
-	pc_partition.h ieee1275/ieee1275.h machine/kernel.h handler.h
+	pc_partition.h ieee1275/ieee1275.h machine/kernel.h handler.h \
+	command.h list.h
 
 symlist.c: $(addprefix include/grub/,$(kernel_elf_HEADERS)) config.h gensymlist.sh
 	/bin/sh gensymlist.sh $(filter %.h,$^) > $@ || (rm -f $@; exit 1)
@@ -88,8 +89,7 @@ kernel_elf_SOURCES = kern/powerpc/ieee1275/startup.S kern/ieee1275/cmain.c \
 	kern/parser.c kern/partition.c kern/env.c kern/powerpc/dl.c 	\
 	kern/generic/millisleep.c kern/time.c                            \
 	symlist.c kern/powerpc/cache.S
-kernel_elf_HEADERS = grub/powerpc/ieee1275/ieee1275.h list.h handler.h \
-	command.h
+kernel_elf_HEADERS += grub/powerpc/ieee1275/ieee1275.h
 kernel_elf_CFLAGS = $(COMMON_CFLAGS)
 kernel_elf_ASFLAGS = $(COMMON_ASFLAGS)
 kernel_elf_LDFLAGS = $(COMMON_LDFLAGS) -static-libgcc -lgcc \

^ permalink raw reply related	[flat|nested] 15+ messages in thread
* [Bugfix]
@ 2015-07-30 16:44 ` Jiang Liu
  0 siblings, 0 replies; 15+ messages in thread
From: Jiang Liu @ 2015-07-30 16:44 UTC (permalink / raw)
  To: Thomas Gleixner, Alexander Holler, Mark Rustad, Alex Deucher,
	Joerg Roedel
  Cc: Tony Luck, x86-DgEjT+Ai2ygdnm+yROfE0A,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Tejun Heo,
	Jiang Liu

Hi Alexander, Mark, Alex,
	Could you please help to apply the debug patch and send me back
the dmesg? Please also help to turn kernel paramemter "apic=debug".

Hi Mark,
	It seems that this regression is caused by support of multiple-MSI,
but I have no PCI card supportting multiple-MSI at hand. So may I remotely
access your system from Intel internal network?  That will definitely speed
up fix.
Thanks!
Gerry

Signed-off-by: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
 drivers/iommu/amd_iommu.c           |   15 +++++++++++++--
 drivers/iommu/intel_irq_remapping.c |    4 ++++
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index a57e9b749895..c039ed9333a4 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3916,8 +3916,8 @@ static void irq_remapping_prepare_irte(struct amd_ir_data *data,
 	union irte *irte = &data->irte_entry;
 	struct IO_APIC_route_entry *entry;
 
-	data->irq_2_irte.devid = devid;
-	data->irq_2_irte.index = index + sub_handle;
+	irte_info->devid = devid;
+	irte_info->index = index + sub_handle;
 
 	/* Setup IRTE for IOMMU */
 	irte->val = 0;
@@ -3926,6 +3926,10 @@ static void irq_remapping_prepare_irte(struct amd_ir_data *data,
 	irte->fields.destination = irq_cfg->dest_apicid;
 	irte->fields.dm          = apic->irq_dest_mode;
 	irte->fields.valid       = 1;
+	if (info->type == X86_IRQ_ALLOC_TYPE_MSI)
+		pr_warn("irqdomain: IRTE%d vector %d APICID%d data%p cfg%p\n",
+			irte_info->index, irte->fields.vector,
+			irte->fields.destination, data, irq_cfg);
 
 	switch (info->type) {
 	case X86_IRQ_ALLOC_TYPE_IOAPIC:
@@ -3972,6 +3976,9 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,
 	    info->type != X86_IRQ_ALLOC_TYPE_MSIX)
 		return -EINVAL;
 
+	if (info->type == X86_IRQ_ALLOC_TYPE_MSI)
+		pr_warn("irqdomain: allocate %d MSI IRQ, VIRQ%d\n", nr_irqs, virq);
+
 	/*
 	 * With IRQ remapping enabled, don't need contiguous CPU vectors
 	 * to support multiple MSI interrupts.
@@ -3986,6 +3993,8 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,
 	ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
 	if (ret < 0)
 		return ret;
+	if (info->type == X86_IRQ_ALLOC_TYPE_MSI)
+		pr_warn("irqdomain: allocate parent returns %d\n", ret);
 
 	ret = -ENOMEM;
 	data = kzalloc(sizeof(*data), GFP_KERNEL);
@@ -4005,6 +4014,8 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,
 		kfree(data);
 		goto out_free_parent;
 	}
+	if (info->type == X86_IRQ_ALLOC_TYPE_MSI)
+		pr_warn("irqdomain: allocate IRTE index %d\n", index);
 
 	for (i = 0; i < nr_irqs; i++) {
 		irq_data = irq_domain_get_irq_data(domain, virq + i);
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index f15692a410c7..bb093bc6b334 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -1234,6 +1234,8 @@ static void intel_irq_remapping_prepare_irte(struct intel_ir_data *data,
 				  MSI_ADDR_IR_SHV |
 				  MSI_ADDR_IR_INDEX1(index) |
 				  MSI_ADDR_IR_INDEX2(index);
+		if (info->type == X86_IRQ_ALLOC_TYPE_MSI)
+			pr_warn("irqdomain: allocate index%d, subhandle%d, irte%llx,%llx\n", index, sub_handle, irte->high, irte->low);
 		break;
 
 	default:
@@ -1305,6 +1307,8 @@ static int intel_irq_remapping_alloc(struct irq_domain *domain,
 		kfree(data);
 		goto out_free_parent;
 	}
+	if (info->type == X86_IRQ_ALLOC_TYPE_MSI)
+		pr_warn("irqdomain: allocate VIRQ%d, count%d, index%d\n", virq, nr_irqs, index);
 
 	for (i = 0; i < nr_irqs; i++) {
 		irq_data = irq_domain_get_irq_data(domain, virq + i);
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-07-30 18:34 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-02 12:52 [BUGFIX] phcoder
2009-04-02 14:45 ` [BUGFIX] Bean
2009-04-02 14:48   ` [BUGFIX] phcoder
2009-04-02 15:55     ` [BUGFIX] Manoel Rebelo Abranches
2009-04-02 18:19       ` [BUGFIX] phcoder
2009-04-03  5:06         ` [BUGFIX] Bean
2009-04-03 14:48         ` [BUGFIX] phcoder
2009-04-03 16:55           ` [BUGFIX] Pavel Roskin
2009-04-04 12:30           ` [BUGFIX] phcoder
  -- strict thread matches above, loose matches on Subject: below --
2015-07-30 16:44 [Bugfix] Jiang Liu
2015-07-30 16:44 ` [Bugfix] Jiang Liu
     [not found] ` <1438274680-27916-1-git-send-email-jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-07-30 16:46   ` [Bugfix] Jiang Liu
2015-07-30 16:46     ` [Bugfix] Jiang Liu
2015-07-30 18:34   ` [Bugfix] Alex Deucher
2015-07-30 18:34     ` [Bugfix] Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.